Re: [Beignet] [PATCH] GBE: remove the unecessary type check for SEL instructio.

2015-03-01 Thread Song, Ruiling
LGTM > -Original Message- > From: Beignet [mailto:beignet-boun...@lists.freedesktop.org] On Behalf Of > Zhigang Gong > Sent: Monday, March 02, 2015 9:19 AM > To: beignet@lists.freedesktop.org > Cc: Gong, Zhigang > Subject: [Beignet] [PATCH] GBE: remove the unecessary type check for SEL > i

[Beignet] [PATCH] GBE: support compare two bool variables.

2015-03-01 Thread Zhigang Gong
LLVM 3.6 may generate the following instructions: %Pivot = icmp slt i1 %trunc49, false when do siwth lowering pass. To support it we must use GEN_TYPE_W to represent B rather than GEN_TYPE_UW and we also need to remove the corresponding assertions. Signed-off-by: Zhigang Gong --- backend/src/b

[Beignet] [PATCH] GBE: remove the unecessary type check for SEL instructio.

2015-03-01 Thread Zhigang Gong
The backend SEL instruction could support bool type since we change the bool representation to normal S16 data type. Now let us remove this assertion check. Signed-off-by: Zhigang Gong --- backend/src/ir/instruction.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/backend/src/ir/instructio

Re: [Beignet] [PATCH 2/3] Add llvm3.6 build support.

2015-03-01 Thread Steven Newbury
I now have another failure to build with llvm3.6 (release) not sure if it's an LLVM or flag change. It would build with "-fpermissive". See in-line. On Thu, 2015-02-12 at 16:29 +0800, Yang Rong wrote: > There are some changes from llvm3.5: > 1. Some functions return std::unique_ptr instead of po