Re: Fwd: Re: [PATCH] test/jdk/java/beans/PropertyEditor/Test6397609.java failed in JITed code

2019-01-06 Thread Alan Bateman
On 04/01/2019 08:47, Fu Jie wrote: Hi, I think Alan's approach is more readable and more elegant. And it can also fix the issue mentioned by Sergey. If I read this patch correctly then the isEditorExist is just checking that there has been some reference processing but it doesn't guarantee tha

Re: Fwd: Re: [PATCH] test/jdk/java/beans/PropertyEditor/Test6397609.java failed in JITed code

2019-01-06 Thread Fu Jie
Hi, Thanks Alan for your guidance. I like this patch and it seems very nice. Do you think we need to trigger a GC after "PropertyEditorManager.registerEditor(targetClass, editorClass);"? Best regards, Jie Here's an alternative to consider:     Class targetClass = Object.class;