RFR 8154962: [TEST] @BeanProperty: add some tests for anonimous classes

2016-04-25 Thread Alexander Stepanov
Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8154962/webrev.00/index.html for https://bugs.openjdk.java.net/browse/JDK-8154962 Just a single test added (AnonymousClassBeanPropertyTest) + minor fixes for BeanPropertyTest.java (removed unnecessary "throws"

Re: RFR 8154962: [TEST] @BeanProperty: add some tests for anonimous classes

2016-04-25 Thread Sergey Bylokhov
Looks fine. On 25.04.16 16:26, Alexander Stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8154962/webrev.00/index.html for https://bugs.openjdk.java.net/browse/JDK-8154962 Just a single test added (AnonymousClassBeanPropertyTest) + minor fixe

Re: RFR 8154962: [TEST] @BeanProperty: add some tests for anonimous classes

2016-04-25 Thread Alexander Stepanov
Thanks! On 4/25/2016 5:30 PM, Sergey Bylokhov wrote: Looks fine. On 25.04.16 16:26, Alexander Stepanov wrote: Hello, Could you please review the following fix http://cr.openjdk.java.net/~avstepan/8154962/webrev.00/index.html for https://bugs.openjdk.java.net/browse/JDK-8154962 Just a single t

Re: [9] Review Request: 8146313 The java.beans.Statement.invoke() method handles 3-arg Class.forName incorrectly

2016-04-25 Thread Andrew Gross
This looks reasonable to me. Thanks, Drew On 4/22/2016 9:20 AM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9(the fix was discussed offline already). The Statement class can execute the methods and pass some parameters for them. It can be used to store the statement(method call

Re: [9] Review Request: 8146313 The java.beans.Statement.invoke() method handles 3-arg Class.forName incorrectly

2016-04-25 Thread Semyon Sadetsky
Hi Sergey, Could you add primitive class case to the test? --Semyon On 4/22/2016 7:20 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk9(the fix was discussed offline already). The Statement class can execute the methods and pass some parameters for them. It can be used to stor

Re: [9] Review Request: 8146313 The java.beans.Statement.invoke() method handles 3-arg Class.forName incorrectly

2016-04-25 Thread Sergey Bylokhov
On 25.04.16 21:44, Semyon Sadetsky wrote: Could you add primitive class case to the test? No, the test compares behavior of Statement and Class.forName() and checks that they works similarly(returns exactly the same classes), but the latter does not support primitive types(this is supported b