On 09/02/2016 20:49, Sergey Bylokhov wrote:
On 09.02.16 23:40, Alan Bateman wrote:
Sergey - have you consider clarifying the javadoc as part of this
change?
I can add clarification that this is a shortcut to the
getResourceAsStream/getResource which simplify loading of images, but
the curr
On 09/02/2016 17:17, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk9.
The specification is updated, the test will use
IllegalArgumentException instead of IllegalAccessError.
ccc will be filed after the technical review.
Bug: https://bugs.openjdk.java.net/browse/JDK-8130061
Webr
On 11.02.16 18:26, Alan Bateman wrote:
On 09/02/2016 17:17, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk9.
The specification is updated, the test will use
IllegalArgumentException instead of IllegalAccessError.
ccc will be filed after the technical review.
Bug: https://bugs.open
On 11/02/2016 15:49, Sergey Bylokhov wrote:
The Proxy.newProxyInstance() has not the description of why the
IllegalArgumentException can be thrown, it points to
Proxy.getProxyClass():
* {@code Proxy.newProxyInstance} throws
* {@code IllegalArgumentException} for the same reasons
On 11.02.16 18:52, Alan Bateman wrote:
Proxy.getProxyClass is proposed to be deprecated in Java SE 9 - you'll
see the changes in the jake forest, they just haven't got to JDK 9 main
line yet. There is also a very clear list of restrictions in the updated
javadoc. Since you are going into jdk9/cli
> On Feb 11, 2016, at 7:58 AM, Sergey Bylokhov
> wrote:
>
> On 11.02.16 18:52, Alan Bateman wrote:
>> Proxy.getProxyClass is proposed to be deprecated in Java SE 9 - you'll
>> see the changes in the jake forest, they just haven't got to JDK 9 main
>> line yet. There is also a very clear list of
On 11.02.16 18:22, Alan Bateman wrote:
One thing that could be done, separate issue if you want, is update the
@return to say that it returns null if the resource is not found or the
resource could not be loaded as an Image. That might be clearer than the
existing wording.
Something like this?
On 11.02.16 18:58, Sergey Bylokhov wrote:
On 11.02.16 18:52, Alan Bateman wrote:
Proxy.getProxyClass is proposed to be deprecated in Java SE 9 - you'll
see the changes in the jake forest, they just haven't got to JDK 9 main
line yet. There is also a very clear list of restrictions in the updated
