Re: [PATCH 0/4] {master} maintainer checks: improve a little and reorganize

On 01/30/2012 09:46 PM, Peter Rosin wrote: > Stefano Lattarini skrev 2012-01-30 18:54: >> I will push the series later, once Peter's testsuite-related patches >> have been applied. > > Go ahead, I'll pick up the ar-lib piece later... > Thanks, pushed. Regards, Stefano

Re: [PATCH 0/4] {master} maintainer checks: improve a little and reorganize

Stefano Lattarini skrev 2012-01-30 18:54: > I will push the series later, once Peter's testsuite-related patches > have been applied. Go ahead, I'll pick up the ar-lib piece later... Cheers, Peter

Re: [PATCH 0/4] {master} maintainer checks: improve a little and reorganize

27;*.am' files >> build: require GNU make to run the maintainer checks >> maintcheck: take advantage of some GNU make features >> maintcheck: fix real and spurious warnings > > Those all look fine, at least upon cursory examination. > >> build: re

Re: [PATCH 0/4] {master} maintainer checks: improve a little and reorganize

Stefano Lattarini wrote: > I will push this series to master in a couple of days if there is > no objection. > > Stefano Lattarini (4): > maintcheck: refactor rules checking '*.am' files > build: require GNU make to run the maintainer checks > maintcheck:

[PATCH 2/4] build: require GNU make to run the maintainer checks

Literal TAB. - -e '1,/^/d' \ -## Allow @ so we match conditionals. - -e '/^ *[a-zA-Z_@]\{1,\} *=/p' $$file`; \ - if test -n "$$latevars"; then \ - echo 'Ensure variables are expanded before rules' >&2; \ -

[PATCH 0/4] {master} maintainer checks: improve a little and reorganize

I will push this series to master in a couple of days if there is no objection. Regards, Stefano Stefano Lattarini (4): maintcheck: refactor rules checking '*.am' files build: require GNU make to run the maintainer checks maintcheck: take advantage of some GNU make features

Re: maintainer checks

On Saturday 20 November 2010, Ralf Wildenhues wrote: > For what it's worth, file:line notation is not ideal because it is > maintenance-intensive for files which change regularly. > Just to be clear: my script support *both* the "file:line" notation and the "file" noation. The support for "file:r

Re: maintainer checks

* Stefano Lattarini wrote on Sat, Nov 20, 2010 at 04:33:18PM CET: > On Saturday 20 November 2010, Ralf Wildenhues wrote: > > * Stefano Lattarini wrote on Tue, Nov 16, 2010 at 12:15:12AM CET: > > > > > > > > > > Gnulib has

maintainer checks (was: Re: [PATCH] {maint} Improve and extend tests on de-ansification support.)

On Saturday 20 November 2010, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Tue, Nov 16, 2010 at 12:15:12AM CET: > > On Monday 15 November 2010, Ralf Wildenhues wrote: > > > > > > Well then we should adjust maintainer-check to not complain. Either > > > way, maintainer-check results shoul

Re: [SIMPLE PATCHES] {maint} Minor improvements to maintainer checks

> > > @@ -358,6 +359,14 @@ sc_tests_plain_perl: > > exit 1; \ > > > > fi > > > > +## Look for common typos in the definition of `$required'. > > +sc_tests_required_typos: > > + @if grep -v '^#' $(srcdir)/tests/*.test |

Re: [SIMPLE PATCHES] {maint} Minor improvements to maintainer checks

* Stefano Lattarini wrote on Thu, Sep 16, 2010 at 01:14:46PM CEST: > OK for maint? The first one is ok with nit below addressed. The second one seems too ad-hoc and maintenance-intensive (we should strive for code that needs as little maintenance as possible), I'd rather beat your patches in shap

[SIMPLE PATCHES] {maint} Minor improvements to maintainer checks

OK for maint? Regards, Stefano -*-*-*- [PATCH 1/2] New maintainer check, for typos in $required definition. * Makefile.am (sc_tests_required_typos): New maintaner check. (syntax_check_rules): Updated. From a report by Peter Rosin. --- ChangeLog |7 +++ Makefile.am |9 +

Re: [RFC] Refactoring maintainer checks (use perl, add whitelisting)

At Monday 26 July 2010, Ralf Wildenhues wrote: > Hello Stefano, Hi Ralf. How did the GHM go? > * Stefano Lattarini wrote on Mon, Jul 26, 2010 at 01:58:08PM CEST: > > This patch substitutes (almost) all the sed/grep maintainer > > syntax checks in `Makefile.am' with a new perl script > > `maintche

Re: [RFC] Refactoring maintainer checks (use perl, add whitelisting)

Hello Stefano, * Stefano Lattarini wrote on Mon, Jul 26, 2010 at 01:58:08PM CEST: > This patch substitutes (almost) all the sed/grep maintainer syntax checks > in `Makefile.am' with a new perl script `maintcheck.pl'. Why? Honest question. perl regex isn't necessarily more readable than sed, in

[RFC] Refactoring maintainer checks (use perl, add whitelisting)

script allows a greater flexibilty in the definition of new syntax checks, and, IMHO most importantly, allows to whitelist known "false positives". Admittedly, these new perl-based maintainer checks are quite slower, and might take up to twice the running time than the old sed+grep maint