Re: local perl $_ variable is not portable

2011-01-18 Thread Stefano Lattarini
On Tuesday 18 January 2011, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Mon, Jan 17, 2011 at 10:47:04PM CET: > > On Monday 17 January 2011, Ralf Wildenhues wrote: > > > * Stefano Lattarini wrote on Mon, Jan 17, 2011 at 01:39:29AM CET: > > > > BTW, I'd also add to the ChangeLog entry the "

Re: local perl $_ variable is not portable

2011-01-17 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Mon, Jan 17, 2011 at 10:47:04PM CET: > On Monday 17 January 2011, Ralf Wildenhues wrote: > > * Stefano Lattarini wrote on Mon, Jan 17, 2011 at 01:39:29AM CET: > > > BTW, I'd also add to the ChangeLog entry the "git describe" output > > > for the commit where I messed th

Re: local perl $_ variable is not portable

2011-01-17 Thread Stefano Lattarini
Hi Ralf. Just a small nit with the application of this patch ... On Monday 17 January 2011, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Mon, Jan 17, 2011 at 01:39:29AM CET: > > On Sunday 16 January 2011, Ralf Wildenhues wrote: > > >foreach my $h (@list) > > > { > > > - my

Re: local perl $_ variable is not portable

2011-01-16 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Mon, Jan 17, 2011 at 01:39:29AM CET: > On Sunday 16 January 2011, Ralf Wildenhues wrote: > >foreach my $h (@list) > > { > > - my $_ = $h->{'option'}; > > + $_ = $h->{'option'}; > > > What about using a "good ol' local" here? E.g.: > local $_ = $h-

Re: local perl $_ variable is not portable

2011-01-16 Thread Stefano Lattarini
On Sunday 16 January 2011, Ralf Wildenhues wrote: > On the AIX 5.1 I test on, perl 5.0.8 fails over a recent Options.pm > change: > > $ ./tests/automake-1.11a --help > Can't use global $_ in "my" at > /tmp/build-powerpc-ibm-aix5.2.0.0/../automake/lib/Automake/Options.pm line > 263, near "my $_ "