Re: [PATCH v2] Work around a bug in Solaris make's file-inclusion mechanism.

2010-09-22 Thread Stefano Lattarini
On Wednesday 15 September 2010, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Wed, Sep 15, 2010 at 01:26:50PM CEST: > > OK for maint? No, it's not. There's still a bug (causing regression) due to some dark corners in Perl handling of `$1' across statements (ouch!). The new bug triggers

Re: [PATCH v2] Work around a bug in Solaris make's file-inclusion mechanism.

2010-09-15 Thread Stefano Lattarini
Hi Ralf. Thanks for the review. On Wednesday 15 September 2010, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Wed, Sep 15, 2010 at 01:26:50PM CEST: > > OK for maint? > > I really think you should use an extra function normalize_file_name > to do the job, for maintainability. > > > I do

Re: [PATCH v2] Work around a bug in Solaris make's file-inclusion mechanism.

2010-09-15 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Wed, Sep 15, 2010 at 01:26:50PM CEST: > OK for maint? I really think you should use an extra function normalize_file_name to do the job, for maintainability. Please run make maintainer-check. Typo patologic. A couple more nits below. I don't think we want subobj11c