Hello,
On Fri, Aug 04, 2006 at 02:54:23PM +0200, Alexandre Duret-Lutz wrote:
> I'm installing this as follows, removing another reference to
> DISTDIRS in dist.am, fixing distdir.test so it passes, and
> fixing the (c) year of pr2.test,
thank you very much for the fixes. (I wonder why I thought
Thank you, and sorry for the delay.
I'm installing this as follows, removing another reference to
DISTDIRS in dist.am, fixing distdir.test so it passes, and
fixing the (c) year of pr2.test,
2006-08-04 Stepan Kasal <[EMAIL PROTECTED]>
* automake.in (dist_dirs, fill_dist_dirs): Remove.
Hello,
a month ago I submitted this patch:
http://lists.gnu.org/archive/html/automake-patches/2006-06/msg0.html
Any opinions?
Stepan Kasal
2006-06-02 Stepan Kasal <[EMAIL PROTECTED]>
* automake.in (dist_dirs, fill_dist_dirs): Remove.
* lib/am/distdir.am (DISTDIRS): Remove
* Alexandre Duret-Lutz wrote on Tue, Jun 06, 2006 at 10:11:46PM CEST:
> >>> "RW" == Ralf Wildenhues <[EMAIL PROTECTED]> writes:
> RW> Updated patch below. What do you think?
>
> I'm leery of the escaping substitution to define the *strip
> variables,
Just curious, but why?
> but let's go and
>>> "RW" == Ralf Wildenhues <[EMAIL PROTECTED]> writes:
[...]
RW> Updated patch below. What do you think?
I'm leery of the escaping substitution to define the *strip
variables, but let's go and see.
[...]
RW> + case $$dist_files in */*) \
RW> +( cd "$(distdir)"; \
RW> + $(mkdir_
Hello,
FWIIW, I like this version of the patch:
On Wed, May 24, 2006 at 09:48:34PM +0200, Ralf Wildenhues wrote:
> 2006-05-24 Stepan Kasal <[EMAIL PROTECTED]>
> Ralf Wildenhues <[EMAIL PROTECTED]>
>
> * lib/am/distdir.am: Do not call $(mkdir_p) for each
> distributed fi
* Ralf Wildenhues wrote on Wed, May 24, 2006 at 06:30:56AM CEST:
>
> > > + list=`for file in $$list; do echo $$file; done | \
> > > + | sed -e "s|^$$srcdirstrip/||;t" \
> > > + -e "s|^$$topsrcdirstrip/|$(top_builddir)/|;t"`;; \
> > > +## (The second `t' command clears
* quoting myself:
> * Stepan Kasal wrote on Tue, May 23, 2006 at 10:43:50PM CEST:
> > - or if the author of Makefile.am usees $(srcdir) or $(top_srcdir)
> > (well educated maintainers don't)
>
> This is wrong. Well-educated maintainers do this in some situations:
> when the file in question is
Hi Stepan,
* Stepan Kasal wrote on Tue, May 23, 2006 at 10:43:50PM CEST:
> On Tue, May 23, 2006 at 09:31:18PM +0200, Ralf Wildenhues wrote:
>
> > I think we can kill the per-file forks before the mkdir_p, too.
>
> You mean the $(srcdir) and $(top_srcdir) stripping. But it takes
> place only in
Hello Ralf,
thank you for your review and improvements.
A few quick comments:
On Tue, May 23, 2006 at 09:31:18PM +0200, Ralf Wildenhues wrote:
> [...] nobody uses `|' in a file name. I think it's pretty safe
> to assume this. [...]
Sure it is. The current code already assumed that:
case .
Hi Stepan,
* Stepan Kasal wrote on Tue, May 23, 2006 at 03:29:01PM CEST:
> On Sun, May 14, 2006 at 07:32:57PM +0200, Ralf Wildenhues wrote:
> > Hmm. You could "sort -u" the list of directories to create at "make
> > dist" time.
>
> nice idea. Attached please find a patch which implements it.
T
Hello,
On Sun, May 14, 2006 at 07:32:57PM +0200, Ralf Wildenhues wrote:
> Hmm. You could "sort -u" the list of directories to create at "make
> dist" time.
nice idea. Attached please find a patch which implements it.
The patch eliminates the following
dir=`echo "$$file" | sed -e 's,/[^
Hi Stepan,
* Stepan Kasal wrote on Sun, May 14, 2006 at 04:58:57PM CEST:
>
> I have two proposals:
>
> First is simple: during `make dist', changing $(mkdir_p) to
> test -d .. || $(mkdir_p) ..
> would speed up things.
> As the second proposal, I have the radical idea of removing the
> DIS
Hello,
I have looked at how the subdirectories of distdir are created.
Let me sum up:
i) automake collects all subdirectories in variable DISTDIRS, and the
top level Makefile.in then contains:
$(mkdir_p) %DISTDIRS%
ii) During `make dist', before each of the files is copied, the
correspo
14 matches
Mail list logo
