Re: [PATCH 3/3] ylwrap: rename header inclusion in generated parsers

2012-07-16 Thread Stefano Lattarini
On 07/15/2012 11:28 AM, Akim Demaille wrote: > Hi Stefano, > > Le 14 juil. 2012 à 10:07, Stefano Lattarini a écrit : > >> Oh, and: since you've fixed actual bugs, I think a NEWS entry is >> warranted. You can add that with a follow-up patch on the top of >> yacc-work (before that is merged to ma

Re: [PATCH 3/3] ylwrap: rename header inclusion in generated parsers

2012-07-15 Thread Akim Demaille
Hi Stefano, Le 14 juil. 2012 à 10:07, Stefano Lattarini a écrit : > Oh, and: since you've fixed actual bugs, I think a NEWS entry is > warranted. You can add that with a follow-up patch on the top of > yacc-work (before that is merged to maint). I've pushed this in yacc-work-2. * Long-standing

Re: [PATCH 3/3] ylwrap: rename header inclusion in generated parsers

2012-07-14 Thread Stefano Lattarini
On 07/14/2012 10:05 AM, Stefano Lattarini wrote: > On 07/14/2012 09:13 AM, Akim Demaille wrote: >> yacc-work should actually go into maint, not just master. >> > I agree, since it implements backward-compatible bug-fixes. > > But I see that yacc-work is based off of master, so that it is > current

Re: [PATCH 3/3] ylwrap: rename header inclusion in generated parsers

2012-07-14 Thread Stefano Lattarini
On 07/14/2012 09:13 AM, Akim Demaille wrote: > yacc-work should actually go into maint, not just master. > I agree, since it implements backward-compatible bug-fixes. But I see that yacc-work is based off of master, so that it is currently impossible to merge it into maint. Could you please re-ba

Re: [PATCH 3/3] ylwrap: rename header inclusion in generated parsers

2012-07-14 Thread Stefano Lattarini
Hi Akim. On 07/14/2012 09:24 AM, Akim Demaille wrote: > > Le 14 juil. 2012 à 09:13, Akim Demaille a écrit : > >> The failure is due to the input: >> >> %{ >> int yylex () { return 0; } >> void yyerror (const char *s) { return; } >> %} >> %% >> foobar : 'f' 'o' 'o' 'b' 'a' 'r' {}; >> >> %{%} goes

Re: [PATCH 3/3] ylwrap: rename header inclusion in generated parsers

2012-07-14 Thread Akim Demaille
Le 14 juil. 2012 à 09:13, Akim Demaille a écrit : > The failure is due to the input: > > %{ > int yylex () { return 0; } > void yyerror (const char *s) { return; } > %} > %% > foobar : 'f' 'o' 'o' 'b' 'a' 'r' {}; > > %{%} goes into the header when there is one, and it also goes > in the impleme

Re: [PATCH 3/3] ylwrap: rename header inclusion in generated parsers

2012-07-14 Thread Akim Demaille
Le 13 juil. 2012 à 19:31, Stefano Lattarini a écrit : > On 07/13/2012 04:20 PM, Akim Demaille wrote: >> >> Sorry about these. Updated below, and in the branch too. >> > Thanks. I'm still seeing the test case 'yacc-bison-skeleton.sh' failing > on the Debian 64 bit system gcc10.fsffrance.org.

Re: [PATCH 3/3] ylwrap: rename header inclusion in generated parsers

2012-07-13 Thread Stefano Lattarini
On 07/13/2012 04:20 PM, Akim Demaille wrote: > > Sorry about these. Updated below, and in the branch too. > Thanks. I'm still seeing the test case 'yacc-bison-skeleton.sh' failing on the Debian 64 bit system gcc10.fsffrance.org. Below is the log: Running from installcheck: no Using TAP: no

Re: [PATCH 3/3] ylwrap: rename header inclusion in generated parsers

2012-07-13 Thread Stefano Lattarini
On 07/13/2012 04:22 PM, Akim Demaille wrote: > > Le 13 juil. 2012 à 15:24, Stefano Lattarini a écrit : > >>> I have many failures, I don't know if this is expected. >>> >> Not expected at all. Could you post their list, and maybe also the >> contents of 'test-suite.log'? > > It was attached in

Re: [PATCH 3/3] ylwrap: rename header inclusion in generated parsers

2012-07-13 Thread Akim Demaille
Le 13 juil. 2012 à 16:00, Stefano Lattarini a écrit : > Hi Akim. > > The commit 'a4fd5c7c2cd2a2b626c670741313f0a94c38c529' that you've pushed > is broken; it defines '$rename_sed', but do not actually use it, and > thus does not fix the bug it says it fixes. Only the later commit > cd94deae0c8a

Re: [PATCH 3/3] ylwrap: rename header inclusion in generated parsers

2012-07-13 Thread Stefano Lattarini
Hi Akim. The commit 'a4fd5c7c2cd2a2b626c670741313f0a94c38c529' that you've pushed is broken; it defines '$rename_sed', but do not actually use it, and thus does not fix the bug it says it fixes. Only the later commit cd94deae0c8abccbd33e3d03983f4a607fafb4ad (that should be just a cosmetic or styl

Re: [PATCH 3/3] ylwrap: rename header inclusion in generated parsers

2012-07-13 Thread Stefano Lattarini
On 07/13/2012 03:19 PM, Akim Demaille wrote: > > Le 13 juil. 2012 à 13:43, Stefano Lattarini a écrit : > > * lib/ylwrap (rename_sed): New. > (main loop): Use it the rename the dependencies to other files. > Oops, diving straight into the details, no rationale. No good. >>> >>> W

Re: [PATCH 3/3] ylwrap: rename header inclusion in generated parsers

2012-07-13 Thread Stefano Lattarini
On 07/13/2012 01:59 PM, Akim Demaille wrote: > > Le 13 juil. 2012 à 13:43, Stefano Lattarini a écrit : > >> See? Another thing I had got wrong, given my ignorance and the lack >> of a proper explanation ;-) > > I also meant that the bug is obvious :) If you rename files, you > have to rename f

Re: [PATCH 3/3] ylwrap: rename header inclusion in generated parsers

2012-07-13 Thread Akim Demaille
Le 13 juil. 2012 à 13:43, Stefano Lattarini a écrit : > See? Another thing I had got wrong, given my ignorance and the lack > of a proper explanation ;-) I also meant that the bug is obvious :) If you rename files, you have to rename files that use them, and that this is in the context of Biso

Re: [PATCH 3/3] ylwrap: rename header inclusion in generated parsers

2012-07-13 Thread Stefano Lattarini
Hi Akim. On 07/13/2012 01:20 PM, Akim Demaille wrote: > > Le 12 juil. 2012 à 18:22, Stefano Lattarini a écrit : > >> On 07/12/2012 03:51 PM, Akim Demaille wrote: >>> * lib/am/yacc.am (am__yacc_c2h): Shorten. >>> >> See below. >> >>> @@ -37,8 +37,7 @@ if %?MAINTAINER-MODE% >>> @MAINTAINER_MODE_FA

Re: [PATCH 3/3] ylwrap: rename header inclusion in generated parsers

2012-07-13 Thread Akim Demaille
Le 12 juil. 2012 à 18:22, Stefano Lattarini a écrit : > On 07/12/2012 03:51 PM, Akim Demaille wrote: >> * lib/am/yacc.am (am__yacc_c2h): Shorten. >> > See below. > >> @@ -37,8 +37,7 @@ if %?MAINTAINER-MODE% >> @MAINTAINER_MODE_FALSE@am__skipyacc = test -f $@ || >> endif %?MAINTAINER-MODE% >> ##

Re: [PATCH 3/3] ylwrap: rename header inclusion in generated parsers

2012-07-12 Thread Stefano Lattarini
On 07/12/2012 03:51 PM, Akim Demaille wrote: > * lib/am/yacc.am (am__yacc_c2h): Shorten. > See below. > * lib/ylwrap (rename_sed): New. > (main loop): Use it the rename the dependencies to other files. > Oops, diving straight into the details, no rationale. No good. As an outsider, it is not cle

[PATCH 3/3] ylwrap: rename header inclusion in generated parsers

2012-07-12 Thread Akim Demaille
* lib/am/yacc.am (am__yacc_c2h): Shorten. * lib/ylwrap (rename_sed): New. (main loop): Use it the rename the dependencies to other files. * t/yacc-d-basic.sh: Exercize this case, even if bison/yacc was not issueing such an include. --- lib/am/yacc.am| 3 +-- lib/ylwrap| 15 ---