Re: [PATCH 04/10] Refactoring: new $automake_remake_options global variable.

2011-01-04 Thread Stefano Lattarini
On Monday 03 January 2011, Ralf Wildenhues wrote: > > [BIG CUT] > ... > So no, without an argument why the refactoring is necessary in order to > fix the bug (rather than just understand it), I'm sorry but I have to > reject it, on the grounds that it causes a net code quality regression. > W

Re: [PATCH 04/10] Refactoring: new $automake_remake_options global variable.

2011-01-03 Thread Ralf Wildenhues
Hello Stefano, * Stefano Lattarini wrote on Sun, Jan 02, 2011 at 11:57:42PM CET: > On Sunday 02 January 2011, Ralf Wildenhues wrote: > > * stefano.lattar...@gmail.com wrote on Thu, Dec 23, 2010 at 12:27:40PM CET: > > > This change is useful only in view of soon-to-follow refactorings > > > and sim

Re: [PATCH 04/10] Refactoring: new $automake_remake_options global variable.

2011-01-02 Thread Stefano Lattarini
On Sunday 02 January 2011, Ralf Wildenhues wrote: > Hi Stefano, > > * stefano.lattar...@gmail.com wrote on Thu, Dec 23, 2010 at 12:27:40PM CET: > > This change is useful only in view of soon-to-follow refactorings > > and simplifications, related to the fixing of Automake bug#7669 > > a.k.a. PR/54

Re: [PATCH 04/10] Refactoring: new $automake_remake_options global variable.

2011-01-02 Thread Ralf Wildenhues
Hi Stefano, * stefano.lattar...@gmail.com wrote on Thu, Dec 23, 2010 at 12:27:40PM CET: > This change is useful only in view of soon-to-follow refactorings > and simplifications, related to the fixing of Automake bug#7669 > a.k.a. PR/547. > > * automake.in (%am_remake_options): New global hash va

Re: [PATCH 04/10] Refactoring: new $automake_remake_options global variable.

2011-01-02 Thread Stefano Lattarini
Also, due to the amendedings to previous patches in the series, the following squash-in is now necessary. -*-*- diff --git a/automake.in b/automake.in index 06146cb..578df7c 100644 --- a/automake.in +++ b/automake.in @@ -8521,7 +8521,7 @@ sub parse_arguments () &parse_warnings ('-W', $warn

Re: [PATCH 04/10] Refactoring: new $automake_remake_options global variable.

2010-12-29 Thread Stefano Lattarini
Hmpf, and I used a deprecated idiom to strip the extra automake options from $AUTOMAKE; here is the additional squash-in to fix that: -*-*- diff --git a/tests/remake-am-opts.test b/tests/remake-am-opts.test index 5d8ac45..54f74ec 100755 --- a/tests/remake-am-opts.test +++ b/tests/remake-am-opts.t

Re: [PATCH 04/10] Refactoring: new $automake_remake_options global variable.

2010-12-29 Thread Stefano Lattarini
Oops, the test `remake-am-opts.test' was partly broken due to a stupid typo in the generated Automake wrapper; here is what I squashed in to fix the issue: -*-*- diff --git a/tests/remake-am-opts.test b/tests/remake-am-opts.test index 64312d5..62377d1 100755 --- a/tests/remake-am-opts.test +++ b/

[PATCH 04/10] Refactoring: new $automake_remake_options global variable.

2010-12-23 Thread stefano . lattarini
From: Stefano Lattarini This change is useful only in view of soon-to-follow refactorings and simplifications, related to the fixing of Automake bug#7669 a.k.a. PR/547. * automake.in (%am_remake_options): New global hash variable. (parse_arguments): Initialize it. (scan_autoconf_traces) [$macro