Re: [PATCH] install-sh: Fix redundant use of the force option with the rm command

2020-11-11 Thread Karl Berry
https://lists.gnu.org/archive/html/automake-patches/2018-03/msg5.html As install-sh defines $rmcmd as "$rmprog -f", it is not necessary to add a second "-f" when calling the rm command. I just installed this change, with a mention in the --help message (and NEWS file) about th

Re: [PATCH] install-sh: Fix redundant use of the force option with the rm command

2020-11-09 Thread Julien ÉLIE
Hi Karl, https://lists.gnu.org/archive/html/automake-patches/2018-03/index.html The one that seems too risky is making -c do something (preserve permissions) instead of being a no-op. I think there could easily be ancient calls of install-sh that use -c, and changing behavior now doesn't see

Re: [PATCH] install-sh: Fix redundant use of the force option with the rm command

2020-11-08 Thread Karl Berry
Hi Julien, https://lists.gnu.org/archive/html/automake-patches/2018-03/index.html Thanks for bringing them up again. I wasn't involved with automake back then, but looking at them now, they seem mostly fine. The one that seems too risky is making -c do something (preserve permissions) ins

Re: [PATCH] install-sh: Fix redundant use of the force option with the rm command

2020-11-08 Thread Julien ÉLIE
Hi all, In March 2018, I proposed 5 patches for install-sh: https://lists.gnu.org/archive/html/automake-patches/2018-03/index.html Has someone already had a chance to look at them? Is there something more that I should do? Thanks beforehand, -- Julien Le 17/03/2018 à 15:16, Julien ÉLIE a

Re: [PATCH] install-sh: Fix redundant use of the force option with the rm command

2018-09-08 Thread Julien ÉLIE
Hi all, In March 2018, I proposed 5 patches for install-sh: https://lists.gnu.org/archive/html/automake-patches/2018-03/index.html Has someone already had a chance to look at them? Is there something more that I should do? Thanks beforehand, -- Julien Le 17/03/2018 à 15:16, Julien ÉLIE a é

[PATCH] install-sh: Fix redundant use of the force option with the rm command

2018-03-17 Thread Julien ÉLIE
Hi, You'll find below a suggestion of patch. Or you could also remove "-f" from the initial $rmcmd definition, if you prefer. -- Julien ÉLIE As install-sh defines $rmcmd as "$rmprog -f", it is not necessary to add a second "-f" when calling the rm command. * lib/install-sh: Fix redundant use