Re: [PATCH] Internationalization tests: do not ignore failures.

2010-09-06 Thread Stefano Lattarini
On Monday 06 September 2010, Bruno Haible wrote: > Hi Stefano, > > > ... since the failing `test' is in a > > `||' compound command. Fix this problem by explicitly calling > > `Exit 1' where needed. > > Yes, please apply. I did not know until today that && and || > commands behave specially unde

Re: [PATCH] Internationalization tests: do not ignore failures.

2010-09-06 Thread Bruno Haible
Hi Stefano, > ... since the failing `test' is in a > `||' compound command. Fix this problem by explicitly calling > `Exit 1' where needed. Yes, please apply. I did not know until today that && and || commands behave specially under 'set -e'. Bruno

Re: shell errexit and exit status (was: [PATCH] Internationalization tests: do not ignore failures.)

2010-09-06 Thread Stefano Lattarini
On Monday 06 September 2010, Ralf Wildenhues wrote: > Hello Stefano, > > * Stefano Lattarini wrote on Mon, Sep 06, 2010 at 05:06:23PM CEST: > > This patch fixes potential false negatives in the new tests. > > > > Internationalization tests: do not ignore failures. > > > > Some tests used the idi

shell errexit and exit status (was: [PATCH] Internationalization tests: do not ignore failures.)

2010-09-06 Thread Ralf Wildenhues
Hello Stefano, * Stefano Lattarini wrote on Mon, Sep 06, 2010 at 05:06:23PM CEST: > This patch fixes potential false negatives in the new tests. > Internationalization tests: do not ignore failures. > > Some tests used the idiom: > test $builddir = '.' || test ! -f posub/foo-bar.pot > to check

[PATCH] Internationalization tests: do not ignore failures.

2010-09-06 Thread Stefano Lattarini
e: Mon, 6 Sep 2010 17:02:36 +0200 Subject: [PATCH] Internationalization tests: do not ignore failures. Some tests used the idiom: test $builddir = '.' || test ! -f posub/foo-bar.pot to check that a file is build in the source directory, not in the build directory. But even when the `errexit' shell