Re: [PATCH] {master} coverage: add tests on remake rules in more complex situations

On Saturday 09 April 2011, Bruno Haible wrote: > Hi Stefano, > > > > --author? > > > > > Right, I didn't tought about that. We should put Bruno as author here > > IMHO. > > I think you did more than 50% of the code and testing on this patch. Therefore > it's only fair if you are mentioned at pri

Re: [PATCH] {master} coverage: add tests on remake rules in more complex situations

Hi Stefano, > > --author? > > > Right, I didn't tought about that. We should put Bruno as author here > IMHO. I think you did more than 50% of the code and testing on this patch. Therefore it's only fair if you are mentioned at principal author. Bruno -- In memoriam Georg Elser

Re: [PATCH] {master} coverage: add tests on remake rules in more complex situations

On Saturday 09 April 2011, Ralf Wildenhues wrote: > Hello Stefano, Bruno, > > nice collaboration work there, thank you! > > I have a few nits, mostly really trivial. Feel free to push after > addressing them. > I agree with almost all of your nits (and I've edited the patch accordingly, see the

Re: [PATCH] {master} coverage: add tests on remake rules in more complex situations

Hello Stefano, Bruno, nice collaboration work there, thank you! I have a few nits, mostly really trivial. Feel free to push after addressing them. --author? * Stefano Lattarini wrote on Fri, Apr 08, 2011 at 12:54:27PM CEST: > Subject: [PATCH] coverage: add tests on remake rules in more complex

Re: [PATCH] {master} coverage: add tests on remake rules in more complex situations (was: Re: not breaking "make" after m4 macros and source files changed)

On Thursday 07 April 2011, Bruno Haible wrote: > Hi Stefano, > > > Done in the attached patch. > > Great! I'm glad that you could use my input, although I mostly don't know > about > the usual habits and idioms for automake unit tests. > > Comments: > > - In remake-renamed-m4-macro.test you us

Re: [PATCH] {master} coverage: add tests on remake rules in more complex situations (was: Re: not breaking "make" after m4 macros and source files changed)

Hi Stefano, > Done in the attached patch. Great! I'm glad that you could use my input, although I mostly don't know about the usual habits and idioms for automake unit tests. Comments: - In remake-renamed-m4-macro.test you use "$MAKE test" once and then "$MAKE check" (twice). Is this intentio

[PATCH] {master} coverage: add tests on remake rules in more complex situations (was: Re: not breaking "make" after m4 macros and source files changed)

[adding automake-patches] [IMHO further answers can drop automake and bug-gnulib] Reference: On Sunday 03 April 2011, Bruno Haible wrote: > Hi Ralf, Stefano, > > > I'll make amend by writing the new testcases, if you can wait so