[bug#72536] [PATCH] tap: followups for the new `--stderr-prefix' option

2025-02-27 Thread Richard Hansen
On 2/27/25 18:36, Richard Hansen wrote: On first glance it appears to be a quoting issue with $HOME/.config.site: I got a copy of the config.site and confirmed that there are some under-quoted variable expansions in it. I'm not sure why it didn't fail before. Rather than r

[bug#76622] [PATCH] tests: force Autoconf site defaults to `/dev/null'

2025-02-27 Thread Richard Hansen
* t/ax/test-defs.in: Set `CONFIG_SITE' to `/dev/null' to prevent the system's Autoconf site defaults from breaking the test environment. --- t/ax/test-defs.in | 4 1 file changed, 4 insertions(+) diff --git a/t/ax/test-defs.in b/t/ax/test-defs.in index 755445494..9aed4ae10 100644 --- a/t/ax/

[bug#72536] [PATCH] tap: followups for the new `--stderr-prefix' option

2025-02-27 Thread Richard Hansen
On 2/27/25 16:01, Karl Berry wrote: Or, briefly looking at the logs, I wonder if his incredibly complex $HOME/config.site file could be interfering with the tests -- though it never did before. Maybe we somehow have to disable that for automake test. Hmm. On first glance it appears to be a quot

[bug#72536] [PATCH] tap: followups for the new `--stderr-prefix' option

2025-02-27 Thread Richard Hansen
On 2/27/25 16:01, Karl Berry wrote: Hi Richard - a friend (Nelson Beebe) ran the automake test suite on numerous systems on the 1.17.90 pretest. There was a plethora of failures, and they seem to related to the new stderr-prefix failure and shell quoting. Maybe. Looking. Feel free to revert a

[bug#72536] [PATCH] tap: followups for the new `--stderr-prefix' option

2025-02-23 Thread Richard Hansen
processing order. -Richard From f5a83ea47e3bed44cd1f1c21eff1ed71b3afc605 Mon Sep 17 00:00:00 2001 From: Richard Hansen Date: Sun, 23 Feb 2025 19:01:50 -0500 Subject: [PATCH 1/3] doc: Revise `--stderr-prefix' documentation * doc/automake.texi (TAP prefixing stderr): Tweak the wording to cl

[bug#72536] [PATCH v4] tap: new `--stderr-prefix' option to prefix test script's stderr

2025-02-21 Thread Richard Hansen
ments to the new tests to make them easier to read. From 960edb44217db546c6986cfe7dc646a3a175ea5b Mon Sep 17 00:00:00 2001 From: Richard Hansen Date: Mon, 3 Feb 2025 18:26:50 -0500 Subject: [PATCH 01/10] tests: turn off `set -x' in `diag_' * t/ax/tap-functions.sh (diag_): Turn off `se

[bug#72536] [PATCH v3] tap: new `--stderr-prefix' option to prefix test script's stderr

2025-02-21 Thread Richard Hansen
On 2/20/25 19:29, Jacob Bachmeyer wrote: Could we filter both stdout and stderr through functions that timestamp each line, then merge the two and sort on the timestamps? Unfortunately this wouldn't help---it would be subject to the same reordering race condition. The timestamp value that is

[bug#72536] [PATCH v3] tap: new `--stderr-prefix' option to prefix test script's stderr

2025-02-21 Thread Richard Hansen
On 2/20/25 18:23, Karl Berry wrote: (a) not piping stderr through the prefixing function when the prefix is the empty string, and (b) avoiding stdout buffering when stderr is prefixed. Those sound desirable in any case. Especially the first. It's highly desirable for existing behavior to rema

[bug#76448] [PATCH] automake: add missing AC_MSG_RESULT calls to AM_SANITY_CHECK

2025-02-20 Thread Richard Hansen
* m4/sanity.m4 (AM_SANITY_CHECK): Call AC_MSG_RESULT before erroring out so that a complete line is printed to stdout before the error message is written to stderr. --- m4/sanity.m4 | 2 ++ 1 file changed, 2 insertions(+) diff --git a/m4/sanity.m4 b/m4/sanity.m4 index 53538a873..be4b16113 100644

[bug#72536] [PATCH v3] tap: new `--stderr-prefix' option to prefix test script's stderr

2025-02-19 Thread Richard Hansen
On 2/19/25 12:48, Karl Berry wrote: A separate question (for anyone), when we get that far ... what's the best way to apply/commit a patch series like this? 1. Save all of the *.patch attachments to disk. 2. Run `git am /path/to/*.patch`. Usually I use `git send-email` to email commits; th

[bug#72536] [PATCH v3] tap: new `--stderr-prefix' option to prefix test script's stderr

2025-02-19 Thread Richard Hansen
On 2/19/25 12:47, Karl Berry wrote: However ... when I ran make check with the changes installed, the tap-merge-stdout-stderr test failed. Did it succeed for you? Before I delved into it, thought I'd check back. Doh! There's a race condition and no portable (POSIX) way to fix it, I think. Th

[bug#72536] [PATCH v3] tap: new `--stderr-prefix' option to prefix test script's stderr

2025-02-03 Thread Richard Hansen
now suggest `[stderr]' prefix instead of `' * Minor improvements to Automake's own test infrastructure Thanks, Richard From 788cab38c23cd013a93a66b42d1bbc66d3fdb81b Mon Sep 17 00:00:00 2001 From: Richard Hansen Date: Mon, 3 Feb 2025 18:26:50 -0500 Subject: [PATCH 01/10] tests: t

[bug#72536] [PATCH v2] tap: new `--stderr-prefix' option to prefix test script's, stderr

2024-08-12 Thread Richard Hansen
is tested - tested with and without --merge I expect to hear back from ass...@gnu.org today (Monday) with the copyright assignment agreement; I'll get that signed and sent ASAP. Thanks, Richard From 4b914acebc1e5e691bd88fc01549208303cd2609 Mon Sep 17 00:00:00 2001 From: Richard Hanse

[bug#72536] [PATCH] tap: new `--merge-prefix' option to prefix stderr before merging

2024-08-09 Thread Richard Hansen
On 2024-08-09 22:47:32-04:00, Jacob Bachmeyer wrote: I would suggest `--label-stderr' or `--stderr-message-prefix' as better option names to open a discussion.  The main problem I see with `--merge-prefix' is that it is using "merge" in a sense that can only be understood with the detailed cont

[bug#72536] [PATCH] tap: new `--merge-prefix' option to prefix stderr before merging

2024-08-09 Thread Richard Hansen
avoid potential conflicts with the test script. From a8cbb5a235f89e127aef836a12e5813de112cb91 Mon Sep 17 00:00:00 2001 From: Richard Hansen Date: Thu, 8 Aug 2024 23:34:45 -0400 Subject: [PATCH 1/2] tap: new `--merge-prefix' option to prefix stderr before merging * lib/tap-driver.sh: Add a n