[PATCH] lib: drop unused shell variables

Detected by ShellCheck. * lib/depcomp: Drop never used $digits. * lib/ylwrap: Drop --basedir and $basedir, seems like that was old C&P error from 210797967a. --- lib/depcomp | 1 - lib/ylwrap | 4 2 files changed, 5 deletions(-) diff --git a/lib/depcomp b/lib/depcomp index 65cbf7093..39f72

[PATCH] tests: fix bug in dejagnu testcase

This resolves testsuite error: ERROR: tcl error sourcing ./spanner.test/spanner.exp. ERROR: couldn't execute "./spanner": no such file or directory while executing "spawn $SPANNER" (file "./spanner.test/spanner.exp" line 2) invoked from within "source ./spanner.test/spanner.exp" ("u

Re: bug#20082: new warning from ar on rawhide systems

On Tuesday 02 of June 2015 16:22:50 Pavel Raiskup wrote: > On Saturday 18 of April 2015 11:50:31 Pavel Raiskup wrote: > > On Friday 17 of April 2015 18:07:57 Peter Rosin wrote: > > > On 2015-04-17 17:54, Pavel Raiskup wrote: > > > > I tried to prepare the patch, but t

Re: automake: port to perl 5.17

On Wednesday 10 of February 2016 16:57:51 Ingo Brückl wrote: > Unescaped left brace in regex is deprecated and causes a warning. > It will become an error in a later perl release. I believe this is for Perl 5.22, not 5.17: https://lists.gnu.org/archive/html/automake-patches/2015-07/msg0.html

Testsuite failure with new Perl

([^ \t=:+{}]+)}/ at /usr/bin/automake line 3936. Please consider the attached patch. [1] https://bugzilla.redhat.com/attachment.cgi?id=1046458 Pavel >From 34163794a58b5bd91c5d6bd9adf5437571c7a479 Mon Sep 17 00:00:00 2001 From: Pavel Raiskup Date: Tue, 7 Jul 2015 10:54:24 +0200 Subject: [PATCH] bin

Re: bug#20082: new warning from ar on rawhide systems

On Saturday 18 of April 2015 11:50:31 Pavel Raiskup wrote: > On Friday 17 of April 2015 18:07:57 Peter Rosin wrote: > > On 2015-04-17 17:54, Pavel Raiskup wrote: > > > I tried to prepare the patch, but thats probably wrong. It would be nice > > > if somebody could c

[PATCH] install-sh: avoid (low risk) race in /tmp

Ensure that nobody can cross privilege boundaries by pre-creating symlink on '$tmpdir' path. Just testing 'mkdir -p' by creating '/tmp/ins$RANDOM-$$/d' is not safe because '/tmp' directory is usually world-writeable and '/tmp/ins$RANDOM-$$' content could be pretty easily guessed by attacker (at le

Re: bug#14891: [PATCH] automake: account for perl hash order randomization (was: Re: bug#14891: GNU Automake 1.14 FAIL: 5)

> These are not Solaris issues AFAIK, but are due to an incompatible > change in perl 5.18. The patch below should take care of it. > Can you confirm it works? FWIW, it fixed the testsuite problem for me (after change to perl 5.18). I also don't see any problem in your patch. Pavel

Re: bug#13588: Pax hangs in case big UID

Hi! > I have re-introduced the line removed by mistake. It seems to be completely OK now, thanks a LOT for your patience. I don't see any problems and also all test passes for me. Have a nice day, Pavel

Re: bug#13588: Pax hangs in case big UID

Stefano, this patch is quite hard to follow because of the new indentation. But both checks are saying PASS for me now. I have found one possible problem (missing one line): > -done > -am__tar="$_am_tar --format=m4_if([$1], [pax], [posix], [$1]) -chf - > "'"$$tardir"' > -am__tar_="$

Re: bug#13588: Pax hangs in case big UID

> Actually, I prefer to keep the checks distinct, and output the problematic > UID/GID as well (makes debugging easier). So I'd rather drop the squash-in > patch you proposed. No problem :). > > I'm also quite afraid of testsuite performance of testsuite - this > > check costs more than 6 second

Re: bug#13588: Pax hangs in case big UID

ESULT([no]) > + _am_tools=none > +fi], Here ^^ it would be possible to de-duplicate (just one message to standard output and little simpler code). But it is just a matter of taste. To make it easier, follows the patch, do not assign me as a co-author. I'm also quite afraid

Re: bug#13588: Pax hangs in case big UID

Hi, thanks a lot for working on this! I would like to point some notes, sorry for doing it so late.. > diff --git a/m4/tar.m4 b/m4/tar.m4 > index ec8c83e..61c1206 100644 > --- a/m4/tar.m4 > +++ b/m4/tar.m4 > @@ -81,7 +81,31 @@ do >AM_RUN_LOG([tardir=conftest.dir && eval $am__tar_ >conftest.ta

Re: [PATCH v3 1/2] aclocal: just warn if the primary local m4 dir doesn't exist (don't error)

ened with '('. > [..] > diff --git a/THANKS b/THANKS > index 66498d4..5c014bf 100644 > --- a/THANKS > +++ b/THANKS > @@ -297,6 +297,7 @@ Paul Jarc p...@po.cwru.edu > Paul Lunau t...@lunau.me.uk > Paul Martinolich

Re: bug#13514: [PATCH v2 0/0] AC_CONFIG_MACRO_DIR && non-existent directory

>> Yes, but not if they don't want (or don't necessarily need) to switch >> macros into different directory than 'm4'? > > There might be a misunderstanding here (either from your part, or in > my understanding of what you are saying). Are you aware that none of > the autotools use *any* local m4

[PATCH 2/2] aclocal: fix for more-than-once specified directories

Related to automake bug#13514. Do not explore these directories multiple times in 'aclocal'. This causes problems on older packages that specify configure.ac: AC_CONFIG_MACRO_DIRS([m4]) Makefile.am: ACLOCAL_AMFLAGS = -I m4 when the m4 directory does not exist. See:

[PATCH v2 0/0] AC_CONFIG_MACRO_DIR && non-existent directory

Hi, thanks for your comments! Here is second iteration of my proposal. [PATCH 1/2] aclocal: just warn if the primary local m4 dir doesn't aclocal.in | 10 ++ t/aclocal-macrodir.tap | 22 +- [PATCH 2/2] aclocal: fix for more-than-once specified directories

[PATCH 1/2] aclocal: just warn if the primary local m4 dir doesn't exist (no error)

Related to automake bug#13514. Every bootstrapping process which does not need to have the local macro directory existing in version control system (because it does not have any user-defined macros) would fail during 'autoreconf -vfi' phase if the AC_CONFIG_MACRO_DIRS([m4]) is specified (to force

Re: [RFC 05/20] depcomp: safer quoting in variable expansion

Hi, On Thu, 2012-10-18 at 22:40 +0200, Stefano Lattarini wrote: > * lib/depcomp (pgcc): Here. Probably not needed, but since the > rest of the script seems to employ proper quoting, better to be > consistent. > > Signed-off-by: Stefano Lattarini > --- > lib/depcomp | 8 > 1 file chang