[bug#68416] [PATCH] python: add 3.20 - 3.16 to the version search list

2024-01-13 Thread Mike Frysinger
On 13 Jan 2024 19:12, Karl Berry wrote: > Not proposing to try anything for our upcoming release, but I wonder if > there is some more general way to handle Python versions? We don't have > to laboriously list every possible version for anything else. yeah, it sucks. i'm on the fence whether we s

[bug#68416] [PATCH] python: add 3.20 - 3.16 to the version search list

2024-01-12 Thread Mike Frysinger
With Python 3.12 out now, and 3.13 out in ~9 months, the existing runway is running out. Bump up to 3.20 for the next Automake release. * m4/python.m4: Add python3.20 - python3.16. * NEWS: Mention new Python versions. --- NEWS | 2 +- m4/python.m4 | 1 + 2 files changed, 2 insertions(+),

[bug#67498] Fixes for Windows

2023-12-02 Thread Mike Frysinger
On 27 Nov 2023 14:35, Karl Berry wrote: > https://savannah.gnu.org/patch/?10417 > > Unfortunately, last I heard, the new libtool maintainer was AWOL and no > one is left actively maintaining it. Or even looking for a maintainer. A > sad state of affairs :(. --best, karl. i've always been curi

[bug#67268] [PATCH] texinfo: add pointer about combining tests

2023-12-02 Thread Mike Frysinger
On 02 Dec 2023 15:09, Karl Berry wrote: > very extensive "Portable Shell Programming" chapter: > > https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.71/html_node/Portable-Shell.html > > I know. The Autoconf manual already describes this issue in detail. > The point of

[bug#67268] [PATCH] texinfo: add pointer about combining tests

2023-12-02 Thread Mike Frysinger
On 18 Nov 2023 19:27, Karl Berry wrote: > Hi Michael, > > > Date: Sun, 16 Oct 2016 18:35:53 +0200 > From: Michael Stapelberg > To: automake-patches@gnu.org > Subject: [PATCH] texinfo: add pointer about combining tests > > https://lists.gnu.org/archive/html/automake-patches/2

[bug#67516] [PATCH] aclocal: handle both # and dnl for serial number lines

2023-12-01 Thread Mike Frysinger
On 01 Dec 2023 16:10, Karl Berry wrote: > without realizing it's basically silently ignored. if we don't want > to support dnl, we should prob be chatty about it at some log level. > > The "Serials" node in the manual only mentions "#". I guess I don't see > a need to go out of our way to

[bug#67516] [PATCH] aclocal: handle both # and dnl for serial number lines

2023-12-01 Thread Mike Frysinger
On 28 Nov 2023 16:27, Nick Bowler wrote: > On 2023-11-28 16:06, Karl Berry wrote: > > Hi Ross - you sent a change to automake-patches back in February 2017. > > Sorry for the absurdly delayed reply. > > > > > > https://lists.gnu.org/archive/html/automake-patches/2017-02/msg1.html > > > >

[bug#59990] [PATCH] tests: depcomp: ensure make_ok() fails when run_make fails

2023-01-15 Thread Mike Frysinger
thanks, lgtm, merged -mike

[bug#60829] [PATCH] m4: use AS_IF to avoid ! portability issues

2023-01-15 Thread Mike Frysinger
Since the ! builtin has portability issues (as documented in the Autoconf manual), switch to AS_IF which takes care of these issues for us. * m4/sanity.m4: Switch `if` to AS_IF. --- m4/sanity.m4 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/m4/sanity.m4 b/m4/sanity.m4 in

[bug#60807] [PATCH 1/2] mtime: use Time::HiRes::stat when available for subsecond resolution

2023-01-15 Thread Mike Frysinger
On 14 Jan 2023 21:27, Jacob Bachmeyer wrote: > Mike Frysinger wrote: > > --- a/lib/Automake/FileUtils.pm > > +++ b/lib/Automake/FileUtils.pm > > @@ -42,6 +42,11 @@ use Exporter; > > use File::stat; > > use IO::File; > > > > +# Perl's builtin

[bug#60807] [PATCH v2] tests: reuse am_cv_filesystem_timestamp_resolution

2023-01-15 Thread Mike Frysinger
On 14 Jan 2023 21:43, Jacob Bachmeyer wrote: > Mike Frysinger wrote: > > --- a/t/aclocal-no-force.sh > > +++ b/t/aclocal-no-force.sh > > @@ -19,6 +19,18 @@ > > > > . test-init.sh > > > > +# Automake relies on high resolution timestamps in perl

[bug#60776] [PATCH] distdir/emacs: avoid `test -d` with MKDIR_P

2023-01-14 Thread Mike Frysinger
On 14 Jan 2023 17:05, Karl Berry wrote: > most of the code directly preceding & following this line use @. > i.e. the vast majority of the current distdir logic. > > Yeah. > > If you feel like changing those @'s to AM_v_at while we're here, sounds > good to me ... -k i'd like to give it

[bug#60807] [PATCH v2] tests: reuse am_cv_filesystem_timestamp_resolution

2023-01-14 Thread Mike Frysinger
Rather than assume such coarse delays, re-use existing logic for probing the current filesystem resolution. This speeds up the testsuite significantly. On my system, it speeds -j1 up quite a lot -- by ~30%. While I didn't gather many samples to produce a statistically significant distribution, m

[bug#60807] [PATCH 1/2] mtime: use Time::HiRes::stat when available for subsecond resolution

2023-01-14 Thread Mike Frysinger
On 14 Jan 2023 14:52, Karl Berry wrote: > +my $have_time_hires = eval { require Time::HiRes; }; > > I don't object. Although if there's no speed up in practice, I wonder if > it's worth the extra code (simple-enough though it is). -k there's no speed up in the execution of a single process, b

[bug#60776] [PATCH] distdir/emacs: avoid `test -d` with MKDIR_P

2023-01-14 Thread Mike Frysinger
On 14 Jan 2023 15:17, Karl Berry wrote: > imo we overly rely on explicit @ in many places which can make debugging > failures painful. > > FWIW, I agree. Although I see no @ here. most of the code directly preceding & following this line use @. i.e. the vast majority of the current distdi

[bug#60807] [PATCH 1/2] mtime: use Time::HiRes::stat when available for subsecond resolution

2023-01-14 Thread Mike Frysinger
Perl's builtin stat function returns timestamps that have 1 second resolution. This can lead automake needlessly regenerating files because it compares timestamps as "older than or equal to" rather than only "older than". This is perfectly reasonable as we have no way of knowing what file is olde

[bug#60808] [PATCH 2/2] tests: reuse am_cv_filesystem_timestamp_resolution

2023-01-14 Thread Mike Frysinger
Rather than assume such coarse delays, re-use existing logic for probing the current filesystem resolution. This speeds up the testsuite significantly. On my system, it speeds -j1 up quite a lot -- by ~30%. While I didn't gather many samples to produce a statistically significant distribution, m

[bug#60772] [PATCH] tests: rework gettext to only check 'external' behavior

2023-01-13 Thread Mike Frysinger
On 13 Jan 2023 16:52, Karl Berry wrote: > Subject: [bug#60772] [PATCH] tests: rework gettext to only check > 'external' > behavior > > Good catch, thanks. Please commit. > > +# po/ is required. intl/ should not be used. > > Perhaps add the bit of information from your mail to help

[bug#60776] [PATCH] distdir/emacs: avoid `test -d` with MKDIR_P

2023-01-13 Thread Mike Frysinger
On 13 Jan 2023 15:36, Karl Berry wrote: > - test -d "$(distdir)" || mkdir "$(distdir)" > + $(AM_V_at)$(MKDIR_P) "$(distdir)" > > Ok by me, but why the AM_V_at for this particular command? > I don't see it used anywhere else in distdir.am. this is certainly true, and it's something i want

[bug#59994] [PATCH] tests: Don't try to prevent flex to include unistd.h

2023-01-13 Thread Mike Frysinger
On 13 Jan 2023 13:49, Frederic Berat wrote: > I probably won't be able to do so before next week at least. > If you happen to have time (and be willing) to do it earlier, don't > hesitate ;) that timeframe is fine. as you can see, we take a long view in Automake. -mike signature.asc Description

[bug#60776] [PATCH] distdir/emacs: avoid `test -d` with MKDIR_P

2023-01-13 Thread Mike Frysinger
We don't need to do the `test -d ... || mkdir ...` dance when we have the MKDIR_P helper, so simplify this code a bit. * lib/am/distdir.am: Use $(MKDIR_P). * lib/am/lisp.am: Drop redundant `test -d`. --- lib/am/distdir.am | 2 +- lib/am/lisp.am| 2 +- 2 files changed, 2 insertions(+), 2 delet

[bug#59993] [PATCH v2 3/3] tests: Fix implicit function declaration in ax/depcomp.sh

2023-01-13 Thread Mike Frysinger
On 13 Jan 2023 09:14, Frederic Berat wrote: > I made one more build with a different patchset list, could it be that the > failure you encounter is with "t/subobj.sh" ? to be clear, i applied this patch only to current git master. i didn't try including anything else. with that in mind, the fail

[bug#59993] [PATCH v2 3/3] tests: Fix implicit function declaration in ax/depcomp.sh

2023-01-12 Thread Mike Frysinger
this breaks `make check`, so i can't merge it -mike

[bug#59992] [PATCH 1/2] tests: Fix 'type defaults' error in link_cond due to main not being properly declared

2023-01-12 Thread Mike Frysinger
thanks, merged now -mike

[bug#59992] [PATCH 1/2] tests: Fix 'type defaults' error in link_cond due to main not being properly declared

2023-01-12 Thread Mike Frysinger
severity 59992 wishlist close 59992 thankyou

[bug#59994] [PATCH] tests: Don't try to prevent flex to include unistd.h

2023-01-12 Thread Mike Frysinger
On Mon, 12 Dec 2022 15:20:46 -0500, Zack Weinberg wrote: > On 2022-12-12 2:07 AM, Frederic Berat wrote: > > > > This patch is mainly a proposal. While the macro can simply be removed > > as explained below, another possibility it to add a flex option > > "--never-interactive" to prevent flex to ma

[bug#60772] [PATCH] tests: rework gettext to only check 'external' behavior

2023-01-12 Thread Mike Frysinger
The gettext project deprecated non-external use back in 2010 with the 0.18 release, and made it fatal with the 0.20 release in 2019. With that version, calling AM_GNU_GETTEXT() fails, which means all Automake tests are now skipped. The t/gettext-macros.sh helper probes gettext as such: >+ autopo

[bug#60771] [PATCH] tests: disable git log pager usage

2023-01-12 Thread Mike Frysinger
When running this code locally, the git log call can trigger a pager depending on the local settings, which in turn forces the test to be interactive. Run git with --no-pager to force disable it. * t/get-sysconf.sh: Run git with --no-pager. --- t/get-sysconf.sh | 2 +- 1 file changed, 1 insertio

[bug#60764] [PATCH] tests: change `sort|uniq` to `sort -u`

2023-01-12 Thread Mike Frysinger
These are equivalent, but more performant. We already use `sort -u` elsewhere in the codebase, so nothing new here really. * t/add-missing.tap: Change `sort|uniq` to `sort -u`. * t/CheckListOfTests.am: Likewise. --- t/CheckListOfTests.am | 2 +- t/add-missing.tap | 2 +- 2 files changed, 2 i

[bug#60763] [PATCH] tests: change `sort|uniq` to `sort -u`

2023-01-12 Thread Mike Frysinger
These are equivalent, but more performant. We already use `sort -u` elsewhere in the codebase, so nothing new here really. * t/add-missing.tap: Change `sort|uniq` to `sort -u`. * t/CheckListOfTests.am: Likewise. --- t/CheckListOfTests.am | 2 +- t/add-missing.tap | 2 +- 2 files changed, 2 i

[bug#60535] [PATCH] depend2: switch echo|sed to automatic vars

2023-01-11 Thread Mike Frysinger
On 05 Jan 2023 16:47, Karl Berry wrote: > Please excuse my curmudgeonness, but it's not clear to me that avoiding > sed is worth these hassles in working around the implementation-specific > bugs in the automatic variables. Especially if we have to invoke a shell > and various commands anyway, how

[bug#60747] [PATCH] dirstamp: switch to a pattern rule

2023-01-11 Thread Mike Frysinger
We can leverage $(@D) to generate a single pattern rule for all dirstamp rules. This saves many lines in the output -- normally we create 2 rules (or 6 lines) per subdir, and projects that use subdirs tend to use them quite a bit. In the most extreme & unlikely case (1 subdir, no depdir support),

[bug#60746] [PATCH] dirstamp: use append too instead of truncate

2023-01-11 Thread Mike Frysinger
We changed the depfiles logic to use >> (append) instead of > (truncate) due to it being slightly faster & nicer to the disk. Do the same with the dirstamp files as we only need the files to exist -- we don't care about their content, and we never put anything in them ourselves. If someone else w

[bug#60535] [PATCH] depend2: switch echo|sed to automatic vars

2023-01-04 Thread Mike Frysinger
On 04 Jan 2023 21:10, Nick Bowler wrote: > Except for one minor detail, $(@F) and $(@D) are highly portable. I > expect they were in the very first POSIX.2 specs as they predate the > earliest standards; I believe they first appeared in UNIX System V (ca. > 1983) and were later added to BSD in 4.3

[bug#60541] [PATCH] check: drop unused trs_list variable

2023-01-04 Thread Mike Frysinger
On 04 Jan 2023 16:54, Karl Berry wrote: > When the code that used this variable was removed, the variable > itself was left behind. Clean that up now too. > * lib/am/check.am: Delete trs_list. > > I can't find when the code using trs_list was removed (no mention in any > ChangeLog), b

[bug#60542] [PATCH/committed] maint: Update files from upstream with 'make fetch'

2023-01-03 Thread Mike Frysinger
Pulls some 2023 copyright updates. * lib/config.guess: Update. * lib/config.sub: Likewise. * lib/gendocs.sh: Likewise. * lib/gendocs_template: Likewise. * lib/gitlog-to-changelog: Likewise. * lib/gnupload: Likewise. * lib/texinfo.tex: Likewise. * lib/update-copyright: Likewise. --- lib/config.gue

[bug#60541] [PATCH] check: drop unused trs_list variable

2023-01-03 Thread Mike Frysinger
When the code that used this variable was removed, the variable itself was left behind. Clean that up now too. * lib/am/check.am: Delete trs_list. --- lib/am/check.am | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/am/check.am b/lib/am/check.am index 6648c011d721..89067

[bug#60538] [PATCH] rm: convert more cases to am__rm_f

2023-01-03 Thread Mike Frysinger
Fixes automake bug https://bugs.gnu.org/10828. Clean up a few more cases where we were doing `test ... || rm ...` to avoid calling `rm -f` without arguments by leveraging am__rm_f. These were harder to find in the source due to their constructed nature. The clean programs rules in particular wer

[bug#60536] [PATCH] depend: trim spurious leading tab

2023-01-03 Thread Mike Frysinger
These vars are replaced with a list of remove commands that are joined with a \n and each line always has a leading \t inserted. That means the literal tab here before the var leads to 2 tabs included in the output. While not functionally a problem, it can be a bit confusing when reading the outp

[bug#60535] [PATCH] depend2: switch echo|sed to automatic vars

2023-01-03 Thread Mike Frysinger
The echo|sed is used to split the dirname & filename so it can insert $(DEPDIR) in the middle, and then chop the trailing object suffix. In the generic case, %OBJ% is $@, so we can leverage the POSIX vars $(@D) and $(@F) to do the pathname splitting and insert $(DEPDIR) in between. For chopping th

[bug#54120] [PATCH] manual: mention LT_INIT

2022-02-22 Thread Mike Frysinger
The AC_PROG_LIBTOOL macro name is the old/deprecated one, so include LT_INIT here too to avoid confusing people who have switched. * doc/automake.texi: Add LT_INIT after AC_PROG_LIBTOOL. --- doc/automake.texi | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/automake.texi b/doc/automake.tex

[bug#54073] [PATCH] tests: log autoconf & libtool version

2022-02-20 Thread Mike Frysinger
On 20 Feb 2022 15:25, Karl Berry wrote: > +$AUTOCONF --version > +$AUTOCONF --help > +libtoolize --version > +libtoolize --help > > Sure, all to the good. > > Do we already log the automake version? i don't think so. why would we care about the version installed in the host syst

[bug#54073] [PATCH] tests: log autoconf & libtool version

2022-02-20 Thread Mike Frysinger
Having these in the sysconf log can be helpful when triaging test failures from users. * t/get-sysconf.sh: Log autoconf & libtoolize version. --- t/get-sysconf.sh | 5 + 1 file changed, 5 insertions(+) diff --git a/t/get-sysconf.sh b/t/get-sysconf.sh index 77394ca82e0d..51ec7f5d1f23 100644 -

[bug#54022] [PATCH] python: fix exit status handling with uninstall

2022-02-15 Thread Mike Frysinger
The st variable is set at the top of this shell script, and then here is a pipeline where it tries to update it in the subshell. But since setting variables in a subshell doesn't propagate back up, it doesn't actually work. Have the final subshell in the pipeline manage its own exit status and ex

[bug#53951] [PATCH] m4: speed up filesystem modification checks

2022-02-12 Thread Mike Frysinger
The current code sleeps at least 1 second to make sure the generated files are strictly newer than the source files. It does this for a few reasons: POSIX only guarantees that `sleep` accept integers, and filesystems have a history (c.f. Windows) of bad timestamp resolution. For the first part, w

[bug#53950] [PATCH] m4: cache build env sanity checks

2022-02-12 Thread Mike Frysinger
When rerunning configure in an existing build dir, cache the previous results about environment settings. There should be no need to retest these in a dir that has already been configured. * m4/sanity.m4: Cache sanity results. --- m4/sanity.m4 | 11 ++- 1 file changed, 6 insertions(+), 5

bug#53649: [PATCH] maint: include versioned manual in update

2022-01-31 Thread Mike Frysinger
On 31 Jan 2022 15:38, Karl Berry wrote: > Subject: [bug#53649] [PATCH] maint: include versioned manual in update > > Seems fine. I think you can go ahead and immediately commit these > patches without a review first. Will see it in the commit email ... i figure we'll find out if it really wor

[bug#53650] [PATCH] AM_PROG_AR: require before AC_PROG_AR

2022-01-30 Thread Mike Frysinger
The new autoconf AC_PROG_AR macro has similar logic to what we have in AM_PROG_AR, but less than what we need (since autoconf doesn't support the MS archiver), so make sure we are run before AC_PROG_AR. * m4/ar-lib.m4: Call AC_BEFORE for AC_PROG_AR. --- m4/ar-lib.m4 | 1 + 1 file changed, 1 inser

[bug#53649] [PATCH] maint: include versioned manual in update

2022-01-30 Thread Mike Frysinger
When publishing the updated manual, include the versioned copy too, and have their index.html link to the full version index. * maintainer/maint.mk: Copy manual to manual/$(VERSION)/, and insert index-full.html link into index.html. --- maintainer/maint.mk | 13 - 1 file changed, 12 i

[bug#53641] [PATCH/committed] maint: Update files from upstream with 'make fetch'

2022-01-30 Thread Mike Frysinger
* lib/config.guess: Update. * lib/config.sub: Likewise. * lib/gendocs.sh: Likewise. * lib/gendocs_template: Likewise. * lib/gitlog-to-changelog: Likewise. * lib/gnupload: Likewise. * lib/texinfo.tex: Likewise. * lib/update-copyright: Likewise. --- lib/config.guess| 16 +++- lib

[PATCH] maint: only sync the manual subdir

2022-01-28 Thread Mike Frysinger
This code only updates files under manual/, so no need to checkout the entire site first. * maintainer/maint.mk: Only checkout $(PACKAGE)/manual tree. --- maintainer/maint.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/maintainer/maint.mk b/maintainer/maint.mk index 55fa0a

[PATCH] tests: remove spurious +x bits

2022-01-27 Thread Mike Frysinger
None of these files are (or can be) executed directly, so drop the spurious +x permission bit. None of the other tests do this either. * t/built-sources-install-exec.sh: Remove +x bit. * t/ccnoco-deps.sh: Likewise. * t/ccnoco-lib.sh: Likewise. * t/ccnoco-lt.sh: Likewise. * t/perf/cond.sh: Likewis

[PATCH v2] python: prioritize python 3.x over 2.x

2022-01-27 Thread Mike Frysinger
Since Python 2.x went EOL years ago, stop searching for it before any of the Python 3 versions. * m4/python.m4: Move python2 after all python3 versions. * NEWS: Mention update in version search. --- NEWS | 6 ++ m4/python.m4 | 3 ++- 2 files changed, 8 insertions(+), 1 deletion(-) di

Re: [PATCH] python: prioritize python 3.x over 2.x

2022-01-26 Thread Mike Frysinger
On 26 Jan 2022 10:11, Zack Weinberg wrote: > On Wed, Jan 26, 2022, at 10:07 AM, Zack Weinberg wrote: > > On Wed, Jan 26, 2022, at 6:37 AM, Mike Frysinger wrote: > >> Since Python 2.x went EOL years ago, stop searching for it before > >> any of the Python 3 versions. >

Re: [PATCH] python: prioritize python 3.x over 2.x

2022-01-26 Thread Mike Frysinger
On 26 Jan 2022 10:07, Zack Weinberg wrote: > On Wed, Jan 26, 2022, at 6:37 AM, Mike Frysinger wrote: > > Since Python 2.x went EOL years ago, stop searching for it before > > any of the Python 3 versions. > > +1 > > >m4_define_default([_AM_PYTHON_INTERPRET

[PATCH] python: prioritize python 3.x over 2.x

2022-01-26 Thread Mike Frysinger
Since Python 2.x went EOL years ago, stop searching for it before any of the Python 3 versions. * m4/python.m4: Move python2 after all python3 versions. --- m4/python.m4 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/m4/python.m4 b/m4/python.m4 index 6653e4d89eb2..15f5484c6

[PATCH v2] aclocal: add --aclocal-path option to override $ACLOCAL_PATH

2022-01-24 Thread Mike Frysinger
The $ACLOCAL_PATH env var is useful, but setting environment vars is a bit clunky. Add an --aclocal-path option to override it like we already have with --automake-acdir. * bin/aclocal.in: Add --aclocal-path to override ACLOCAL_PATH. * doc/automake.texi: Document --aclocal-path. * t/aclocal-path-

Re: PATCH: silence Shellcheck warning

2022-01-23 Thread Mike Frysinger
On 18 Jan 2022 21:25, Ben Elliston wrote: > On Tue, Jan 18, 2022 at 04:18:52AM -0500, Mike Frysinger wrote: > > that said, automake targets lower than POSIX, so i agree that we > > should leave it be for automake specifically. feel like posting a > > patch to suppress this pa

patch tracking

2022-01-23 Thread Mike Frysinger
On 22 Jan 2022 18:58, Karl Berry wrote: > By the way, it occurs to me that it might be more maintainable to send > proposed patches to bug-automake, even if there is no original bug they > are fixing. More easily trackable that way, i.e., less likely to > overlook something. No biggie either way th

Re: [PATCH] Use gender-neutral pronouns in HACKING and t/README

2022-01-22 Thread Mike Frysinger
On 22 Jan 2022 18:58, Karl Berry wrote: >may be interesting for debugging, so that when a user send a verbose > - output we don't have to ask him for more details. Display stderr > + output we don't have to ask them for more details. Display stderr > > I'd like to say "when use

[PATCH] aclocal: add --aclocal-path option to override $ACLOCAL_PATH

2022-01-20 Thread Mike Frysinger
The $ACLOCAL_PATH env var is useful, but setting environment vars is a bit clunky. Add an --aclocal-path option to override it like we already have with --automake-acdir. * bin/aclocal.in: Add --aclocal-path to override ACLOCAL_PATH. * doc/automake.texi: Document --aclocal-path. --- bin/aclocal.

[PATCH] aclocal: add m4 search path info to --help

2022-01-19 Thread Mike Frysinger
Add a short summary to --help of the current paths that will be searched. Make sure to omit this from the man page when running help2man since pre-inst-env specifically clears some and others to the current build directory. * bin/aclocal.in: Include m4 search paths in usage. * doc/local.mk: Run h

[PATCH] progs, libs: support _RANLIB overrides

2022-01-19 Thread Mike Frysinger
Much like we have per-target support for _AR and _LINK, add an _RANLIB override too. This allows selection of specific ranlib tools in case a non-standard archiver tool was forced. * bin/automake.in: Check for _RANLIB per-target settings. * doc/automake.texi: Document _RANLIB override. * lib/am/l

[PATCH] tests: add _AR override coverage

2022-01-19 Thread Mike Frysinger
There were no tests for per-target _AR settings, so add some. * t/ar_override.sh: New test. --- t/ar_override.sh | 50 1 file changed, 50 insertions(+) create mode 100644 t/ar_override.sh diff --git a/t/ar_override.sh b/t/ar_override.sh new file

Re: [PATCH] build: fix race in parallel builds

2022-01-18 Thread Mike Frysinger
On 18 Jan 2022 04:53, Mike Frysinger wrote: > As reported by Hongxu Jia: > > The automake-$(APIVERSION) is a hardlink of automake, if it is > > created later than update_mans executing, there is a failure > > [snip] > > |: && mkdir -p doc && ./pre-inst-en

Re: PATCH: silence Shellcheck warning

2022-01-18 Thread Mike Frysinger
On 18 Jan 2022 21:25, Ben Elliston wrote: > On Tue, Jan 18, 2022 at 04:18:52AM -0500, Mike Frysinger wrote: > > that said, automake targets lower than POSIX, so i agree that we > > should leave it be for automake specifically. feel like posting a > > patch to suppress this pa

Re: [PATCH] tests: fix py-compile-basedir.sh: add missing test call

2022-01-18 Thread Mike Frysinger
On 18 Jan 2022 11:29, Jim Meyering wrote: > On Tue, Jan 18, 2022 at 10:29 AM Mike Frysinger wrote: > > On 18 Jan 2022 09:48, Jim Meyering wrote: > ... > > > But IMHO that's too much duplication/syntax. > > > How about this instead? > > > > > >

[PATCH] build: fix race in parallel builds

2022-01-18 Thread Mike Frysinger
As reported by Hongxu Jia: > The automake-$(APIVERSION) is a hardlink of automake, if it is > created later than update_mans executing, there is a failure > [snip] > |: && mkdir -p doc && ./pre-inst-env /usr/bin/env perl > ../automake-1.16.1/doc/help2man --output=doc/aclocal-1.16.1 aclocal-1.16 >

Re: [PATCH] tests: fix py-compile-basedir.sh: add missing test call

2022-01-18 Thread Mike Frysinger
On 18 Jan 2022 09:48, Jim Meyering wrote: > On Tue, Jan 18, 2022 at 7:46 AM Mike Frysinger wrote: > > From: Thomas Deutschmann > > > > Commit b279a0d46dfeca1ca40057c3c910ab1657d60be5 ("tests: in python > > tests, do not require .pyo files (for python3)") ha

Re: PATCH: silence Shellcheck warning

2022-01-18 Thread Mike Frysinger
On 22 Jul 2018 14:41, Nick Bowler wrote: > On 7/21/18, Ben Elliston wrote: > > This patch silences a warning from Shellcheck about using old-style > > `...` command substitutions. > [...] > > commit 4d35c7aae97234bf055519075ef03cd4090a1dfc > > Author: Ben Elliston > > Date: Sun Jul 22 08:22:44

Re: [PATCH] doc: Fix a typo

2022-01-18 Thread Mike Frysinger
On 08 Apr 2018 16:06, Matthew Leeds wrote: > --- a/doc/automake.texi > +++ b/doc/automake.texi > All of these actions are performed in a temporary directory. Please > note that the exact location and the exact structure of such a directory > (where the read-only sources are placed, how the temp

Re: [PATCH] lib: drop unused shell variables

2022-01-18 Thread Mike Frysinger
lgtm, and still applies cleanly -mike signature.asc Description: PGP signature

Re: [PATCH] Use gender-neutral pronouns in HACKING and t/README

2022-01-18 Thread Mike Frysinger
On 08 Apr 2018 16:07, Matthew Leeds wrote: > --- > HACKING | 4 ++-- > t/README | 2 +- thanks for the patch. looks like Jim fixed HACKING: http://git.savannah.gnu.org/cgit/automake.git/commit/?h=7665b8e209888c73ee4dc05256f4f09a703a01e5 but your change to t/README still applies cleanly. -mike

Re: minor docs alteration

2022-01-18 Thread Mike Frysinger
On 31 May 2018 22:44, Jefferson Carpenter wrote: > Subject: [PATCH] automake.texi: clarify relationship between configure and > build dir > > I know you what this meant, but as a kid this would have confused me - the > word "in" seems to imply that the "configure" file is inside of the build dir,

[PATCH] tests: fix py-compile-basedir.sh: add missing test call

2022-01-17 Thread Mike Frysinger
From: Thomas Deutschmann Commit b279a0d46dfeca1ca40057c3c910ab1657d60be5 ("tests: in python tests, do not require .pyo files (for python3)") had a slight logic error in that it missed a `test` call. Reported to Gentoo at https://bugs.gentoo.org/715040. * t/py-compile-basedir.sh: Add test comman

[PATCH] gitignore: drop redundant config.h.in~ rule

2022-01-17 Thread Mike Frysinger
Since we're ignoring all *~ files, we don't need this explicit one. * .gitignore: Delete config.h.in~ rule. --- .gitignore | 1 - 1 file changed, 1 deletion(-) diff --git a/.gitignore b/.gitignore index 6e7809bffe80..40540ad7ebf0 100644 --- a/.gitignore +++ b/.gitignore @@ -28,7 +28,6 @@ /doc/a

Re: [RFC/PATCH] m4: enable silent build rules by default

2021-12-11 Thread Mike Frysinger
On 07 Dec 2021 21:58, Zack Weinberg wrote: > On Tue, Dec 7, 2021, at 9:49 PM, Mike Frysinger wrote: > > This has been available since automake 1.11 released over a decade > > ago. Let's flip the default to enable silent builds by default. > > Please don't

[PATCH 2/2] m4: enable silent build rules by default

2021-12-11 Thread Mike Frysinger
This has been available since automake 1.11 released over a decade ago. Let's flip the default to enable silent builds by default. NB: The "1.20" version is a placeholder. With the warning for devs in 1.17, we can wait a while before rolling this out. --- NEWS | 9 + m4/silent.m

[PATCH 1/2] m4: warn when AM_SILENT_RULES default is used

2021-12-11 Thread Mike Frysinger
To help ease people into enabling silent rules by default, warn if a package doesn't make an explicit selection. --- NEWS | 10 ++ m4/silent.m4 | 6 +- 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index fb05ee219708..282eb9277a3d 100644 --- a/NEWS

[PATCH] m4: replace AC_DIAGNOSE with m4_warn

2021-12-11 Thread Mike Frysinger
AC_DIAGNOSE was marked obsolete with autoconf-2.62 in 2008. * m4/obsolete.m4: Change AC_DIAGNOSE to m4_warn. --- m4/obsolete.m4 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/m4/obsolete.m4 b/m4/obsolete.m4 index 79f3b234bfc5..bf3b68271673 100644 --- a/m4/obsolete.m4 +++

[PATCH] gitignore: update

2021-12-11 Thread Mike Frysinger
Ignore all *~ files as editors like to create them, as do some autotool steps. This also matches what autoconf is doing. * .gitignore: Update. --- .gitignore | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index 89e71ec97d5a..22f40fe9f51f 100644 ---

Re: [RFC/PATCH] m4: enable silent build rules by default

2021-12-11 Thread Mike Frysinger
On 08 Dec 2021 15:02, Karl Berry wrote: > Please don't *ever* make this change. > > I agree with Zack, and just for CI purposes; it is simply too big of an > incompatibility to inflict at this late date. there's nothing incompatible about it. the inputs to the system (how configure & make ar

[PATCH] configure: handle KCC on case-insensitive filesystems

2021-12-09 Thread Mike Frysinger
This fixes https://debbugs.gnu.org/21336. On macOS 10.10, there seems to be a kerberos tool installed as "kcc" which breaks the check. Also resync with latest autoconf which searches for clang++ too. * configure.ac: Skip KCC check on case-insensitive filesystems. Add clang++ to the C++ search l

[RFC/PATCH] m4: enable silent build rules by default

2021-12-07 Thread Mike Frysinger
This has been available since automake 1.11 released over a decade ago. Let's flip the default to enable silent builds by default. --- NEWS | 9 + m4/silent.m4 | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index fb05ee219708..866ace951fd5 10064

Re: [PATCH] dejagnu: add support for silent builds with site.exp

2021-11-27 Thread Mike Frysinger
On 27 Nov 2021 18:45, Karl Berry wrote: > Hi Mike, > > Subject: [PATCH] dejagnu: add support for silent builds with site.exp > > I pushed the change. > > https://sourceware.org/git/?p=binutils-gdb.git;a=summary > after you configure+make, you can iterate with just `make site.exp`. >

Re: [PATCH] dejagnu: add support for silent builds with site.exp

2021-11-17 Thread Mike Frysinger
On 17 Nov 2021 14:22, Karl Berry wrote: > Thanks for the patch, Mike. > > * lib/am/dejagnu.am (site.exp): Use $(AM_V_GEN) > > Ok. Can you tell me how to discern that this makes a difference? > Is there some test where it can be observed? > I've never actually used dejagnu with Automake. i

[PATCH] dejagnu: add support for silent builds with site.exp

2021-11-16 Thread Mike Frysinger
* lib/am/dejagnu.am (site.exp): Use $(AM_V_GEN) and merge all independent shell calls into one. --- lib/am/dejagnu.am | 51 --- 1 file changed, 26 insertions(+), 25 deletions(-) diff --git a/lib/am/dejagnu.am b/lib/am/dejagnu.am index 8b5c1af4905b..f652

[PATCH] config headers: add support for silent builds

2021-10-31 Thread Mike Frysinger
* lib/am/remake-hdr.am (%STAMP%): Use $(AM_V_at) and $(AM_V_GEN). (%CONFIG_HIN%): Likewise. --- lib/am/remake-hdr.am | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/am/remake-hdr.am b/lib/am/remake-hdr.am index 0d9f4cd8b9da..c0016cffc626 100644 --- a/lib/am/remak

[PATCH] doc: fix dejagnu variable references

2021-02-20 Thread Mike Frysinger
While there is a RUNTESTDEFAULTFLAGS, there is no AM_ variant. The docs probably meant RUNTESTFLAGS which has the variants and is meant to be overridden by people, so swap the name in the docs. * doc/automake.texi (Other Variables): Change RUNTESTDEFAULTFLAGS to RUNTESTFLAGS. --- doc/automake.te

[PATCH] use runtime (not configure time) detection of perl threads

2013-01-11 Thread Mike Frysinger
and do the version/config checking at runtime. Signed-off-by: Mike Frysinger * bootstrap.sh (PERL_THREADS): Delete assignment and use in sed. * configure.ac (am_cv_prog_PERL_ithreads, PERL_THREADS): Delete all code related to these two variables. * lib/Automake/Config.in (perl_threads): Initialize

Re: perl ithreads support: why hardcode at configure time ?

2013-01-11 Thread Mike Frysinger
On Friday 11 January 2013 12:21:24 Stefano Lattarini wrote: > On 01/11/2013 06:11 PM, Mike Frysinger wrote: > > On Friday 11 January 2013 04:08:26 Stefano Lattarini wrote: > >> On 01/11/2013 05:07 AM, Mike Frysinger wrote: > >>> i can't imagine this is a big run

Re: perl ithreads support: why hardcode at configure time ?

2013-01-11 Thread Mike Frysinger
On Friday 11 January 2013 04:08:26 Stefano Lattarini wrote: > On 01/11/2013 05:07 AM, Mike Frysinger wrote: > > i can't imagine this is a big runtime penalty, so why does configure > > check for the perl's thread settings and then hardcode that in the > > generated

Re: `automake -a -c -f` wrongly updates the INSTALL file

2008-01-08 Thread Mike Frysinger
On Tuesday 08 January 2008, Ralf Wildenhues wrote: > Hello Mike, > > * Mike Frysinger wrote on Wed, Jan 02, 2008 at 10:44:12PM CET: > > On Thursday 28 September 2006, Mike Frysinger wrote: > > > i normally use automake-1.9.6 but i just tried out 1.9b and it appears > &

Re: [patch] ccnoco.test: ignore all user settings, not just common ones

2008-01-02 Thread Mike Frysinger
On Wednesday 02 January 2008, Ralf Wildenhues wrote: > * Mike Frysinger wrote on Mon, Dec 31, 2007 at 07:25:51PM CET: > > if you have custom CPPFLAGS or LDFLAGS set, the ccnoco test can fail. in > > the spirit of the existing code which resets CFLAGS, this patch does the > >

Re: `automake -a -c -f` wrongly updates the INSTALL file

2008-01-02 Thread Mike Frysinger
On Thursday 28 September 2006, Mike Frysinger wrote: > i normally use automake-1.9.6 but i just tried out 1.9b and it appears to > have the same problem automake-1.10 exhibits the problem as well ... finally spent some time digging at it for fun > $ svn st INSTALL > $ automak

[patch] ccnoco.test: ignore all user settings, not just common ones

2007-12-31 Thread Mike Frysinger
if you have custom CPPFLAGS or LDFLAGS set, the ccnoco test can fail. in the spirit of the existing code which resets CFLAGS, this patch does the same for CPPFLAGS and LDFLAGS. Signed-Off-By: Mike Frysinger <[EMAIL PROTECTED]> --- diff --git a/tests/ccnoco.test b/tests/ccnoco.test