Re: bug#16302: 1.14.1: check-TESTS is not lazy enough

2013-12-31 Thread Akim Demaille
Le 31 déc. 2013 à 00:11, Stefano Lattarini a écrit : > Hi Akim. Hi! Thanks for the quick answer. >> At first sight it seems that it should be guarded by ‘test -n $$redo_log’. >> > Indeed. > >> This is *really* costly, I’d be happy to have nice workarounds. >> > Or eve better, to fix the b

Re: bug#14991: distcheck passes --prefix to configure before *DISTCHECK_CONFIGURE_FLAGS

2013-10-31 Thread Akim Demaille
Hi Stefano! Le 30 oct. 2013 à 23:02, Stefano Lattarini a écrit : > I've fixed the issue with the two attached patches, that will appear > in Automake 1.14.1 (someday when I'll actually get around to release > it ;-). I will wait some time before pushing the patches out, so a > review is welcom

Re: [PATCH 1/2] tests: strengthen the ylwrap tests

2012-12-26 Thread Akim Demaille
> Below is what I squashed in this patch before merging it to master: hi Stefano, Thanks for having addressed this. I missed these comments the first time, sorry about it.

Re: [PATCH 2/2] ylwrap: various fixes

2012-12-21 Thread Akim Demaille
Le 21 déc. 2012 à 18:43, Stefano Lattarini a écrit : > On 12/21/2012 06:31 PM, Akim Demaille wrote: >> >>> Since you have a very good >>> explanation of such a "why" (as seen in the NEWS file), would you >>> mind reporting it (at least in an ab

Re: [PATCH 2/2] ylwrap: various fixes

2012-12-21 Thread Akim Demaille
Le 21 déc. 2012 à 17:44, Stefano Lattarini a écrit : > Hi Akim. Hi! > On 12/19/2012 02:55 PM, Akim Demaille wrote: >> * lib/ylwrap (guard): Properly honor $1. >> > I fear this is the ChangLog style that I dislike: just reporting the > "what" of the change,

[PATCH 1/2] tests: strengthen the ylwrap tests

2012-12-21 Thread Akim Demaille
* t/yacc-d-basic.sh: Comment changes. (generated): New. Use it to factor various tests. Check that Y_TAB_H is not issued. --- t/yacc-d-basic.sh | 51 +-- 1 file changed, 25 insertions(+), 26 deletions(-) diff --git a/t/yacc-d-basic.sh b/t/yacc-d-bas

[PATCH 2/2] ylwrap: various fixes

2012-12-21 Thread Akim Demaille
* lib/ylwrap (guard): Properly honor $1. Keep a single _ instead of several. (RENAME_sed): new. Use it. --- NEWS | 18 ++ lib/ylwrap | 27 ++- 2 files changed, 36 insertions(+), 9 deletions(-) diff --git a/NEWS b/NEWS index 7a230ef..482216c 100644 ---

[PATCH 0/2] {maint} ylwrap: fix header guards

2012-12-21 Thread Akim Demaille
The first patch enhances a test to exhibit a failure that the second addresses. Akim Demaille (2): tests: strengthen the ylwrap tests ylwrap: various fixes NEWS | 18 ++ lib/ylwrap| 27 ++- t/yacc-d-basic.sh | 51

Re: [PATCH 3/3] ylwrap: rename header inclusion in generated parsers

2012-07-15 Thread Akim Demaille
Hi Stefano, Le 14 juil. 2012 à 10:07, Stefano Lattarini a écrit : > Oh, and: since you've fixed actual bugs, I think a NEWS entry is > warranted. You can add that with a follow-up patch on the top of > yacc-work (before that is merged to maint). I've pushed this in yacc-work-2. * Long-standing

Re: [PATCH 0/4] ylwrap: support C++ and others that generate several files

2012-07-14 Thread Akim Demaille
Le 14 juil. 2012 à 11:09, Stefano Lattarini a écrit : > On 07/14/2012 10:52 AM, Stefano Lattarini wrote: >> On 07/14/2012 10:32 AM, Akim Demaille wrote: >>> Well, while at it, I looked at the other failure, for C++, and >>> fixed them. >>> >>>

Re: [PATCH 1/4] tests: upgrade and fix Bison test case

2012-07-14 Thread Akim Demaille
Le 14 juil. 2012 à 11:16, Stefano Lattarini a écrit : > I often add a "using namespace std;" or "#include " line > to C++ sources to ensure they are not valid C, so that any attempt > on part of Automake-generated Makefiles to compile them using the > C compiler would cause a clear error. Mostly

Re: yacc-work: rebased on maint, one more fixlet (was: Re: [PATCH 0/4] ylwrap: support C++ and others that generate several files)

2012-07-14 Thread Akim Demaille
Le 14 juil. 2012 à 12:33, Stefano Lattarini a écrit : > I've also rebased 'yacc-work' on maint (rather than on master), and > pushed the follow-up below to avoid a spurious failure. > > I will do some testing on BSD and Solaris, and if there are no further > issues, the merge the series in maint

Re: [PATCH 1/4] tests: upgrade and fix Bison test case

2012-07-14 Thread Akim Demaille
Le 14 juil. 2012 à 10:49, Stefano Lattarini a écrit : > Hi Akim. > > ACK, with one question ... > >> cat > foo.cc << 'END' >> #include "zardoz.hh" >> >> -using namespace std; >> - > Why this change? Well, the question is rather: why this line? It's useless, like a useless #include.

[PATCH 4/4] ylwrap: fix C++ support

2012-07-14 Thread Akim Demaille
The current logic of ylwrap is to call yacc in a sub directory, and pull out of it all the files that were request on its command line. Reverse this approach: export *all* the files created in the subdirectory, but rename then according to what the command says. This way, extra files, such as posit

[PATCH 3/4] ylwrap: refactor: move loop invariant

2012-07-14 Thread Akim Demaille
* lib/ylwrap (input_rx): Move its definition next to its sibling's, outside of the main loop. --- lib/ylwrap | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lib/ylwrap b/lib/ylwrap index 4ad820d..3efa632 100755 --- a/lib/ylwrap +++ b/lib/ylwrap @@ -108,6 +108,7 @@ case "$inp

[PATCH 2/4] ylwrap: refactoring: don't rely on the file order

2012-07-14 Thread Akim Demaille
Forthcoming changes will make us iterate over the files in a different order. lib/ylwrap (first): Remove, replaced by... (parser): this. --- lib/ylwrap | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/ylwrap b/lib/ylwrap index 725b388..4ad820d 100755 ---

[PATCH 1/4] tests: upgrade and fix Bison test case

2012-07-14 Thread Akim Demaille
* t/yacc-bison-skeleton-cxx.sh: Request locations, to be even more stressful. Use %union to make sure the %{...%} is inserted where appropriate. Fix some indentation/coding style issues. --- t/yacc-bison-skeleton-cxx.sh | 20 1 file changed, 12 insertions(+), 8 deletions(-) d

[PATCH 0/4] ylwrap: support C++ and others that generate several files

2012-07-14 Thread Akim Demaille
Well, while at it, I looked at the other failure, for C++, and fixed them. It is installed in yacc-work. Akim Demaille (4): tests: upgrade and fix Bison test case ylwrap: refactoring: don't rely on the file order ylwrap: refactor: move loop invariant ylwrap: fix C++ support lib/y

Re: [PATCH 3/3] ylwrap: rename header inclusion in generated parsers

2012-07-14 Thread Akim Demaille
Le 14 juil. 2012 à 09:13, Akim Demaille a écrit : > The failure is due to the input: > > %{ > int yylex () { return 0; } > void yyerror (const char *s) { return; } > %} > %% > foobar : 'f' 'o' 'o' 'b' 'a' 'r&#

Re: [PATCH 3/3] ylwrap: rename header inclusion in generated parsers

2012-07-14 Thread Akim Demaille
Le 13 juil. 2012 à 19:31, Stefano Lattarini a écrit : > On 07/13/2012 04:20 PM, Akim Demaille wrote: >> >> Sorry about these. Updated below, and in the branch too. >> > Thanks. I'm still seeing the test case 'yacc-bison-skeleton.sh' failing > on th

Re: [PATCH 3/3] ylwrap: rename header inclusion in generated parsers

2012-07-13 Thread Akim Demaille
3f0a94c38c529' to fix the test > 'yacc-bison-skeleton.sh', it should be amended so that XFAIL_TESTS does > not contain the fixed test anymore; in addition to avoiding an XPASS, > that makes clear that the commit is fixing a pre-existing bug as well. Sorry about these. Updated b

Re: [PATCH 3/3] ylwrap: rename header inclusion in generated parsers

2012-07-13 Thread Akim Demaille
Le 13 juil. 2012 à 13:43, Stefano Lattarini a écrit : > See? Another thing I had got wrong, given my ignorance and the lack > of a proper explanation ;-) I also meant that the bug is obvious :) If you rename files, you have to rename files that use them, and that this is in the context of Biso

Re: [PATCH 0/3] ylwrap: handle header inclusion properly

2012-07-13 Thread Akim Demaille
Le 12 juil. 2012 à 17:38, Stefano Lattarini a écrit : > Hi Akim. > > On 07/12/2012 03:51 PM, Akim Demaille wrote: >> The following patches address a bug in ylwrap that cause it >> to be unable to handle Bison glr parsers, but also prevents >> future Bison rele

Re: [PATCH 3/3] ylwrap: rename header inclusion in generated parsers

2012-07-13 Thread Akim Demaille
Le 12 juil. 2012 à 18:22, Stefano Lattarini a écrit : > On 07/12/2012 03:51 PM, Akim Demaille wrote: >> * lib/am/yacc.am (am__yacc_c2h): Shorten. >> > See below. > >> @@ -37,8 +37,7 @@ if %?MAINTAINER-MODE% >> @MAINTAINER_MODE_FALSE@am__skipyacc = test -f

Re: [PATCH 2/3] ylwrap: simplify the list of renamings

2012-07-13 Thread Akim Demaille
Le 12 juil. 2012 à 17:51, Stefano Lattarini a écrit : > On 07/12/2012 03:51 PM, Akim Demaille wrote: >> * lib/ylwrap (pairwise): Instead of being a straightforward copy from >> the command line arguments, and having to deal with y.tab vs. y_tab >> later, let pairwise store t

[PATCH 1/3] ylwrap: refactor

2012-07-12 Thread Akim Demaille
* lib/ylwrap (guard): New function. Move functions before actual code. --- lib/ylwrap | 48 1 file changed, 28 insertions(+), 20 deletions(-) diff --git a/lib/ylwrap b/lib/ylwrap index 6879d8d..fd29af8 100755 --- a/lib/ylwrap +++ b/lib/ylwrap @@ -1

[PATCH 3/3] ylwrap: rename header inclusion in generated parsers

2012-07-12 Thread Akim Demaille
* lib/am/yacc.am (am__yacc_c2h): Shorten. * lib/ylwrap (rename_sed): New. (main loop): Use it the rename the dependencies to other files. * t/yacc-d-basic.sh: Exercize this case, even if bison/yacc was not issueing such an include. --- lib/am/yacc.am| 3 +-- lib/ylwrap| 15 ---

[PATCH 0/3] ylwrap: handle header inclusion properly

2012-07-12 Thread Akim Demaille
contrib/Makefile.in # doc/Makefile.in # lib/Automake/Makefile.in # lib/Makefile.in # lib/am/Makefile.in # m4/Makefile.in Akim Demaille (3): ylwrap: refactor ylwrap: simplify the list of renamings ylwrap: rename header inclusion in generated parsers lib

[PATCH 2/3] ylwrap: simplify the list of renamings

2012-07-12 Thread Akim Demaille
* lib/ylwrap (pairwise): Instead of being a straightforward copy from the command line arguments, and having to deal with y.tab vs. y_tab later, let pairwise store the real file names to process, y_tab conversion included when needed. (main loop): Use $to instead of $2, for symmetry with $from. ---

Re: [PATCH] yacc, lex: new 'no-ylwrap' option to prevent use of the 'ylwrap' script

2012-06-26 Thread Akim Demaille
(wow, _that_ is quite a list of CCs. Hi mum!) Hi Eric, Le 26 juin 2012 à 18:18, Eric Blake a écrit : > Eek - that just shows that I'm really behind on reading my email. Thou shalt be punished. Beware of my wrath. > Just from reading this summary, the idea of improving AC_PROG_LEX and > AC_PR

Re: [PATCH] yacc, lex: new 'no-ylwrap' option to prevent use of the 'ylwrap' script

2012-06-26 Thread Akim Demaille
Le 26 juin 2012 à 17:35, Stefano Lattarini a écrit : > This is probably a better idea, yes. This could probably be done by > enhancing AM_PROG_LEX and defining a similar new AM_PROG_YACC macro. > Or better again, it could be done directly in AC_PROG_LEX and > AC_PROG_YACC, so that we could just

Re: [PATCH] yacc, lex: new 'no-ylwrap' option to prevent use of the 'ylwrap' script

2012-06-26 Thread Akim Demaille
Hi Stefano, Thanks for this! Le 25 juin 2012 à 16:01, Stefano Lattarini a écrit : > When used with good yacc and lex implementations, like Flex and GNU Bison, > the 'ylwarp' ylwrap > script (meant to work around the deficiencies of older or > inferior yacc and lex implementations) creates far

Re: ylwrap does not rename y.tab.h in y.tab.c

2012-06-26 Thread Akim Demaille
Hi all, Le 25 juin 2012 à 11:30, Stefano Lattarini a écrit : >> Well, I guess I must step back. I installed what follows >> in maint. >> > Sigh, advancement on Bison kept back by the fact that Automake used to > bend over backwards to support inferior yacc implementation that today > hardly any

Re: [Automake-NG] [PATCH] texi: require Texinfo >= 4.9, related enhancements

2012-06-18 Thread Akim Demaille
Le 17 juin 2012 à 13:53, Stefano Lattarini a écrit : > The use of '--build-dir' also allows us to specify different build > directories for the PDF and DVI output, preventing the rules building > them from stomping on each other's feet when run in parallel. This is > demonstrated by the test cas

Re: Better bison support in Automake (was: Re: FYI: master: calc++: rely on Automake)

2012-02-16 Thread Akim Demaille
Le 16 févr. 2012 à 11:21, Stefano Lattarini a écrit : > Hi Akim. Hi! > Thanks, fixed (see attached patch). > >> But maybe automake no longer needs this? >> > It still need it; without that, no header file will be generated from > the '.y' files (this is a feature, not a bug). > >> If it does

Re: recheck, recheck-html, check-html

2009-04-09 Thread Akim Demaille
Le 6 avr. 09 à 07:52, Ralf Wildenhues a écrit : Hi Akim, Hi Ralf, I'm sorry for being so unresponsive, I hope I'm not causing some delays in the release of Automake! Bugs in my code: - above three targets fail to update $(check_SCRIPTS) $ (check_PROGRAMS). But these guys are less im

Re: parallel-tests: redo lazy checking: recheck and RECHECK_LOGS.

2009-04-01 Thread Akim Demaille
Le 31 mars 09 à 01:01, Ralf Wildenhues a écrit : Salut Ralf ! * Akim Demaille wrote on Mon, Mar 30, 2009 at 09:50:59PM CEST: Le 29 mars 09 à 00:04, Ralf Wildenhues a écrit : I often use STRICT_TEST_LOGS = $(shell $(LIST_FAILED_TEST_LOGS)) which makes all failing test strict. In

Re: proposed patch: parallel-tests: per-extension test driver: ext_COMPILE.

2009-03-30 Thread Akim Demaille
Le 30 mars 09 à 21:37, Ralf Wildenhues a écrit : But what is a non-extension rule? You mean if the rule is foo: ... ? I mean with TESTS = foo bar.test baz.chk TEST_EXTENSIONS = .chk then foo.log and bar.test.log (sic!) will be generated using explicit rules, while baz.log will b

Re: parallel-tests: redo lazy checking: recheck and RECHECK_LOGS.

2009-03-30 Thread Akim Demaille
Le 29 mars 09 à 00:04, Ralf Wildenhues a écrit : Hi Akim, Hi Ralf! Agreed. While I won't change the TESTS=foo.test semantics, we can publish that the user can use TEST_LOGS=foo.log to limit the tests to be run. Never thought about that :) Thanks. - LAZY_TEST_SUITE is not flexible

Re: parallel-tests: warn about $(srcdir), $(top_srcdir) in TESTS.

2009-03-30 Thread Akim Demaille
Le 28 mars 09 à 22:17, Ralf Wildenhues a écrit : diff --git a/doc/automake.texi b/doc/automake.texi index d3b72a5..bf41acb 100644 --- a/doc/automake.texi +++ b/doc/automake.texi @@ -8504,6 +8508,17 @@ the inference rules generated by @command{automake} can apply. For literal test names, @co

Re: proposed patch: parallel-tests: per-extension test driver: ext_COMPILE.

2009-03-30 Thread Akim Demaille
Le 24 mars 09 à 22:57, Ralf Wildenhues a écrit : Hi Akim, Hi Ralf! * Akim Demaille wrote on Sat, Mar 14, 2009 at 01:52:33PM CET: Le 14 mars 09 à 12:08, Ralf Wildenhues a écrit : Corollary: the test driver may not be called CXXCOMPILE. General: For extension `.ext', we canno

Re: [PATCH 11] Fix LAZY_TEST_SUITE handling and $(TEST_SUITE_LOG) recreation.

2009-03-30 Thread Akim Demaille
Le 20 mars 09 à 00:24, Ralf Wildenhues a écrit : Retaining the "TESTS=foo*.test" thing without GNU make-specific measures is tricky. It requires to shell-expand $(TESTS), before we even start using either of $(TESTS) or $(TEST_LOGS). IIUC that means we have to introduce yet another restart

Re: Do not create conditional installation directories

2009-03-30 Thread Akim Demaille
Le 23 mars 09 à 23:31, Ralf Wildenhues a écrit : I assume these two patches implement what you, Akim, desire, while they do not touch the functionality that you, Ralf, would like not to be destroyed. Do you both agree? This is perfect for me, thanks a lot Ralf!

Re: proposed patch: parallel-tests: also record logs of SKIPped tests.

2009-03-20 Thread Akim Demaille
Le 19 mars 09 à 23:17, Ralf Wildenhues a écrit : Hi Jim, * Jim Meyering wrote on Sat, Mar 14, 2009 at 12:07:15PM CET: Ralf Wildenhues wrote: This is a patch that I don't know whether I want it or not. Package authors may be interested in SKIPs and why they happen, or not. (Could also be s

Re: Do not create conditional installation directories

2009-03-20 Thread Akim Demaille
Le 19 mars 09 à 15:01, Ralf Corsepius a écrit : Ralf Wildenhues wrote: * Akim Demaille wrote on Wed, Mar 18, 2009 at 06:31:50PM CET: "RW" == Ralf Wildenhues writes: > But the question remains: how do you think we should address the bug > that bothers Akim, other than by

Re: Do not create conditional installation directories

2009-03-19 Thread Akim Demaille
Le 18 mars 09 à 22:28, Ralf Wildenhues a écrit : * Akim Demaille wrote on Wed, Mar 18, 2009 at 06:31:50PM CET: "RW" == Ralf Wildenhues writes: But the question remains: how do you think we should address the bug that bothers Akim, other than by this patch and a big warning in

Re: [PATCH 11] Fix LAZY_TEST_SUITE handling and $(TEST_SUITE_LOG) recreation.

2009-03-18 Thread Akim Demaille
>>> "RW" == Ralf Wildenhues writes: > Your rule can be simplified a lot: :-) > # Check that XFAIL tests do exist. > check-test-list-XFAIL: $(XFAIL_TESTS) > check-test-list-TFAIL: $(TFAIL_TESTS) > .PHONY: check-test-list-XFAIL check-test-list-TFAIL > Of course that will also update the ac

Re: Do not create conditional installation directories

2009-03-18 Thread Akim Demaille
>>> "RW" == Ralf Wildenhues writes: > But the question remains: how do you think we should address the bug > that bothers Akim, other than by this patch and a big warning in NEWS? My focus was more about an empty $(foodir), not an empty $(foo_DATA). I was suggesting that it would be nice that

Re: [PATCH 11] Fix LAZY_TEST_SUITE handling and $(TEST_SUITE_LOG) recreation.

2009-03-14 Thread Akim Demaille
Le 14 mars 09 à 14:46, Ralf Wildenhues a écrit : * Akim Demaille wrote on Sat, Mar 14, 2009 at 02:25:03PM CET: FWIW, I also noticed that we sometimes had tests that were removed/ renamed that were still marked as XFAILs. So I use this in some of my test suites: Why are these not simply

Re: [PATCH 11] Fix LAZY_TEST_SUITE handling and $(TEST_SUITE_LOG) recreation.

2009-03-14 Thread Akim Demaille
Le 14 mars 09 à 13:39, Akim Demaille a écrit : I often use STRICT_TEST_LOGS = $(shell $(LIST_FAILED_TEST_LOGS)) which makes all failing test strict. In other words, successful tests are not rerun by "make check", but failing tests are. This is because our test suite

Re: proposed patch: parallel-tests: per-extension test driver: ext_COMPILE.

2009-03-14 Thread Akim Demaille
Le 14 mars 09 à 12:08, Ralf Wildenhues a écrit : Corollary: the test driver may not be called CXXCOMPILE. General: For extension `.ext', we cannot use `EXTCOMPILE' as driver. ext_COMPILE or extCOMPILE seem awkward to me too, as these do not allow for generalization either, and the notationa

Re: [PATCH 07] Use append mode to capture parallel test output.

2009-03-14 Thread Akim Demaille
Le 14 mars 09 à 13:34, Ralf Wildenhues a écrit : * Akim Demaille wrote on Sat, Mar 14, 2009 at 01:24:28PM CET: Le 14 mars 09 à 11:56, Ralf Wildenhues a écrit : D'oh. Wonder how often we will keep encountering this. I have not understood what's going on here. Are these fil

Re: [PATCH 11] Fix LAZY_TEST_SUITE handling and $(TEST_SUITE_LOG) recreation.

2009-03-14 Thread Akim Demaille
Le 14 mars 09 à 12:01, Ralf Wildenhues a écrit : Oh, what a joyful patch; cost me most brains. Here's why: It would have been cool if make check LAZY_TEST_SUITE=yes on an up to date test directory would have no work to do at all. Well. Couple of things wrong with the prior semantics: - the

Re: [PATCH 07] Use append mode to capture parallel test output.

2009-03-14 Thread Akim Demaille
Le 14 mars 09 à 11:56, Ralf Wildenhues a écrit : D'oh. Wonder how often we will keep encountering this. Hi Ralf, I have not understood what's going on here. Are these files running concurrently in the same pwd? Cheers, Ralf Use append mode to capture parallel test output. * te

Re: magic variables for included fragments

2008-12-11 Thread Akim Demaille
Le 10 déc. 08 à 21:14, Ralf Wildenhues a écrit : Hi Akim, Hi! * Akim Demaille wrote on Wed, Dec 10, 2008 at 10:21:50AM CET: Ok. And these makes can be fooled to implement the feature by computing the file name at make-time instead of passing a litteral? Not quite sure I follow here

Re: magic variables for included fragments

2008-12-10 Thread Akim Demaille
Le 4 déc. 08 à 09:38, Ralf Wildenhues a écrit : I have a silly question, but... is it really known for a fact that some Make out there do not support "include if it exists"? This question is not relevant to the problem. Automake requires some 'make'-provided inclusion mechanism to work, o

Re: magic variables for included fragments

2008-12-04 Thread Akim Demaille
Le 3 déc. 08 à 20:58, Ralf Wildenhues a écrit : Hi Akim, Hi Ralf, Otherwise too many things go wrong (especially the creation of .deps btw: automake does garbage if you include a local.mk which defines foo_SOURCES = $(prefix)/foo.cc: it creates '$(prefix)/.deps', and I really mean single qu

Re: magic variables for included fragments

2008-12-03 Thread Akim Demaille
>>> "RW" == Ralf Wildenhues <[EMAIL PROTECTED]> writes: > * Ralf Wildenhues wrote on Sun, Oct 12, 2008 at 10:46:06PM CEST: >> >> I'll follow up on automake-patches with a patch to test. > Here we go. WDYT? Hi Ralf, Sorry I did not answer before. In other projects I'm involved in we store

Re: AM_DEFAULT_SOURCE_EXT

2008-11-17 Thread Akim Demaille
form): Accept unconditional > literal extension in AM_DEFAULT_SOURCE_EXT as override for the > default source extension `.c'. If set, ignore the old default > source rule for libtool libraries. > * doc/automake.texi (Default _SOURCES): Document this. > *

Re: Documentation for the parallel-tests driver. [4/4]

2008-10-20 Thread Akim Demaille
Le 18 oct. 08 à 08:22, Ralf Wildenhues a écrit : Hi Akim, Hi Ralf! * Akim Demaille wrote on Fri, Oct 17, 2008 at 12:15:42PM CEST: Consequently, there is little point in showing users how to write such a rule. I strongly disagree here. And your position is quite founded, if but a bit

Re: Parallel tests execution [0/4]

2008-10-20 Thread Akim Demaille
Le 18 oct. 08 à 07:37, Ralf Wildenhues a écrit : * Akim Demaille wrote on Fri, Oct 17, 2008 at 11:12:45AM CEST: At some point we were developping more-or-less test driven: many tests were written way before it was possible to pass them, so we knew that the tests would fail and they were

Re: Parallel test execution: new option `parallel-tests': [1/4]

2008-10-19 Thread Akim Demaille
Le 18 oct. 08 à 03:19, Ralf Wildenhues a écrit : So we make it TFAIL, which means "should be processed soon". I'm not sure I understand the additional value of TFAIL. You have to mark it anyway, so why not mark it XFAIL? Because the one who noted the failure must not "bury" it as an XFAIL.

Re: AM_DEFAULT_SOURCE_EXT (was: Parallel tests execution [0/4])

2008-10-19 Thread Akim Demaille
Le 18 oct. 08 à 03:02, Ralf Wildenhues a écrit : * Akim Demaille wrote on Thu, Oct 16, 2008 at 04:11:22PM CEST: I wish I could define AM_DEFAULT_SOURCE_EXT = .cc or whatever, so that I wouldn't have to define all the foo_SOURCES. I agree "extension" is better than &quo

Re: Documentation for the parallel-tests driver. [4/4]

2008-10-17 Thread Akim Demaille
think that you should detail how to write a .test->.log rule, showing the default value for instance (I use GNU Make syntax). # From a test file to a log file. # Do not use a regular `.test.log:' rule here, since in that case the # following rule (without incoming extension) will mask thi

Re: Parallel tests execution [0/4]

2008-10-17 Thread Akim Demaille
Le 16 oct. 08 à 22:02, Ralf Wildenhues a écrit : Thanks. FWIW, it still has some of the portability issues that I mentioned. Yes, I know, but we don't aim maximum portability. For a start, we expect GNU Make. But I'll be happy to use Automake's version to gain portability :) - (5),

Re: Documentation for the parallel-tests driver. [4/4]

2008-10-16 Thread Akim Demaille
>>> "RW" == Ralf Wildenhues <[EMAIL PROTECTED]> writes: > [EMAIL PROTECTED] Simple tests using @samp{parallel-tests} > [EMAIL PROTECTED] @option{parallel-tests}, Using > +The option @option{parallel-tests} (@pxref{Options}) enables a test > +suite driver that is mostly compatible to the simple

Re: New tests for `parallel-tests'. [3/4]

2008-10-16 Thread Akim Demaille
>>> "RW" == Ralf Wildenhues <[EMAIL PROTECTED]> writes: + # Try the variants that are tried in check.am. + while :; do + for r2h in $RST2HTML rst2html rst2html.py; do + echo "$me: running $r2h --version" + $r2h --version && break 2 + done + exit 77 +

Re: Parallel test execution: new option `parallel-tests': [1/4]

2008-10-16 Thread Akim Demaille
>>> "RW" == Ralf Wildenhues <[EMAIL PROTECTED]> writes: > +case fail=$$fail:xpass=$$xpass:xfail=$$xfail in \ > + fail=0:xpass=0:xfail=0) \ > +msg="$$All$$all $$tests passed. "; \ > +exit=tru

Re: Parallel tests execution [0/4]

2008-10-16 Thread Akim Demaille
While talking about test suites, there is a simple change that would make several Makefile.ams much shorter. Often tests are simple one-compilation-unit programs, in which case the convention that foo_SOURCES defaults to foo.c saves lot of dummy typing (especially if there are many foos). But th

Re: Parallel tests execution [0/4]

2008-10-16 Thread Akim Demaille
e, > adapted from the check.mk file Akim Demaille posted earlier. For the records, I attached the version I'm currently using. check.mk Description: Binary data > 3) should work with different test naming styles: > - *.test (with log files named s/\.test$/.log/) >

Re: Introduce and use the %KEY?TRUE:FALSE% template token

2007-11-30 Thread Akim Demaille
>>> "RW" == Ralf Wildenhues <[EMAIL PROTECTED]> writes: > Hello Akim, > * Akim Demaille wrote on Mon, Nov 19, 2007 at 06:47:41AM CET: >> >> The first thing I would like to do is to factor the >> calls to install, using "install FILES.

lib -> share

2007-11-26 Thread Akim Demaille
Now that Automake uses a decent version control system which, I guess, preserves the history with mv cp etc. it might be time to rename the lib dir as share/?

[SCM] GNU Automake branch, master, updated. Release-1-10-80-gadde5af

2007-11-25 Thread Akim Demaille
ow. - Log - commit adde5afee18384c94974a380df4f85a372e58df9 Author: Akim Demaille <[EMAIL PROTECTED]> Date: Sun Nov 25 17:43:17 2007 +0100 Several *-local in a rule do not work. * tests/all.test: Check this c

[SCM] GNU Automake branch, master, updated. Release-1-10-79-g66027a9

2007-11-25 Thread Akim Demaille
any other notification email; so we list those revisions in full, below. - Log - commit 66027a9bdc9bd3419f5a87e7d50c3ff0f2e920b8 Author: Akim Demaille <[EMAIL PROTECTED]> Date: Sun Nov 25 12:02:22 2007 +0100 Fix uses

[SCM] GNU Automake branch, master, updated. Release-1-10-77-g0db12da

2007-11-25 Thread Akim Demaille
ow. - Log - commit 0db12da3f3ad987547f5156ba7355b593233cb39 Author: Akim Demaille <[EMAIL PROTECTED]> Date: Sun Nov 25 10:47:00 2007 +0100 * bootstrap: Fix typos on redirections. Signed-off-by: Akim Demaille &

[SCM] GNU Automake branch, master, updated. Release-1-10-76-g9c7aee9

2007-11-24 Thread Akim Demaille
ow. - Log - commit 9c7aee991634ac47e207fe54730afaa1b67dd2dc Author: Akim Demaille <[EMAIL PROTECTED]> Date: Sat Nov 24 15:02:41 2007 +0100 Skip comments and empty lines in dirlist in the tests. * defs.in

[SCM] GNU Automake branch, master, updated. Release-1-10-75-g94e81d5

2007-11-24 Thread Akim Demaille
ow. - Log - commit 94e81d5582c92a4376744bc5e601f60773f63e71 Author: Akim Demaille <[EMAIL PROTECTED]> Date: Sat Nov 24 12:24:22 2007 +0100 Ternary operator in lib/am files. * automake.in (&t

[SCM] GNU Automake branch, master, updated. Release-1-10-74-g1d0c65c

2007-11-24 Thread Akim Demaille
ow. - Log - commit 1d0c65c8894d499ad034c9cc189808d4ecd3db5c Author: Akim Demaille <[EMAIL PROTECTED]> Date: Sat Nov 24 10:10:11 2007 +0100 Normalize white spaces * automake.in: Normal

Re: It gits on my nerves

2007-11-24 Thread Akim Demaille
Le 24 nov. 07 à 11:03, Ralf Wildenhues a écrit : Hello Akim, * Akim Demaille wrote on Sat, Nov 24, 2007 at 10:18:30AM CET: I have been fighting with git for almost two hours to put my patches in order and to apply them upstream. I'm really sorry it's so much trouble for you. It

Re: It gits on my nerves

2007-11-24 Thread Akim Demaille
Le 24 nov. 07 à 10:58, Akim Demaille a écrit : [EMAIL PROTECTED] ~/src/wd/automake $ git config remote.origin.url ssh://[EMAIL PROTECTED]/automake.git Fixed. [EMAIL PROTECTED] ~/src/wd/automake $ git config remote.origin.url ssh://[EMAIL PROTECTED]/srv/git/automake.git [EMAIL PROTECTED

Re: It gits on my nerves

2007-11-24 Thread Akim Demaille
Le 24 nov. 07 à 10:18, Akim Demaille a écrit : [EMAIL PROTECTED] ~/src/wd/automake $ git push 10:11:43 fatal: The remote end hung up unexpectedly error: failed to push to 'git://git.sv.gnu.org/automake.git' I have found pages reporting that this

It gits on my nerves

2007-11-24 Thread Akim Demaille
I have been fighting with git for almost two hours to put my patches in order and to apply them upstream. I wish I could have spent some time on the patches themselves, but I guess it'll come once I understand how git works :( I'm stuck here, and I'm tired of it. I can't seem to be able to do wh

Empty lines and comments in dirlist

2007-11-20 Thread Akim Demaille
The test suite was failing on my machine because I have an empty line in a dirlist. It resulted in a -I without argument. I suggest the following patch. * defs.in (extra_includes): Skip comments and empty lines in dirlist. diff --git a/tests/defs.in b/tests/defs.in index d79d87

$(@:-local=)

2007-11-19 Thread Akim Demaille
I see that the documentation of Automake suggests: all-local: cd subdir && $(MAKE) $(AM_MAKEFLAGS) all check-local: cd subdir && $(MAKE) $(AM_MAKEFLAGS) test clean-local: cd subdir && $(MAKE) $(AM_MAKEFLAGS) clean # Assuming the package

Re: Introduce and use the %KEY?TRUE:FALSE% template token

2007-11-19 Thread Akim Demaille
| # This program is free software; you can redistribute it and/or modify | # it under the terms of the GNU General Public License as published by | -# the Free Software Foundation; either version 3, or (at your option) | +# the Free Software Foundation; either version 2, or (at your opt

Re: Introduce and use the %KEY?TRUE:FALSE% template token

2007-11-19 Thread Akim Demaille
Le 19 nov. 07 à 10:31, Ralf Wildenhues a écrit : Hello Akim, * Akim Demaille wrote on Mon, Nov 19, 2007 at 06:47:41AM CET: The first thing I would like to do is to factor the calls to install, using "install FILES... DIR". The first thing you should do then is get the GNU Coding

Re: Introduce and use the %KEY?TRUE:FALSE% template token

2007-11-18 Thread Akim Demaille
Le 19 nov. 07 à 06:26, Akim Demaille a écrit : I would like to work a bit on the install targets The first thing I would like to do is to factor the calls to install, using "install FILES... DIR". One problem is nobase_. I see several means to cope with it: - Don't try to

Introduce and use the %KEY?TRUE:FALSE% template token

2007-11-18 Thread Akim Demaille
I would like to work a bit on the install targets, and before starting I felt that some means to factor and to make template files more readable were lacking. I propose the following. ternary.patch Description: Binary data

Re: install-sh -C

2006-10-27 Thread Akim Demaille
Le 25 oct. 06 à 18:04, Stepan Kasal a écrit : Hello, On Wed, Oct 25, 2006 at 05:35:31PM +0200, Akim Demaille wrote: find stampfile -newer $file indeed, according to the documentation, the predicate is true if stampfile is strictly newer than $file. So the implementation would have to be

Re: install-sh -C

2006-10-25 Thread Akim Demaille
e `set -e'-clean. I saw weird issues with AIX /bin/sh in Libtool, but have not been able to get to the bottom of those yet. (I've been meaning to do that in order to be able to write a helpful bug report to Autoconf.) But working without -e is so dangerous too... Here is my updated p

Re: install-sh -C

2006-10-22 Thread Akim Demaille
I have some problems with these definitions. If there are several files that have the youngest time stamp, then the order depends on the locale. Nia? How can the locale change the order to time stamps? Only if the time stamps are the same: $ touch a B $ LC_ALL=C ls -1t B a $ ls -1t a B $ l

Re: install-sh -C

2006-10-22 Thread Akim Demaille
I think using \ then newline then && was done to mimic GCS style for C code. FWIW, I prefer your style as well. That style was also used elsewhere. Wouldn't using $diffprog without double quotes be more consistent, so the user could pass options to diff as well? Sure. +test x"

install-sh -C

2006-10-22 Thread Akim Demaille
I work on a set of projects that share header files, and I have found it quite useful to spare compilation cycles by using AC_SUBST([INSTALL_HEADER], ['$(SHELL) $(install_sh_DATA) -C']) i.e., adding an option -C to install-sh to have a behavior similar to move-if-change. The name of the option

Re: FYI: fix race condition in elisp's recover rule

2005-03-29 Thread Akim Demaille
Le 29 mars 05, à 20:46, Alexandre Duret-Lutz a écrit : +data.c data.h data.w data.x: data.stamp +## Recover from the removal of $@@ +@@if test -f $@@; then :; else \ + trap 'rm -rf data.lock data.stamp 1 2 13 15; \ +## mkdir is a portable test-and-set + if mkdir data.lock

Re: FYI: #.*\

2005-03-02 Thread Akim Demaille
>>> "adl" == Alexandre Duret-Lutz <[EMAIL PROTECTED]> writes: > +grep '3\.test' tests > +grep '&&' tests && exit 1 What is this part checking? > +grep '4\.test' tests && exit 1 > +grep '5\.test' tests