[bug#72536] [PATCH v3] tap: new `--stderr-prefix' option to prefix test script's stderr

2025-02-19 Thread Richard Hansen
On 2/19/25 12:48, Karl Berry wrote: A separate question (for anyone), when we get that far ... what's the best way to apply/commit a patch series like this? 1. Save all of the *.patch attachments to disk. 2. Run `git am /path/to/*.patch`. Usually I use `git send-email` to email commits; th

[bug#72536] [PATCH v3] tap: new `--stderr-prefix' option to prefix test script's stderr

2025-02-19 Thread Richard Hansen
On 2/19/25 12:47, Karl Berry wrote: However ... when I ran make check with the changes installed, the tap-merge-stdout-stderr test failed. Did it succeed for you? Before I delved into it, thought I'd check back. Doh! There's a race condition and no portable (POSIX) way to fix it, I think. Th

[bug#72536] [PATCH v3] tap: new `--stderr-prefix' option to prefix test script's stderr

2025-02-19 Thread Jacob Bachmeyer
On 2/19/25 11:48, Karl Berry wrote: A separate question (for anyone), when we get that far ... what's the best way to apply/commit a patch series like this? Sorry for my lack of git-fu. When I run "git am mboxfile" after saving your msg in mboxfile, it applies fine, but then git log -n 1 -p show

[bug#72536] [PATCH v3] tap: new `--stderr-prefix' option to prefix test script's stderr

2025-02-19 Thread Karl Berry
A separate question (for anyone), when we get that far ... what's the best way to apply/commit a patch series like this? Sorry for my lack of git-fu. When I run "git am mboxfile" after saving your msg in mboxfile, it applies fine, but then git log -n 1 -p shows that only the first Subject: is used

[bug#72536] [PATCH v3] tap: new `--stderr-prefix' option to prefix test script's stderr

2025-02-19 Thread Karl Berry
Hi Richard and all, Attached is v3 of the patch series. Changes from v2: Thanks so much for your careful work. I read through the changes and nothing problematic jumped out at me. (Trivial: I think it's conventional for us to use test instead of [, even when we're assuming a modern shell. I