[bug#60807] [PATCH v2] tests: reuse am_cv_filesystem_timestamp_resolution

2023-01-14 Thread Nick Bowler
On 14/01/2023, Zack Weinberg wrote: > On Sat, Jan 14, 2023, at 7:18 PM, Mike Frysinger wrote: >> Rather than assume such coarse delays, re-use existing logic for >> probing the current filesystem resolution. This speeds up the >> testsuite significantly.> [...] > No objection to this patch in its

[bug#60807] [PATCH v2] tests: reuse am_cv_filesystem_timestamp_resolution

2023-01-14 Thread Jacob Bachmeyer
Mike Frysinger wrote: Rather than assume such coarse delays, re-use existing logic for probing the current filesystem resolution. This speeds up the testsuite significantly. On my system, it speeds -j1 up quite a lot -- by ~30%. While I didn't gather many samples to produce a statistically sig

[bug#60807] [PATCH 1/2] mtime: use Time::HiRes::stat when available for subsecond resolution

2023-01-14 Thread Jacob Bachmeyer
Mike Frysinger wrote: Perl's builtin stat function returns timestamps that have 1 second resolution. This can lead automake needlessly regenerating files because it compares timestamps as "older than or equal to" rather than only "older than". This is perfectly reasonable as we have no way of k

[bug#60807] [PATCH v2] tests: reuse am_cv_filesystem_timestamp_resolution

2023-01-14 Thread Zack Weinberg
On Sat, Jan 14, 2023, at 7:18 PM, Mike Frysinger wrote: > Rather than assume such coarse delays, re-use existing logic for > probing the current filesystem resolution. This speeds up the > testsuite significantly. On my system, it speeds -j1 up quite a > lot -- by ~30%. While I didn't gather man

[bug#60776] [PATCH] distdir/emacs: avoid `test -d` with MKDIR_P

2023-01-14 Thread Mike Frysinger
On 14 Jan 2023 17:05, Karl Berry wrote: > most of the code directly preceding & following this line use @. > i.e. the vast majority of the current distdir logic. > > Yeah. > > If you feel like changing those @'s to AM_v_at while we're here, sounds > good to me ... -k i'd like to give it

[bug#60807] [PATCH v2] tests: reuse am_cv_filesystem_timestamp_resolution

2023-01-14 Thread Mike Frysinger
Rather than assume such coarse delays, re-use existing logic for probing the current filesystem resolution. This speeds up the testsuite significantly. On my system, it speeds -j1 up quite a lot -- by ~30%. While I didn't gather many samples to produce a statistically significant distribution, m

[bug#60776] [PATCH] distdir/emacs: avoid `test -d` with MKDIR_P

2023-01-14 Thread Karl Berry
most of the code directly preceding & following this line use @. i.e. the vast majority of the current distdir logic. Yeah. If you feel like changing those @'s to AM_v_at while we're here, sounds good to me ... -k

[bug#60807] [PATCH 1/2] mtime: use Time::HiRes::stat when available for subsecond resolution

2023-01-14 Thread Mike Frysinger
On 14 Jan 2023 14:52, Karl Berry wrote: > +my $have_time_hires = eval { require Time::HiRes; }; > > I don't object. Although if there's no speed up in practice, I wonder if > it's worth the extra code (simple-enough though it is). -k there's no speed up in the execution of a single process, b

[bug#60776] [PATCH] distdir/emacs: avoid `test -d` with MKDIR_P

2023-01-14 Thread Mike Frysinger
On 14 Jan 2023 15:17, Karl Berry wrote: > imo we overly rely on explicit @ in many places which can make debugging > failures painful. > > FWIW, I agree. Although I see no @ here. most of the code directly preceding & following this line use @. i.e. the vast majority of the current distdi

[bug#60776] [PATCH] distdir/emacs: avoid `test -d` with MKDIR_P

2023-01-14 Thread Karl Berry
imo we overly rely on explicit @ in many places which can make debugging failures painful. FWIW, I agree. Although I see no @ here. if we ever get to that day, we'd use $(AM_V_at) in this location. Ok by me. --thanks, karl.

[bug#60807] [PATCH 1/2] mtime: use Time::HiRes::stat when available for subsecond resolution

2023-01-14 Thread Karl Berry
+my $have_time_hires = eval { require Time::HiRes; }; I don't object. Although if there's no speed up in practice, I wonder if it's worth the extra code (simple-enough though it is). -k

[bug#60808] [PATCH 2/2] tests: reuse am_cv_filesystem_timestamp_resolution

2023-01-14 Thread Karl Berry
-case $build in - *-pc-msdosdjgpp) MODIFICATION_DELAY=5;; - *) MODIFICATION_DELAY=2;; -esac +MODIFICATION_DELAY=$am_cv_filesystem_timestamp_resolution Looks fantastic to me :). --thanks, karl.

[bug#59994] [PATCH] tests: Don't try to prevent flex to include unistd.h

2023-01-14 Thread Karl Berry
The *command line option* --never-interactive was added in version 2.5.6 (along with long command line options in general). That version was released somewhere between 2002-04-19 and 2002-04-23; I guess 20 years ago is long enough, barely :). Though if it's just as easy to use the %opt

[bug#59994] [PATCH] tests: Don't try to prevent flex to include unistd.h

2023-01-14 Thread Zack Weinberg
On Fri, Jan 13, 2023, at 6:33 PM, Karl Berry wrote: >> your patch *and* consistently test flex with "--never-interactive". > > Making flex non-interactive sounds desirable in any case, but > --never-interactive is not mentioned in the 2.6.0 --help message. > Instead there is -B (--batch), although

[bug#60807] [PATCH 1/2] mtime: use Time::HiRes::stat when available for subsecond resolution

2023-01-14 Thread Mike Frysinger
Perl's builtin stat function returns timestamps that have 1 second resolution. This can lead automake needlessly regenerating files because it compares timestamps as "older than or equal to" rather than only "older than". This is perfectly reasonable as we have no way of knowing what file is olde

[bug#60808] [PATCH 2/2] tests: reuse am_cv_filesystem_timestamp_resolution

2023-01-14 Thread Mike Frysinger
Rather than assume such coarse delays, re-use existing logic for probing the current filesystem resolution. This speeds up the testsuite significantly. On my system, it speeds -j1 up quite a lot -- by ~30%. While I didn't gather many samples to produce a statistically significant distribution, m