[bug#60772] [PATCH] tests: rework gettext to only check 'external' behavior

2023-01-13 Thread Mike Frysinger
On 13 Jan 2023 16:52, Karl Berry wrote: > Subject: [bug#60772] [PATCH] tests: rework gettext to only check > 'external' > behavior > > Good catch, thanks. Please commit. > > +# po/ is required. intl/ should not be used. > > Perhaps add the bit of information from your mail to help

[bug#60776] [PATCH] distdir/emacs: avoid `test -d` with MKDIR_P

2023-01-13 Thread Mike Frysinger
On 13 Jan 2023 15:36, Karl Berry wrote: > - test -d "$(distdir)" || mkdir "$(distdir)" > + $(AM_V_at)$(MKDIR_P) "$(distdir)" > > Ok by me, but why the AM_V_at for this particular command? > I don't see it used anywhere else in distdir.am. this is certainly true, and it's something i want

[bug#60772] [PATCH] tests: rework gettext to only check 'external' behavior

2023-01-13 Thread Karl Berry
Subject: [bug#60772] [PATCH] tests: rework gettext to only check 'external' behavior Good catch, thanks. Please commit. +# po/ is required. intl/ should not be used. Perhaps add the bit of information from your mail to help future sleuths: "... not be used, since non-external use

[bug#59994] [PATCH] tests: Don't try to prevent flex to include unistd.h

2023-01-13 Thread Karl Berry
> your patch *and* consistently test flex with "--never-interactive". Making flex non-interactive sounds desirable in any case, but --never-interactive is not mentioned in the 2.6.0 --help message. Instead there is -B (--batch), although --never-interactive is recognized, I can see experiment

[bug#60776] [PATCH] distdir/emacs: avoid `test -d` with MKDIR_P

2023-01-13 Thread Karl Berry
- test -d "$(distdir)" || mkdir "$(distdir)" + $(AM_V_at)$(MKDIR_P) "$(distdir)" Ok by me, but why the AM_V_at for this particular command? I don't see it used anywhere else in distdir.am. - test -d "$$am__dir" || $(MKDIR_P) "$$am__dir" || exit 1; \ + $(MKDIR_P) "$$am_

[bug#60771] [PATCH] tests: disable git log pager usage

2023-01-13 Thread Karl Berry
- (cd "$am_top_srcdir" && git log -1) || st=1 + (cd "$am_top_srcdir" && git --no-pager log -1) || st=1 Sure. Please commit. Thanks. -k

[bug#60763] [PATCH] tests: change `sort|uniq` to `sort -u`

2023-01-13 Thread Karl Berry
-done | sed 's,^\./,,' | sort | uniq >$(am__tfs); \ +done | sed 's,^\./,,' | sort -u >$(am__tfs); \ Sure, looks good, please commit. (60764 looks like a dup?)

[bug#59994] [PATCH] tests: Don't try to prevent flex to include unistd.h

2023-01-13 Thread Mike Frysinger
On 13 Jan 2023 13:49, Frederic Berat wrote: > I probably won't be able to do so before next week at least. > If you happen to have time (and be willing) to do it earlier, don't > hesitate ;) that timeframe is fine. as you can see, we take a long view in Automake. -mike signature.asc Description

[bug#59994] [PATCH] tests: Don't try to prevent flex to include unistd.h

2023-01-13 Thread Frederic Berat
I probably won't be able to do so before next week at least. If you happen to have time (and be willing) to do it earlier, don't hesitate ;) On Fri, Jan 13, 2023 at 7:31 AM Mike Frysinger wrote: > On Mon, 12 Dec 2022 15:20:46 -0500, Zack Weinberg wrote: > > On 2022-12-12 2:07 AM, Frederic Berat

[bug#59993] [PATCH v2 3/3] tests: Fix implicit function declaration in ax/depcomp.sh

2023-01-13 Thread Frederic Berat
Ok, I'll try to figure out why this test passes on 1.16.5 but not on HEAD with the same patch. On Fri, Jan 13, 2023 at 9:47 AM Mike Frysinger wrote: > On 13 Jan 2023 09:14, Frederic Berat wrote: > > I made one more build with a different patchset list, could it be that > the > > failure you enco

[bug#60776] [PATCH] distdir/emacs: avoid `test -d` with MKDIR_P

2023-01-13 Thread Mike Frysinger
We don't need to do the `test -d ... || mkdir ...` dance when we have the MKDIR_P helper, so simplify this code a bit. * lib/am/distdir.am: Use $(MKDIR_P). * lib/am/lisp.am: Drop redundant `test -d`. --- lib/am/distdir.am | 2 +- lib/am/lisp.am| 2 +- 2 files changed, 2 insertions(+), 2 delet

[bug#59993] [PATCH v2 3/3] tests: Fix implicit function declaration in ax/depcomp.sh

2023-01-13 Thread Mike Frysinger
On 13 Jan 2023 09:14, Frederic Berat wrote: > I made one more build with a different patchset list, could it be that the > failure you encounter is with "t/subobj.sh" ? to be clear, i applied this patch only to current git master. i didn't try including anything else. with that in mind, the fail

[bug#59993] [PATCH v2 3/3] tests: Fix implicit function declaration in ax/depcomp.sh

2023-01-13 Thread Frederic Berat
I made one more build with a different patchset list, could it be that the failure you encounter is with "t/subobj.sh" ? In my tests run this failure is fixed by: https://lists.gnu.org/archive/html/automake-patches/2022-12/msg1.html On Fri, Jan 13, 2023 at 8:57 AM Frederic Berat wrote: > Th