[bug#59989] [PATCH] tests: Fix txinfo-include test for texinfo 7.x

2022-12-12 Thread Jacob Bachmeyer
Karl Berry wrote: Hi Frederic, Texinfo modified its behavior regarding apostrophes, which are now replaced by UTF-8 right single quotes by default. Sorry to hear it, but not surprised. -GNU's Not Unix. +@verb{.GNU's Not Unix..} I don't think there's any guarantee that verb quo

[bug#59991] [PATCH 0/2] Port tests to modern C

2022-12-12 Thread Sam James
> On 12 Dec 2022, at 22:57, Karl Berry wrote: >Another patch dedicated to Flex related tests will follow. > > Just wondering again, is an upstream flex still actively maintained by > anyone, anywhere? Looks like https://github.com/westes/flex was touched > 6 months ago, so that's good, but

[bug#59991] [PATCH 0/2] Port tests to modern C

2022-12-12 Thread Karl Berry
There is ongoing work from both GCC and Clang community to set the C99 standard as the default one, Sounds inevitable. in an effort to improve security overall. How does C99 improve security? Just wondering. failures in Automake, that are attempted to be fixed, mainly in this

bug#59989: [PATCH] tests: Fix txinfo-include test for texinfo 7.x

2022-12-12 Thread Karl Berry
Hi Frederic, Texinfo modified its behavior regarding apostrophes, which are now replaced by UTF-8 right single quotes by default. Sorry to hear it, but not surprised. -GNU's Not Unix. +@verb{.GNU's Not Unix..} I don't think there's any guarantee that verb quotes will also be "he

[bug#59994] [PATCH] tests: Don't try to prevent flex to include unistd.h

2022-12-12 Thread Zack Weinberg
On 2022-12-12 2:07 AM, Frederic Berat wrote: This patch is mainly a proposal. While the macro can simply be removed as explained below, another possibility it to add a flex option "--never-interactive" to prevent flex to make use of "isatty". This is related to an effort to prepare Automake for

[bug#59993] [PATCH 2/2] tests: Fix implicit function declaration errors

2022-12-12 Thread Zack Weinberg
On 2022-12-12 2:05 AM, Frederic Berat wrote: This is related to an effort to prepare Automake for future GCC/Clang versions which set c99 as default standard to be used. Function should be properly declared prior to use in order to be compatible with c99 standard. OK in principle, but ... ---

[bug#59992] [PATCH 1/2] tests: Fix 'type defaults' error in link_cond due to main not being properly declared

2022-12-12 Thread Zack Weinberg
On 2022-12-12 2:05 AM, Frederic Berat wrote: This is related to an effort to prepare Automake for future GCC/Clang versions which set c99 as default standard to be used. Not properly declaring main as "int main(...)" is rejected since c99. ... /* Valid C but deliberately invalid C++ */ -main

[bug#59990] [PATCH] tests: depcomp: ensure make_ok() fails when run_make fails

2022-12-12 Thread Frederic Berat
From: Frédéric Bérat While running automake tests with -std-gnu=c99, the compiler report errors which lead to make to fail. Yet, these failures are ignored during the tests, which considers them to be successful as stderror is check for one specific pattern. If make fails, investigation should b

[bug#59991] [PATCH 0/2] Port tests to modern C

2022-12-12 Thread Frederic Berat
Hello, There is ongoing work from both GCC and Clang community to set the C99 standard as the default one, in an effort to improve security overall. In this context, Fedora packages were rebuilt with some warnings turned as errors to simulate the change. This leads to failures in Automake, that ar

[bug#59993] [PATCH 2/2] tests: Fix implicit function declaration errors

2022-12-12 Thread Frederic Berat
From: Frédéric Bérat This is related to an effort to prepare Automake for future GCC/Clang versions which set c99 as default standard to be used. Function should be properly declared prior to use in order to be compatible with c99 standard. This is valid for both local functions and standard fun

[bug#59992] [PATCH 1/2] tests: Fix 'type defaults' error in link_cond due to main not being properly declared

2022-12-12 Thread Frederic Berat
From: Frédéric Bérat This is related to an effort to prepare Automake for future GCC/Clang versions which set c99 as default standard to be used. Not properly declaring main as "int main(...)" is rejected since c99. --- t/link_cond.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[bug#59994] [PATCH] tests: Don't try to prevent flex to include unistd.h

2022-12-12 Thread Frederic Berat
From: Frédéric Bérat Hello, This patch is mainly a proposal. While the macro can simply be removed as explained below, another possibility it to add a flex option "--never-interactive" to prevent flex to make use of "isatty". -- 8< -- This is related to an effort to prepare Automake for future

[bug#59989] [PATCH] tests: Fix txinfo-include test for texinfo 7.x

2022-12-12 Thread Frederic Berat
From: Frédéric Bérat Texinfo modified its behavior regarding apostrophes, which are now replaced by UTF-8 right single quotes by default. It looks like this was supposed to be the default for few years already, but this behavior was broken so far. Use the @verb construct in order to ensure that