Re: [PATCH 01/10] subdir-objects: enable unconditionally

2013-05-14 Thread Eric Blake
On 05/14/2013 02:04 AM, Stefano Lattarini wrote: > See automake bug#13378. > > @@ -10225,15 +10216,6 @@ bin_SCRIPTS = true.sh ... > AM_INSTALLCHECK_STD_OPTIONS_EXEMPT = false$(EXEEXT) true.sh > @end example > > -@item @option{subdir-objects} > -@cindex Options, @option{subdir-objects} > -@opi

[FYI] {maint} tests: less uses of "make -e"; avoid spurious failures in 'check-cc-no-c-o'

2013-05-14 Thread Stefano Lattarini
That is, when the testsuite is run using a fake C compiler that doesn't grasp the '-c' and '-o' options together. * t/instdir-prog.sh: Adjust. * t/instdir-ltlib.sh: Likewise. Signed-off-by: Stefano Lattarini --- t/instdir-ltlib.sh | 23 --- t/instdir-prog.sh | 22 ++

[FYI] {maint} build: be more respectful of user-specified verbosity

2013-05-14 Thread Stefano Lattarini
* t/Makefile.in (check-cc-no-c-o, check-no-trailing-backslash-in-recipes, installcheck-testsuite, perf): Here. Signed-off-by: Stefano Lattarini --- t/Makefile.inc | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/t/Makefile.inc b/t/Makefile.inc index 85c4c8e..f979c6

[FYI] {maint} check-cc-no-c-o: unify initializations in a single place

2013-05-14 Thread Stefano Lattarini
* t/ax/test-defs.in: That is, by setting CC and GNU_CC here, in accord with the value of the variable 'AM_TESTSUITE_SIMULATING_NO_CC_C_O'. * t/Makefile.in (check-cc-no-c-o) : No need to reset CC and GNU_CC any longer in the recursive "make check" invocation. Signed-off-by: Stefano Lattarini ---

[FYI] {maint} check-cc-no-c-o: avoid a spurious failure

2013-05-14 Thread Stefano Lattarini
* t/am-prog-cc-c-o.sh: In this test, by relying on the knowledge that we are running under the aegis of the 'check-cc-no-c-o' maintainer-specific target, knowledge given us by ... * t/Makefile.in (check-cc-no-c-o) : ... the new environment variable 'AM_TESTSUITE_SIMULATING_NO_CC_C_O', set to a valu

Re: [PATCH 03/10] depend: assume we can always pass '-o' to the C compiler

2013-05-14 Thread Stefano Lattarini
Hi Peter. On 05/14/2013 12:33 PM, Peter Rosin wrote: > On 2013-05-14 10:04, Stefano Lattarini wrote: >> diff --git a/bin/automake.in b/bin/automake.in >> index 63e5962..df6560d 100644 >> --- a/bin/automake.in >> +++ b/bin/automake.in >> @@ -1330,7 +1324,7 @@ sub handle_languages () >> >>

Re: [PATCH 03/10] depend: assume we can always pass '-o' to the C compiler

2013-05-14 Thread Peter Rosin
On 2013-05-14 10:04, Stefano Lattarini wrote: > diff --git a/bin/automake.in b/bin/automake.in > index 63e5962..df6560d 100644 > --- a/bin/automake.in > +++ b/bin/automake.in > @@ -1330,7 +1324,7 @@ sub handle_languages () > >COMPILE => '$(' . $lang->compiler . ')',

[FYI] {maint} build: fixup for building in a VPATH setup

2013-05-14 Thread Stefano Lattarini
* bin/Makefile.inc (%D%/automake, %D%/aclocal): Make sure that the directory where the targets scripts are going to be built exists, before trying to create said scripts. Signed-off-by: Stefano Lattarini --- bin/Makefile.inc | 1 + 1 file changed, 1 insertion(+) diff --git a/bin/Makefile.inc b/

[PATCH 07/10] depend: a preparatory refactoring

2013-05-14 Thread Stefano Lattarini
This is just a preparatory change in view of a future refactoring. No semantic change is intended. * lib/am/depend2.am: Adjust; for example, using '$@' in all recipes to indicate the output file (rather than recipe-specific transforms like '%OBJ%' and '%LTOBJ%'), and not assuming to know the exact

[PATCH 04/10] depend: assume '-c' compiler flag always means to produce object files

2013-05-14 Thread Stefano Lattarini
Rather than fully-fledged executables. This is the case for all the compilers of all languages supported by Automake. This is just a simplification; no semantic changes are intended. * bin/automake.in (handle_languages): Drop transform '%-c%'. * lib/am/depend2.am: Adjust to just assume the '%-c%

[PATCH 05/10] Automake::Language: drop unused fields 'compile_flag' and 'output_flag'

2013-05-14 Thread Stefano Lattarini
They are unused after the recent flurry of changes. This is just a simplification; no semantic change is intended. * lib/Automake/Language.pm (Class::Struct): Remove unused fields here. * bin/automake.in: And here, in all the 'register_language()' invocations. Signed-off-by: Stefano Lattarini -

[PATCH 02/10] cleanup: having subdir-objects mandatory allow us some simplifications

2013-05-14 Thread Stefano Lattarini
Few minor cleanups made possible by earlier changes, plus other minor cleanups triggered in cascade. No semantic change is intended. This is a follow-up on previous commit 'v1.13.1d-214-g3ad07d2', and an adjusted backport of Automake-NG commit 'v1.12.1-315-gc97d41b' of 2012-06-08 ([ng] cleanup: a

[PATCH 09/10] depend: prefer $(...) over `...` in Cygwin-specific recipes

2013-05-14 Thread Stefano Lattarini
On Cygwin, we can happily assume only POSIX-conforming shells exist. This commit is useless by itself, but is useful as a preparatory refactoring in view of a future change. * lib/am/depend2.am: In recipes for producing '.obj' objects, use the POSIX form $(...) for command substitution, rather tha

[PATCH 00/10] {master} Enable subdir-objects option unconditionally

2013-05-14 Thread Stefano Lattarini
Related to automake bug#13378: This series has been derived from this earlier version: Since this series is not yet finalized (i.e., it might require last-minute tweaks

[PATCH 06/10] depend: refactor and remove code duplication

2013-05-14 Thread Stefano Lattarini
* lib/am/depend2.am: Here. The obsolescent comments removed from this same file in commit 'v1.13.1-42-g8f06bfb' of 2012-01-09, "depend2.am: fix comments on verbosity of compilation rules", gave the rationale for why that code duplication was there in the first place (rationale that, like those com

[PATCH 03/10] depend: assume we can always pass '-o' to the C compiler

2013-05-14 Thread Stefano Lattarini
This is the case after the change in commit v1.13.1-56-g34001a9 of 2013-01-09 (compile: use 'compile' script when "-c -o" is used with losing compilers). This is just a simplification; no semantic changes are intended. * bin/automake.in (handle_languages): Drop transform '%-o%', and definitions o

[PATCH 08/10] depend: reduce code duplication

2013-05-14 Thread Stefano Lattarini
Just a simplification; no semantic change is intended. * lib/am/depend2.am (am__set_depbase): New. Use it in all the three flavours of recipes (.o, .obj, .lo), instead of duplicating its code. Signed-off-by: Stefano Lattarini --- lib/am/depend2.am | 17 - 1 file changed, 8 inse

[PATCH 10/10] depend: reduce code duplication, de-uglify make verbose output

2013-05-14 Thread Stefano Lattarini
Verbose output from compilation recipes had been made more messy by the previous "simplifying" commit XXX. With this patch, not only we reduce some code duplication, but also improve that output again, for the joy of users who dislike silent-rules :-) * lib/am/depend2.am: Use the new '%XSOURCE%'

[PATCH 01/10] subdir-objects: enable unconditionally

2013-05-14 Thread Stefano Lattarini
See automake bug#13378. The fact that Automake-generated Makefiles places compiled object files in the current directory by default, also when the corresponding source file is in a subdirectory, is basically an historical accident, due to the fact that the 'subdir-objects' option had only been int