[FYI] {maint} parallel-tests: silence an overly verbose recipe

2012-06-30 Thread Stefano Lattarini
* lib/am/check.am (check-TESTS): Here, the part of the recipe removing the stale '.log' and '.trs' files. Signed-off-by: Stefano Lattarini --- lib/am/check.am |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/am/check.am b/lib/am/check.am index 16bde36..19a803f 1006

[FYI] {maint} tests: fix some uses of 'Exit', where 'exit' should now be used instead

2012-06-30 Thread Stefano Lattarini
* t/parallel-tests-recheck-pr11791.sh: Here. Signed-off-by: Stefano Lattarini --- t/parallel-tests-recheck-pr11791.sh | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/t/parallel-tests-recheck-pr11791.sh b/t/parallel-tests-recheck-pr11791.sh index bfc55fa.

[FYI] maintcheck: test scripts should be executable, check for that

2012-06-30 Thread Stefano Lattarini
* syntax-checks.mk (sc_tests_executable): Here, in this new check. (syntax_check_rules): Add it. * Makefile.am (dist-hook): Drop, no need to make test cases executable anymore. Signed-off-by: Stefano Lattarini --- syntax-checks.mk | 14 ++ 1 file changed, 14 insertions(+) diff --g

Re: [RFC] recursion: support user-defined recursive targets

2012-06-30 Thread Stefano Lattarini
On 06/30/2012 09:33 PM, Dave Hart wrote: > On Sat, Jun 30, 2012 at 13:16 UTC, Stefano Lattarini wrote: > >> Ah, but the nice thing about this new feature is that you don't need >> to define a 'foo-local' target in each of your Makefiles in order to >> support a recursive 'foo' target! You only hav

Re: [RFC] recursion: support user-defined recursive targets

2012-06-30 Thread Dave Hart
On Sat, Jun 30, 2012 at 13:16 UTC, Stefano Lattarini wrote: > Hi Dave, thanks for the feedback. > > On 06/30/2012 12:54 PM, Dave Hart wrote: >> On Sat, Jun 30, 2012 at 08:56 UTC, Stefano Lattarini wrote: >>> And here is the documentation, basically adapted from the commit message. >>> >>> Comments

[PATCH] parallel-tests: recipes for "check" and "recheck" are separated again

2012-06-30 Thread Stefano Lattarini
* lib/am/check.am: Here. They have distinctly diverged recently, and the reduction in code duplication obtained keeping their recipes united is not anymore worth the extra complications. Signed-off-by: Stefano Lattarini --- Oops, I sent a mangled version of the patch. Here's the correct one.

[FYI] {maint} parallel-tests: recipes for "check" and "recheck" are separated again

2012-06-30 Thread Stefano Lattarini
* lib/am/check.am: Here. They have distinctly diverged recently, and the reduction in code duplication obtained keeping their recipes united is not anymore worth the extra complications. Signed-off-by: Stefano Lattarini --- lib/am/check.am | 89 +++-

Re: bug#11791: recheck and compilation error

2012-06-30 Thread Stefano Lattarini
Reference: On 06/27/2012 03:08 PM, Stefano Lattarini wrote: > > I agree. The attached patch should solve the issue. It's more ugly > than I'd like, but this bug is annoying enough to make such ugliness > acceptable. I will push (to maint) in a couple of days if t

[PATCH] {master} aclocal: deprecate ACLOCAL_AMFLAGS, trace AC_CONFIG_MACRO_DIR instead

2012-06-30 Thread Stefano Lattarini
Maintaining ACLOCAL_AMFLAGS in the Makefile.am to pass extra flags to aclocal is (and have always been) quite of an hack. For example, autoreconf is forced to grep Makefile.am to honour those flags. But this is a bad obsolescent behaviour; in fact, the autotools have moved consistently in the pas

[FYI] {master} tests: prefer "test ! -e FILE" to check that a file doesn't exist

2012-06-30 Thread Stefano Lattarini
* t/autohdrdry.sh: Here, rather than using "test ! -r FILE". Signed-off-by: Stefano Lattarini --- t/autohdrdry.sh |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/autohdrdry.sh b/t/autohdrdry.sh index 3bd474e..af6c198 100755 --- a/t/autohdrdry.sh +++ b/t/autohdrdry.sh @@

Re: [PATCH] mostly-clean/texi: remove $relative_dir/ prefix

2012-06-30 Thread Stefano Lattarini
On 06/30/2012 06:04 PM, Jim Meyering wrote: > > How about this? > > texi: clean up after texi2dvi --build-dir=... in $(SUBDIRS) > This would have been better, but I have already pushed the patch :-( Stefano

Re: [PATCH] mostly-clean/texi: remove $relative_dir/ prefix

2012-06-30 Thread Jim Meyering
Stefano Lattarini wrote: > On 06/30/2012 01:53 PM, Jim Meyering wrote: >> Hi Stefano, >> > Hi Jim, thanks for the report and patch. > >> I found that the following patch is required at least >> for vc-dwim, where without it, "make distcheck" would >> fail due to the presence of vc-dwim.t2d/ and all

Re: [PATCH] mostly-clean/texi: remove $relative_dir/ prefix

2012-06-30 Thread Stefano Lattarini
On 06/30/2012 01:53 PM, Jim Meyering wrote: > Hi Stefano, > Hi Jim, thanks for the report and patch. > I found that the following patch is required at least > for vc-dwim, where without it, "make distcheck" would > fail due to the presence of vc-dwim.t2d/ and all of the > files in that directory:

Re: [RFC] recursion: support user-defined recursive targets

2012-06-30 Thread Stefano Lattarini
Hi Dave, thanks for the feedback. On 06/30/2012 12:54 PM, Dave Hart wrote: > On Sat, Jun 30, 2012 at 08:56 UTC, Stefano Lattarini wrote: >> And here is the documentation, basically adapted from the commit message. >> >> Comments welcome. >> >> Regards, >> Stefano >> >> -*-*-*- >> >> diff --git a/

[PATCH] mostly-clean/texi: remove $relative_dir/ prefix

2012-06-30 Thread Jim Meyering
Hi Stefano, I found that the following patch is required at least for vc-dwim, where without it, "make distcheck" would fail due to the presence of vc-dwim.t2d/ and all of the files in that directory: they would not be removed because the rule was running "rm -rf doc/vc-dwim.t2d" from within the

[FYI] Merge branch 'maint' into mastet

2012-06-30 Thread Stefano Lattarini
commit e2f007f0c78e011c5fab60bfad332f6aad0989f1 Merge: 8c78465 9238349 Author: Stefano Lattarini Date: Sat Jun 30 13:42:10 2012 +0200 Merge branch 'maint' * maint: tests: fix a spurious failure configure: fix detection of POSIX shell to work in a VPATH build tests: pr

[FYI] Merge branch 'maint' into master

2012-06-30 Thread Stefano Lattarini
commit 8c784651a7da7dc85bd989e75ce63e35762ce27f Merge: 5d99776 e857a8e Author: Stefano Lattarini Date: Thu Jun 28 23:35:18 2012 +0200 Merge branch 'maint' * maint: configure: move a misplaced "section" comment configure: clump check for ${var%...} and ${var#...} expansion t

Re: [RFC] recursion: support user-defined recursive targets

2012-06-30 Thread Dave Hart
On Sat, Jun 30, 2012 at 08:56 UTC, Stefano Lattarini wrote: > And here is the documentation, basically adapted from the commit message. > > Comments welcome. > > Regards, >  Stefano > > -*-*-*- > > diff --git a/doc/automake.texi b/doc/automake.texi > index 87776b3..2bddc15 100644 > --- a/doc/automa

[FYI] {maint} tests: fix a spurious failure

2012-06-30 Thread Stefano Lattarini
* t/parallel-tests-dry-run-2.sh: Here. Signed-off-by: Stefano Lattarini --- t/parallel-tests-dry-run-2.sh |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/t/parallel-tests-dry-run-2.sh b/t/parallel-tests-dry-run-2.sh index 8e1e51e..01ff3e1 100755 --- a/t/parallel-test

Re: [PATCH] {maint} tests: prefer "test ! -e FILE" to check that a file doesn't exist

2012-06-30 Thread Stefano Lattarini
On 06/29/2012 12:49 AM, Stefano Lattarini wrote: > Once, for the sake of (at least) Solaris 10 /bin/sh, we had to use > "test ! -f FILE" or "test ! -r FILE" or "test ! -d FILE" instead, > because the that shell's 'test' built-in didn't grok the '-e' option. > > Note however that we still can't use

[FYI] {maint} configure: fix detection of POSIX shell to work in a VPATH build

2012-06-30 Thread Stefano Lattarini
* configure.ac: When checking whether "test -e" works, use 'config.log', not 'configure', as the witness file, because the latter does not exist in the current directory during a VPATH build. Signed-off-by: Stefano Lattarini --- configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(

Re: [RFC] recursion: support user-defined recursive targets

2012-06-30 Thread Stefano Lattarini
On 06/29/2012 07:46 PM, Stefano Lattarini wrote: > The user can now define his own recursive targets that recurse > in the directories specified in $(SUBDIRS). That can be done by > specifying the name of such targets in invocations of the new > 'AM_EXTRA_RECURSIVE_TARGETS' m4 macro. > > The API