Re: [FYI] configure: the testsuite shell must support 'test -e' and 'test ! -e'

On Thu, Jun 28, 2012 at 20:49 UTC, Stefano Lattarini wrote: > * configure.ac: Require that the shell that is to be selected to run > the testsuite understands "set -e" and "set ! -e". You mean test, not set. > Signed-off-by: Stefano Lattarini > --- >  configure.ac |    5 + >  1 file changed,

[FYI] Merge branch 'maint' into master

commit 8c784651a7da7dc85bd989e75ce63e35762ce27f Merge: 5d99776 e857a8e Author: Stefano Lattarini Date: Thu Jun 28 23:35:18 2012 +0200 Merge branch 'maint' * maint: configure: move a misplaced "section" comment configure: clump check for ${var%...} and ${var#...} expansion t

[FYI] {maint} configure: move a misplaced "section" comment

* configure.ac (Create output files): This, move it towards the end of the script. Signed-off-by: Stefano Lattarini --- configure.ac |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index 586c78e..a23b2ac 100644 --- a/configure.ac +++ b/c

[FYI] {maint} configure: clump check for ${var%...} and ${var#...} expansion together

And together with those for the ${var%%...} and ${var##...} expansions. After all, it is basically impossible to find a shell that support one of them but not the others. Suggestion by Eric Blake. * configure.ac: Here. Signed-off-by: Stefano Lattarini --- configure.ac | 23 ++

[FYI] {maint} cosmetics: improve wording of a couple of configure messages

* configure.ac: Fix a couple of messages so that the configure output changes from this: checking whether /bin/sh "set -e" preserves exit traps... yes checking whether /bin/sh "set -x" corrupts stderr... no to this: checking whether /bin/sh preserves exit traps with "set -e"... yes

[FYI] configure: the testsuite shell must support 'test -e' and 'test ! -e'

* configure.ac: Require that the shell that is to be selected to run the testsuite understands "set -e" and "set ! -e". Signed-off-by: Stefano Lattarini --- configure.ac |5 + 1 file changed, 5 insertions(+) diff --git a/configure.ac b/configure.ac index 79efc41..04658a5 100644 --- a/co

[FYI] {maint} tests: remove stale workarounds for Solaris /bin/sh

Our testsuite cannot be run with that shell anymore (as it is not POSIX-compliant). * t/tap-more.sh: Remove outdated workarounds for Solaris /bin/sh. * t/self-check-exit.tap: Likewise. * t/ansi2knr-no-more.sh: Likewise. * t/add-missing.tap: Likewise. * t/dist-auxfile.sh: Likewise. * t/test-driver-

[FYI] Merge branch 'maint' into master

commit 5d99776ce05b7a954ccf30d7ed666494c0db4e91 Merge: 60a6937 0732160 Author: Stefano Lattarini Date: Thu Jun 28 18:38:02 2012 +0200 Merge branch 'maint' * maint: tests init: don't bother allowing '$me' to be overridable tests init: typofixes in comments Signed-off-by

[FYI] {maint} tests init: don't bother allowing '$me' to be overridable

We once used that feature in our wrapper tests; but now (and probably even since commit 'v1.11-1308-g375f23d' of 2011-09-08, "testsuite: revamp generation of autogenerated tests") it is not needed anymore. By removing it we can simplify our growingly complex testsuite framework a little. * t/ax/te

[FYI] {maint} tests init: typofixes in comments

Signed-off-by: Stefano Lattarini --- t/ax/test-init.sh |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/ax/test-init.sh b/t/ax/test-init.sh index a414e14..83fe6eb 100644 --- a/t/ax/test-init.sh +++ b/t/ax/test-init.sh @@ -1003,7 +1003,7 @@ else test -d t || mkdir t m

Re: [FYI] Merge branch 'maint' into master

On 06/28/2012 05:33 PM, Stefano Lattarini wrote: > commit d6fc7de66b505f1667918cb894de5fe45a257339 > Merge: b21d686 de20404 > Author: Stefano Lattarini > Date: Thu Jun 28 17:15:29 2012 +0200 > > Merge branch 'maint' > > * maint: > tests: don't skip if $(abs_builddir) or $(abs_src

[FYI] {maint} tests: one test was not executable, make it so

* t/subdir-order.sh: This test. Signed-off-by: Stefano Lattarini --- 0 files changed mode change 100644 => 100755 t/subdir-order.sh diff --git a/t/subdir-order.sh b/t/subdir-order.sh old mode 100644 new mode 100755 -- 1.7.9.5

[FYI] Merge branch 'maint' into master

commit d6fc7de66b505f1667918cb894de5fe45a257339 Merge: b21d686 de20404 Author: Stefano Lattarini Date: Thu Jun 28 17:15:29 2012 +0200 Merge branch 'maint' * maint: tests: don't skip if $(abs_builddir) or $(abs_srcdir) contain whitespace tests: avoid spurious maintainer-chec

[FYI] {maint} tests: don't skip if $(abs_builddir) or $(abs_srcdir) contain whitespace

We used to explicitly skip libtool and gettext tests if the absolute path of the builddir or of the srcdir which Automake was configured with contained any whitespace (or other metacharacters). But several other tests would spuriously fail in such an unholy setup. To be precise, it would cause 61

[FYI] {maint} tests: avoid spurious maintainer-check failures

* t/ax/test-init.sh: Here, by adding extra quoting for two occurrences of the string "perl". Signed-off-by: Stefano Lattarini --- t/ax/test-init.sh |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/t/ax/test-init.sh b/t/ax/test-init.sh index 24945b6..dce60e9 100644 ---

[FYI] {maint} tests: remove obsolete hacks around maintainer-check false positives

* gen-testsuite-part, t/test-trs-recover.sh: Here. Signed-off-by: Stefano Lattarini --- gen-testsuite-part|4 ++-- t/test-trs-recover.sh |5 ++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/gen-testsuite-part b/gen-testsuite-part index 0021362..25da45c 100755 ---

Re: [PATCH] {maint} tests: simpler workaround for shells losing the exit status in exit trap

On 06/24/2012 08:32 PM, Stefano Lattarini wrote: > On 06/24/2012 03:08 PM, Stefano Lattarini wrote: >> Now that we can assume our tests are run by a decent POSIX shell, we >> can simplify our workaround aimed at having the exit status propagated >> correctly to the code in the exit trap. Unfortuna

[FYI] {master} cosmetics: remove trailing whitespace in some files

* lib/missing, t/comment7.sh, t/objc-flags.sh, t/objcxx-flags.sh, t/perf/testsuite-summary.sh, t/self-check-explicit-skips.sh: Here. Prompted by a report from Karl Berry. Signed-off-by: Stefano Lattarini --- lib/missing|2 +- t/comment7.sh |2 +- t/o

[FYI] {master} coverage: enhance tests in 'missing' script a little

* t/am-missing-prog.sh: Here, by also verifying its expected exit status. Signed-off-by: Stefano Lattarini --- t/am-missing-prog.sh |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/t/am-missing-prog.sh b/t/am-missing-prog.sh index a3e0cac..00d8e37 100755 --- a/t/am-missi

[FYI] Merge branch 'maint' into master

commit 27478539b094a2b0bee4f8a452bec552edcabdbe Merge: b4b6a1a 78900b9 Author: Stefano Lattarini Date: Thu Jun 28 10:59:45 2012 +0200 Merge branch 'maint' * maint: coverage: tests AM_MISSING_PROG usage docs: document AM_MISSING_PROG Signed-off-by: Stefano Lattarini

Re: bug#11793: [PATCH] docs: document AM_MISSING_PROG

tags 11793 patch close 1173 thanks Hi Eric, thanks for the patch. On 06/27/2012 11:55 PM, Eric Blake wrote: > Addresses automake bug#11793. > > This macro has been present for a long time, and coreutils has been > relying on it despite no documentation, which argues that it is stable > enough to

Re: bug#11793: AM_MISSING_PROG undocumented

On 06/28/2012 12:01 AM, Eric Blake wrote: > On 06/26/2012 04:56 PM, Stefano Lattarini wrote: > AM_MISSING_PROG has been around for a while (git log says it was introduced in 1997, although the current two-argument version appears to date back to commit 9ae48df in Nov 1999), and seem