On Fri, Jun 22, 2012 at 10:13 PM, Stefano Lattarini
wrote:
> * t/ax/test-init.sh (me): In the definition of this variable. This
> also shave off a couple of forks, and the need for a sanity check
s/shave/shaves/
s/and the/and removes the/
Otherwise, it looks good.
Cheers,
Dave Hart
On 06/23/2012 10:39 AM, Dave Hart wrote:
>
> Looks like a nice improvement, thanks.
>
Glad you like it. I will push by tomorrow if there is no further feedback.
Thanks,
Stefano
* defs: Use '$argv0' instead of '$0'. With Zsh not started right
away in Bourne-compatibility mode, the latter will be the path not
of the test script itself, but of the file it's currently sourcing
-- i.e., in our case, './defs'. This would cause the automatic
re-execution code to execute './def
Hi Dave, thanks for the review.
On 06/23/2012 11:46 AM, Dave Hart wrote:
>
> [SNIP]
>
First of all, I've fixed all the nits you have pointed out, along your
suggestions. Thanks.
>
> Which released version numbers of Automake had the just-fixed Zsh
> compatibility bug?
>
Automake 1.12.
> I am t
On Sat, Jun 23, 2012 at 9:19 AM, Stefano Lattarini
wrote:
> * defs-static.in: Here. The fact that such support has been broken for
> almost an year (only fixed by today's commit 'v1.12.1-57-gf1e0300'),
s/an/a/
> causing no bug reports from anyone, shows that such support is not truly
> warrante
On 06/23/2012 11:19 AM, Stefano Lattarini wrote:
> * defs-static.in: Here. The fact that such support has been broken for
> almost an year (only fixed by today's commit 'v1.12.1-57-gf1e0300'),
> causing no bug reports from anyone, shows that such support is not truly
> warranted. And it will get
* defs-static.in: Here. The fact that such support has been broken for
almost an year (only fixed by today's commit 'v1.12.1-57-gf1e0300'),
causing no bug reports from anyone, shows that such support is not truly
warranted. And it will get in the way of future improvements in the
handling of the
* defs-static.in: Here. This will make it easier for the maintainer
to run some self checks (like those in 't/self-check-exit.tap') with
different shells, to look for possible portability problems. Fix a
typo (doubled "the") while we are at it.
Signed-off-by: Stefano Lattarini
---
defs-static.
On Sat, Jun 23, 2012 at 07:17 UTC, Stefano Lattarini wrote:
> * lib/missing: Try to point the user to the home page of such tools
> where possible. Also, make clear that some tools (e.g., aclocal or
> autoheader) are distributed as part of bigger projects (resp. automake
> and autoconf, in those c
* defs-static.in: After the addition of TAP-based tests and our renaming
of "simple" test scripts from 'tests/foo.test' to 't/foo.sh', a test name
is valid if it matches the wildcard "*.sh" or "*.tap", not the wildcard
"*.test". Adjust accordingly.
Signed-off-by: Stefano Lattarini
---
defs-stat
* lib/missing: Try to point the user to the home page of such tools
where possible. Also, make clear that some tools (e.g., aclocal or
autoheader) are distributed as part of bigger projects (resp. automake
and autoconf, in those cases). While at it, refactor and re-format
the existing code heavil
11 matches
Mail list logo
