Re: [PATCH 5/5] tests: fix a spurious failure with dash

On 05/07/2012 07:27 PM, Eric Blake wrote: > > Does the autoconf testsuite suffer from any of the same > assumptions about being able to trigger a syntax error? > No idea. sorry (and I won't have time to take a look anytime soon). Stefano

Re: [PATCH 3/5] tests: remove obsolete uses of $sh_errexit_works

On 05/07/2012 07:17 PM, Eric Blake wrote: > On 05/01/2012 10:04 AM, Stefano Lattarini wrote: >> After the last changes, configure will ensure that the shell >> selected to run the test scripts can correctly propagate exit >> status to the exit trap when 'set -e' is in effect. >> >> * configure.ac (

Re: [PATCH 2/5] configure: search a sturdy POSIX shell to be used in the testsuite

On 05/07/2012 05:37 PM, Eric Blake wrote: > On 05/01/2012 10:04 AM, Stefano Lattarini wrote: >> * configure.ac: Add code (partially inspired to checks in gnulib's >> 'tests/init.sh') to search for a good-enough, not-buggy POSIX/XSI >> shell to be used in our testsuite. Accordingly AC_SUBSTitute th

Re: [PATCH 1/5] tests: shell running test scripts is now named AM_TEST_RUNNER_SHELL

Hi Eric, thank you very much for the review. On 05/07/2012 04:34 PM, Eric Blake wrote: > On 05/01/2012 10:04 AM, Stefano Lattarini wrote: >> This is just a preparatory refactoring for future changes. > > Sorry for my delay in reviewing; I'm now looking at this series. > >> >> * configure.ac (AM_

Re: [PATCH 5/5] tests: fix a spurious failure with dash

On 05/01/2012 10:04 AM, Stefano Lattarini wrote: > The dash shell, at least version 0.5.5.1, doesn't always bail out > with a syntax error when a stray "fi" in encountered: > > $ dash -c ":; fi"; echo stat = $? > stat = 0 > > See also the relevant bug report: > >

Re: [PATCH 4/5] test defs: fix indentation (cosmetic change)

On 05/01/2012 10:04 AM, Stefano Lattarini wrote: > * defs (exit trap): Fix indentation left botched by previous > patch 'v1.11b-51-g626bf65'. > > Signed-off-by: Stefano Lattarini > --- > defs | 113 > +- > 1 file changed, 56 inser

Re: [PATCH 3/5] tests: remove obsolete uses of $sh_errexit_works

On 05/01/2012 10:04 AM, Stefano Lattarini wrote: > After the last changes, configure will ensure that the shell > selected to run the test scripts can correctly propagate exit > status to the exit trap when 'set -e' is in effect. > > * configure.ac (sh_errexit_works): Do not AC_SUBST it anymore. >

Re: [PATCH 2/5] configure: search a sturdy POSIX shell to be used in the testsuite

On 05/01/2012 10:04 AM, Stefano Lattarini wrote: > * configure.ac: Add code (partially inspired to checks in gnulib's > 'tests/init.sh') to search for a good-enough, not-buggy POSIX/XSI > shell to be used in our testsuite. Accordingly AC_SUBSTitute the > variable 'AM_TEST_RUNNER_SHELL'. > * NEWS:

Re: [PATCH 1/5] tests: shell running test scripts is now named AM_TEST_RUNNER_SHELL

On 05/01/2012 10:04 AM, Stefano Lattarini wrote: > This is just a preparatory refactoring for future changes. Sorry for my delay in reviewing; I'm now looking at this series. > > * configure.ac (AM_TEST_RUNNER_SHELL): New variable, defined > to $SHEL', and AC_SUBST'd. s/SHEL/SHELL/ > @@ -105,