Re: [PATCH 09/10] objc, objc++: add stress test

On Tue, 1 May 2012, Stefano Lattarini wrote: From: Peter Breitenlohner * t/objc-megademo.sh: New test, trying out a package using all of C, C++, Objective C and Objective C++ at the same time. * t/list-of-tests.mk: Add it. Hi Stefano, I have just noticed that in the source file foo.h +##

Re: [PATCH] {maint} aclocal: error out again on unrecognized arguments

On 05/01/2012 04:27 PM, Stefano Lattarini wrote: > HI Eric, thanks for the super-quick review. > > On 05/02/2012 12:18 AM, Eric Blake wrote: >> On 05/01/2012 04:14 PM, Stefano Lattarini wrote: >>> Starting from commit v1.11-662-g52246cc of XXX, "XXX", aclocal has >> >> Did you mean to fix the XXX?

Re: [PATCH] {maint} aclocal: error out again on unrecognized arguments

HI Eric, thanks for the super-quick review. On 05/02/2012 12:18 AM, Eric Blake wrote: > On 05/01/2012 04:14 PM, Stefano Lattarini wrote: >> Starting from commit v1.11-662-g52246cc of XXX, "XXX", aclocal has > > Did you mean to fix the XXX? > Oops, I used a stale "git.msg" file when committing. F

Re: [PATCH] {maint} aclocal: error out again on unrecognized arguments

On 05/01/2012 04:14 PM, Stefano Lattarini wrote: > Starting from commit v1.11-662-g52246cc of XXX, "XXX", aclocal has Did you mean to fix the XXX? > been silently ignoring non-option arguments instead of correctly > reporting them. Fix this regression. > > > +* Bugs introduced by 1.11.3: > +

[PATCH] {maint} aclocal: error out again on unrecognized arguments

Starting from commit v1.11-662-g52246cc of XXX, "XXX", aclocal has been silently ignoring non-option arguments instead of correctly reporting them. Fix this regression. * t/aclocal.sh: Update to catch the regression. * aclocal.in (parse_arguments): Explicitly reject non-option arguments. * NEWS:

Re: [PATCH 0/5] Convert automake testsuite to the use of a POSIX shell

Hi Eric. On 05/01/2012 06:18 PM, Eric Blake wrote: > On 05/01/2012 10:04 AM, Stefano Lattarini wrote: >> This patches are the first step in that direction. I will push in 72 hours >> if there is no objection. > > Heads up - I'd like to review this series closely, but am not sure I > will finish

Re: [PATCH 0/5] Convert automake testsuite to the use of a POSIX shell

On 05/01/2012 10:04 AM, Stefano Lattarini wrote: > This patches are the first step in that direction. I will push in 72 hours > if there is no objection. Heads up - I'd like to review this series closely, but am not sure I will finish my review in 72 hours. Just so I know what to look for - is t

Re: [trivial PATCH] Fix typo in aclocal m4 directory README

On Tue, May 01, 2012 at 05:11:13PM +0200, Stefano Lattarini wrote: > On 05/01/2012 04:18 PM, Andrew Eikum wrote: > > Signed-off-by: Andrew Eikum > > > > Noticed this while poking around the system today. > > > > m4/acdir/README |2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > >

[PATCH] init: warn against obsolete usage of AM_INIT_AUTOMAKE

Support for the two- and three-arguments invocation forms of the AM_INIT_AUTOMAKE macro, as in: AM_INIT_AUTOMAKE($PACKAGE, $VERSION) or: AM_INIT_AUTOMAKE($PACKAGE, $VERSION, NODEFINE) will be removed in the next major Automake release (1.13). Such usages have already been deprecated in the

[PATCH 4/5] test defs: fix indentation (cosmetic change)

* defs (exit trap): Fix indentation left botched by previous patch 'v1.11b-51-g626bf65'. Signed-off-by: Stefano Lattarini --- defs | 113 +- 1 file changed, 56 insertions(+), 57 deletions(-) diff --git a/defs b/defs index 4c1e40d.

[PATCH 5/5] tests: fix a spurious failure with dash

The dash shell, at least version 0.5.5.1, doesn't always bail out with a syntax error when a stray "fi" in encountered: $ dash -c ":; fi"; echo stat = $? stat = 0 See also the relevant bug report: This behaviour was causing a spuriou

[PATCH 3/5] tests: remove obsolete uses of $sh_errexit_works

After the last changes, configure will ensure that the shell selected to run the test scripts can correctly propagate exit status to the exit trap when 'set -e' is in effect. * configure.ac (sh_errexit_works): Do not AC_SUBST it anymore. * defs-static.in (sh_errexit_works): Do not initialize from

[PATCH 1/5] tests: shell running test scripts is now named AM_TEST_RUNNER_SHELL

This is just a preparatory refactoring for future changes. * configure.ac (AM_TEST_RUNNER_SHELL): New variable, defined to $SHEL', and AC_SUBST'd. * Makefile.am (LOG_COMPILER): Redefine from $(SHELL) to $(AM_TEST_RUNNER_SHELL). * defs: Adjust to use $AM_TEST_RUNNER_SHELL instead of $CONFIG_SHELL a

[PATCH 2/5] configure: search a sturdy POSIX shell to be used in the testsuite

* configure.ac: Add code (partially inspired to checks in gnulib's 'tests/init.sh') to search for a good-enough, not-buggy POSIX/XSI shell to be used in our testsuite. Accordingly AC_SUBSTitute the variable 'AM_TEST_RUNNER_SHELL'. * NEWS: Update. Signed-off-by: Stefano Lattarini --- NEWS

[PATCH 0/5] Convert automake testsuite to the use of a POSIX shell

This patches are the first step in that direction. I will push in 72 hours if there is no objection. Stefano Lattarini (5): tests: shell running test scripts is now named AM_TEST_RUNNER_SHELL configure: search a sturdy POSIX shell to be used in the testsuite tests: remove obsolete uses of $

Re: [trivial PATCH] Fix typo in aclocal m4 directory README

On 05/01/2012 05:41 PM, Andrew Eikum wrote: > On Tue, May 01, 2012 at 05:11:13PM +0200, Stefano Lattarini wrote: >> On 05/01/2012 04:18 PM, Andrew Eikum wrote: >>> Signed-off-by: Andrew Eikum >>> >>> Noticed this while poking around the system today. >>> >>> m4/acdir/README |2 +- >>> 1 file

Re: [trivial PATCH] Fix typo in aclocal m4 directory README

Hi Andrew. On 05/01/2012 04:18 PM, Andrew Eikum wrote: > Signed-off-by: Andrew Eikum > > Noticed this while poking around the system today. > > m4/acdir/README |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > I've applied the patch in your name, adding you to THANKS (and tweaking

[trivial PATCH] Fix typo in aclocal m4 directory README

Signed-off-by: Andrew Eikum --- Noticed this while poking around the system today. m4/acdir/README |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/m4/acdir/README b/m4/acdir/README index c2bf903..7c6f487 100644 --- a/m4/acdir/README +++ b/m4/acdir/README @@ -5,5 +5,5 @@

Re: [FYI] {maint} silent rules: support for them is always active now

On 05/01/2012 04:05 PM, Stefano Lattarini wrote: > > [FYI] {maint} silent rules: support for them is always active now > Oops, wrong, this was *not* an FYI: I haven't pushed the patch yet, and I'd love a review before I do so. Sorry for the noise, Stefabi

[FYI] {maint} silent rules: support for them is always active now

Before this change, support for silent rules was optional and activated only if the 'silent-rules' option was specified. The rationale behind that behaviour was that the silent-rules machinery originally only worked with make implementations supporting nested variables expansions, which isn't (or

[PATCH 10/10] objc, objc++: test support for compilation flags

* t/objc-flags.sh, t/objcxx-flags.sh: New tests. * t/list-of-tests.mk: Add them. Co-authored-by: Peter Breitenlohner Signed-off-by: Stefano Lattarini --- t/list-of-tests.mk |2 ++ t/objc-flags.sh| 62 t/objcxx-flags.sh | 72 +

[PATCH 09/10] objc, objc++: add stress test

From: Peter Breitenlohner * t/objc-megademo.sh: New test, trying out a package using all of C, C++, Objective C and Objective C++ at the same time. * t/list-of-tests.mk: Add it. Signed-off-by: Stefano Lattarini --- t/list-of-tests.mk |1 + t/objc-megademo.sh | 364

[PATCH 08/10] objc, objc++: test automatic dependency tracking

* t/objc-deps.sh, t/objcxx-deps.sh: New tests. * t/list-of-tests.mk: Add them. Signed-off-by: Stefano Lattarini --- t/list-of-tests.mk |2 ++ t/objc-deps.sh | 72 ++ t/objcxx-deps.sh | 81 ++

[PATCH 06/10] objc++, objc: add first semantic tests

* t/objcxx-minidemo.sh: New test. * t/objc-minidemo.sh: Likewise. * t/list-of-tests.mk: Add them. Co-authored-by: Peter Breitenlohner Signed-off-by: Stefano Lattarini --- t/list-of-tests.mk |2 ++ t/objc-minidemo.sh | 76 + t/objcxx-mini

[PATCH 07/10] objc: reorganize basic tests

* t/objc.sh, t/objc2.sh: Removed, merged into ... * t/objc-basic.sh: ... this new test. * t/objcxx-basic.sh: Add reference to new sister test. * t/list-of-tests.mk: Update. Signed-off-by: Stefano Lattarini --- t/list-of-tests.mk|3 +-- t/{objc2.sh => objc-basic.sh} | 25 +++

[PATCH 05/10] objc++: add first basic test

From: Peter Breitenlohner * t/objcxx-basic.sh: New test. * t/list-of-tests.mk: Add it. Signed-off-by: Peter Breitenlohner Signed-off-by: Stefano Lattarini --- t/list-of-tests.mk |1 + t/objcxx-basic.sh | 46 ++ 2 files changed, 47 insertions(

[PATCH 04/10] news: announce initial support for Objective C++

Signed-off-by: Stefano Lattarini --- NEWS |5 + 1 file changed, 5 insertions(+) diff --git a/NEWS b/NEWS index b415be6..7d0abcd 100644 --- a/NEWS +++ b/NEWS @@ -7,6 +7,11 @@ New in 1.12.1: m4 macro are deprecated, eliciting a warning in the 'obsolete' category. They will be re

[PATCH 03/10] objc++: test support for '.mm' suffix in _SOURCES entries

From: Peter Breitenlohner * t/ext.sh: Enhance by adding a file with the '.mm' suffix in the 'foo_SOURCES' definition. * t/nodep2.sh: Likewise. Co-authored-by: Stefano Lattarini Signed-off-by: Peter Breitenlohner Signed-off-by: Stefano Lattarini --- t/ext.sh| 10 -- t/nodep2.sh

[PATCH 02/10] objc++: add documentation

From: Peter Breitenlohner * doc/automake.texi (Objective C++ Support): New node. (How the Linker is Chosen, Support for Other Languages): Adjust. Signed-off-by: Peter Breitenlohner Signed-off-by: Stefano Lattarini --- doc/automake.texi | 57 ++

[PATCH 01/10] objc++: initial support for Objective C++

From: Peter Breitenlohner Original thread (dating back to almost three years ago): * automake.in: Register new language 'objcxx'. (lang_objcxx_rewrite): New subroutine. (resolve_linker): Add OBJCXXLINK. (%_am_macro_for_co

[PATCH 00/10] Add support for Objective C++ in Automake

Original recent threads: Original old thread, going back to June 2009: wi

Re: [PATCH 1/6] objc++: test global, per-target, and user flags

Hi Peter, thanks for the patch. However, I've decided not to apply it as-is, but rather to go for a more semantic test (here and for the corresponding "objc" test as well). See attached patch. I will soon re-send the whole Objective C++ patch series (containing patches from you as well as from m

[FYI] {maint} fixup: botched edit in bootstrap.sh

* bootstrap.sh (dosubst): Fix botched option ("G" instead of "g") in a sed "s///" expression. Issue introduced in today's commit 'v1.12-17-g5f810d0'. Signed-off-by: Stefano Lattarini --- bootstrap.sh |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bootstrap.sh b/bootstrap

Re: [FYI] {maint} news: Automake 1.13 will require Autoconf >= 2.65

Hi Dave. On 05/01/2012 01:30 AM, Dave Hart wrote: > On Mon, Apr 30, 2012 at 19:45, Stefano Lattarini > wrote: >> + - Autoconf 2.65 or later will be required by the next major Automake >> +version (1.13). Until now, Automake has been working with any >> +Autoconf version up to 2.62. >> +

[FYI] {maint} news: fixed weaknesses in build system and testsuite

* NEWS (Bugs fixed in 1.12.1): Report that several weaknesses in the Automake's own build system and test suite have been fixed. See for example recent commits: - commit v1.12-5-geb7e8f3, for bug#11345 - commit v1.12-5-g63e07a9, for bug#11346 - commit v1.12-5-gf31fe4f - commit v1.12-10-gab

Re: bug#11356: automake 1.12 and (C) 2011

Hi Peter, thanks for the feedback. On 05/01/2012 02:23 AM, Peter Johansson wrote: > Hi Stefano, > > Sorry about this late reply. > > On 04/28/2012 12:34 AM, Stefano Lattarini wrote: > > --- a/bootstrap > +++ b/bootstrap > @@ -77,6 +77,8 @@ dosubst () > { >rm -f $2 >in=`echo $1 | sed 's

Re: bug#11356: automake 1.12 and (C) 2011

Hi Stefano, Sorry about this late reply. On 04/28/2012 12:34 AM, Stefano Lattarini wrote: --- a/bootstrap +++ b/bootstrap @@ -77,6 +77,8 @@ dosubst () { rm -f $2 in=`echo $1 | sed 's,^.*/,,'` + current_year=`date +%Y`&& test -n "$current_year" \ +|| { echo "$me: cannot get current