Re: bug#11093: [platform-testers] Automake 1.11.3b test release

2012-04-21 Thread Bruno Haible
Hi Stefano, > How to reproduce: > 1. Unpack automake-1.11d.tar.gz > 2. patch -p1 < > .../0001-vala-configure-exit-with-status-77-not-1-if-valac-ve.patch > 3. ./configure > 4. make I managed to work around this. The patch indeed causes the tests to be skipped, leading to: ... PASS: t/vala.sh val

Re: bug#11093: [platform-testers] Automake 1.11.3b test release

2012-04-21 Thread Bruno Haible
Stefano Lattarini wrote: > I think that the best fix would be to improve AM_PROG_VALAC to exit > with status '77' instead of '1' if the vala compiler found is too old; > so, what about the attached patch? Most importantly, would it fix > the failures you are seeing? The patch you sent does not ap

Re: bug#11093: [platform-testers] Automake 1.11.3b test release

2012-04-21 Thread Stefano Lattarini
Hi Bruno, thanks for the report. On 04/21/2012 02:54 PM, Bruno Haible wrote: > Hi Stefano, > > In Automake 1.11.3b I reported these: >>> FAIL: vala-vpath.test >>> FAIL: vala-mix.test >>> FAIL: vala-mix2.test >> >>> [SNIP] >> ... >>> Looking at git://git.gnome.org/vala it is clear that the option

Re: [PATCH] {master} automake: refactor pre-processing of makefile fragments

2012-04-21 Thread Stefano Lattarini
On 04/19/2012 10:14 PM, Stefano Lattarini wrote: > This change will provide the automake script with a new function that > reads in a Makefile fragment *without* performing Automake ad-hoc parsing, > but only the pre-processing step, i.e., removal of '##' comments and > substitution of tokens like

Re: [PATCH] refactor: processing of input makefile rules

2012-04-21 Thread Stefano Lattarini
On 04/20/2012 10:07 AM, Stefano Lattarini wrote: > This is a pure refactoring, with no intended functional or semantic > changes. It breaks up an overly-long function in three smaller > sub-functions. This change will very especially useful for the work > on Automake-NG. > > * lib/Automake/Rule.