Re: [FYI] {master} maint: assume 'test -x' is portable

2012-02-26 Thread Peter Rosin
Eric Blake skrev 2012-02-23 23:42: > On 02/23/2012 02:48 PM, Stefano Lattarini wrote: >> * lib/Makefile.am (installcheck-local): To verify that the installed >> scripts are actually executable, simply use 'test -x', instead of >> resorting to perl and its '-x' file operator. Today, 'test -x' >> sh

[PATCH] tests: avoid spurious failure (line too long in awk)

2012-02-26 Thread Stefano Lattarini
* tests/parallel-tests-many.test: Use perl, not awk, to write the Makefile.am with (deliberately) overly long TESTS content, as some inferior awk implementations (e.g., Solaris 10 /usr/bin/awk) are unable to handle the long lines used there and die with errors like: "awk: string too long near line

[FYI] {master} tests: avoid spurious failures when awk is "traditional awk"

2012-02-26 Thread Stefano Lattarini
* tests/Makefile.am (do_subst): Also substitute '@AWK@'. * tests/defs-static.in ($AWK): New, user-overridable and defaulting to the substituted '@AWK@'. * tests/defs (fetch_tap_driver): When the shell+awk implementation of the TAP driver is required, export AM_TAP_AWK to point to a properly capable

[FYI] {master} tests: avoid many spurious failures for shells with busted 'set -e'

2012-02-26 Thread Stefano Lattarini
Some versions of the BSD Korn shell wrongly bail out when the 'errexit' shell flag is active and the left-hand command in a "&&" list fails and that list is the *last* command of an entry in a "case" statement. * tests/defs (gcc, g++, gcj): Work around that. --- tests/defs |3 +++ 1 files cha

Re: bug#10791: aclocal fails if /usr/share/aclocal does not exist

2012-02-26 Thread Stefano Lattarini
On 02/22/2012 10:30 AM, Stefano Lattarini wrote: > > On 02/22/2012 10:25 AM, Tim Retout wrote: > >> Adding a README file will cause us problems if automake-1.11 and >> automake-1.12 (say) are installed on the same system - who owns the >> README? >> > Good point. Let's just drop my patch for now.

Re: [PATCH] hacking: document format for git commit messages

2012-02-26 Thread Jim Meyering
Stefano Lattarini wrote: > On 02/26/2012 10:02 AM, Stefano Lattarini wrote: >> >> - many other projects (linux, git itself) seems to use them, and I >> believe there's a reason for this (even if I've failed to find it >> so far); >> > Here it is -- point 12 at: > https://github.com/torval

Re: bug#10878: "make dist" with read-only srcdir generates read-only tarball

2012-02-26 Thread Stefano Lattarini
tags 10878 patch close 10878 thanks On 02/25/2012 08:25 PM, Stefano Lattarini wrote: > > I'll close this report by tomorrow if there are no further objection. > Bug closed. Thanks, Stefano

Re: [PATCH] hacking: document format for git commit messages

2012-02-26 Thread Stefano Lattarini
On 02/26/2012 10:02 AM, Stefano Lattarini wrote: > > - many other projects (linux, git itself) seems to use them, and I > believe there's a reason for this (even if I've failed to find it > so far); > Here it is -- point 12 at: https://github.com/torvalds/linux/blob/7ada1dd6/Documentation

Re: [PATCH] hacking: document format for git commit messages

2012-02-26 Thread Stefano Lattarini
On 02/26/2012 08:53 AM, Jim Meyering wrote: > Stefano Lattarini wrote: > >> On 02/25/2012 08:38 PM, Stefano Lattarini wrote: >>> >>> But I should definitely improve HACKING and have it document the >>> standards and best practice for commit logs (since the GCS are sadly >>> weak and out-of-date in