Re: [PATCH] tests: fix broken quoting in the generated yacc grammar

2012-02-17 Thread Stefano Lattarini
On 02/18/2012 12:11 AM, Peter Rosin wrote: > Stefano Lattarini skrev 2012-02-17 23:28: >> On 02/17/2012 10:15 PM, Peter Rosin wrote: >>> Fixes problem introduced by v1.11-1912-ge0906b7 "tests: avoid >>> spurious failure with non-bison yacc" from 12-02-2012. >>> >>> * tests/suffix10.tap (Makefile.am

Re: [PATCH] tests: fix broken quoting in the generated yacc grammar

2012-02-17 Thread Peter Rosin
Stefano Lattarini skrev 2012-02-17 23:28: > On 02/17/2012 10:15 PM, Peter Rosin wrote: >> Fixes problem introduced by v1.11-1912-ge0906b7 "tests: avoid >> spurious failure with non-bison yacc" from 12-02-2012. >> >> * tests/suffix10.tap (Makefile.am): Avoid outer single quotes >> when we need to pr

[FYI] {master} tests: avoid spurious failure with FreeBSD make

2012-02-17 Thread Stefano Lattarini
* tests/parallel-tests-extra-programs.test: FreeBSD make seems to write (some) diagnostic messages on stdout instead than on stderr, so now we also grep the stdout for the expected make diagnostic. --- tests/parallel-tests-extra-programs.test |6 -- 1 files changed, 4 insertions(+), 2 dele

Re: [PATCH] tests: fix broken quoting in the generated yacc grammar

2012-02-17 Thread Stefano Lattarini
On 02/17/2012 10:15 PM, Peter Rosin wrote: > Fixes problem introduced by v1.11-1912-ge0906b7 "tests: avoid > spurious failure with non-bison yacc" from 12-02-2012. > > * tests/suffix10.tap (Makefile.am): Avoid outer single quotes > when we need to produce single quotes. > --- > tests/suffix10.tap

[PATCH] tests: fix broken quoting in the generated yacc grammar

2012-02-17 Thread Peter Rosin
Fixes problem introduced by v1.11-1912-ge0906b7 "tests: avoid spurious failure with non-bison yacc" from 12-02-2012. * tests/suffix10.tap (Makefile.am): Avoid outer single quotes when we need to produce single quotes. --- tests/suffix10.tap |2 +- 1 files changed, 1 insertions(+), 1 deletions

[FYI] {master} fixup: always use correct path for automake/aclocal wrappers

2012-02-17 Thread Stefano Lattarini
Otherwise, bootstrapping from a git checkout won't work anymore. Issue introduced in today's commit 'v1.11-1974-ga98e58f'. * doc/Makefile.am ($(srcdir)/amhello-1.0.tar.gz): Export PATH in a way that makes the automake and aclocal wrappers truly accessible (the location of this wrappers has been mo

[FYI] {master} tests: fix spurious failure in VPATH build

2012-02-17 Thread Stefano Lattarini
* tests/self-check-dir.tap: Adjust to handle running in a VPATH build correctly. --- tests/self-check-dir.tap |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/self-check-dir.tap b/tests/self-check-dir.tap index 39bf38c..1a5d6b4 100755 --- a/tests/self-check-dir.tap +

[FYI] {master} tests: fix spurious failure with VPATH builds

2012-02-17 Thread Stefano Lattarini
The 'is' helper script, used by some test cases since commit 'v1.11-1830-g96401cb' of 08-02-2012, "tests: better way to compare lists in Makefile rules", is not available in VPATH builds, since it resides in $(srcdir), nor in $(builddir), and only $(builddir) is added to $PATH in the test script.

[FYI] {master} tests: relax a test to cater to NetBSD make

2012-02-17 Thread Stefano Lattarini
* tests/parallel-tests-empty-testlogs.test: When $(TESTS) is empty, NetBSD 5.1 make ends up defining $(TESTS_LOGS) to ".log" rather than to the empty string (as would be expected). This behaviour was causing a check in this test case to fail. But that check was in fact overly strict, since our re

Re: [PATCHES] Fix issues with $(am__dry_run) and metacharacters in $(MAKEFLAGS)

2012-02-17 Thread Stefano Lattarini
Hi Peter. On 02/17/2012 12:54 PM, Peter Rosin wrote: > Stefano Lattarini skrev 2012-02-17 12:00: >> Two patches: a fix to be applied to maint, and a testsuite enhancement to >> be applied to master. >> >> Tested with GNU make from 3.79 to 3.82, FreeBSD 9.0 make, OpenBSD 5.0 make, >> NetBSD 5.1 mak

[FYI] {master} tests: TAP-based tests should error if no plan was specified

2012-02-17 Thread Stefano Lattarini
After this change, it will still be OK for TAP-based tests not to report any explicit TAP plan -- but they should state *explicitly* that they want to do so, by calling the 'plan_' function with a proper argument (currently, either "later" or "unknonwn"). Motivated by a recent issue introduced by

Re: [PATCHES] Fix issues with $(am__dry_run) and metacharacters in $(MAKEFLAGS)

2012-02-17 Thread Peter Rosin
Stefano Lattarini skrev 2012-02-17 12:00: > Two patches: a fix to be applied to maint, and a testsuite enhancement to > be applied to master. > > Tested with GNU make from 3.79 to 3.82, FreeBSD 9.0 make, OpenBSD 5.0 make, > NetBSD 5.1 make, Solaris 10 CCS make and Sun Distributed Make 7.8. > > I

[PATCHES] Fix issues with $(am__dry_run) and metacharacters in $(MAKEFLAGS)

2012-02-17 Thread Stefano Lattarini
Two patches: a fix to be applied to maint, and a testsuite enhancement to be applied to master. Tested with GNU make from 3.79 to 3.82, FreeBSD 9.0 make, OpenBSD 5.0 make, NetBSD 5.1 make, Solaris 10 CCS make and Sun Distributed Make 7.8. I will push soonish if there is no objection. Regards,

Re: [PATCH] maint: support amending the generated ChangeLog, and fix a typo

2012-02-17 Thread Peter Rosin
Peter Rosin skrev 2012-02-17 10:16: > Peter Rosin skrev 2012-02-17 10:09: >> Anyway, I pushed the below to master. > > I have also followed up with the below fixup. I forgot that actually > commit the amend I had already done, sorry for the noise. This is just bad. I'm following up again.

Re: [PATCH] maint: support amending the generated ChangeLog, and fix a typo

2012-02-17 Thread Peter Rosin
Peter Rosin skrev 2012-02-17 10:09: > Anyway, I pushed the below to master. I have also followed up with the below fixup. I forgot that actually commit the amend I had already done, sorry for the noise. Cheers, Peter >From 22729165f6bb902daeb8a4d8e7cb06982390f327 Mon Sep 17 00:00:00 2001 From:

Re: [PATCH] maint: support amending the generated ChangeLog, and fix a typo

2012-02-17 Thread Peter Rosin
Stefano Lattarini skrev 2012-02-17 09:33: > On 02/17/2012 08:55 AM, Peter Rosin wrote: >> * Makefile.am (gitlog_to_changelog_options): Add support for >> amending the generated ChangeLog. >> * lib/git-log-fix: New file with things to amend to the generated >> ChangeLog, starting with a fix for a ty

Re: [PATCH] maint: support amending the generated ChangeLog, and fix a typo

2012-02-17 Thread Stefano Lattarini
On 02/17/2012 08:55 AM, Peter Rosin wrote: > * Makefile.am (gitlog_to_changelog_options): Add support for > amending the generated ChangeLog. > * lib/git-log-fix: New file with things to amend to the generated > ChangeLog, starting with a fix for a typo in v1.11-1963-g3b369e6 > from yesterday. > --