Re: [PATCH] {master} depcomp tests: avoid redundant runs for libtool tests

2012-02-08 Thread Peter Rosin
Stefano Lattarini skrev 2012-02-08 22:16: > When running libtool-oriented tests, our 'depcomp.sh' script used > to run the same checks thrice: once after having run configure > with the '--disable-shared' option, once after having run it with > the '--enable-shared' option, and once by allowing con

Re: [PATCH] tests: check if 'compress' is real of fake

2012-02-08 Thread Peter Rosin
Peter Rosin skrev 2012-02-08 22:24: > On Cygwin, 'compress' is provided by sharutils and is just a > dummy script that is not able to actually compress (it can > only decompress). This fake 'compress' is not usable for > our purpose - to create compressed tarballs. > > * tests/dist-formats.tap (m

[PATCH] tests: check if 'compress' is real of fake

2012-02-08 Thread Peter Rosin
On Cygwin, 'compress' is provided by sharutils and is just a dummy script that is not able to actually compress (it can only decompress). This fake 'compress' is not usable for our purpose - to create compressed tarballs. * tests/dist-formats.tap (missing_compressors): Count 'compress' as missing

Re: [PATCH] depcomp: recognize tabs as whitespace in the dashmstdout mode

2012-02-08 Thread Stefano Lattarini
On 02/08/2012 03:19 PM, Peter Rosin wrote: > > Thanks! > > Pushed, as Eric already seemed in favor of keeping scriptversion linear. > Yes, I've stalled the "$scriptversion removal plan" for the moment. And anyway, that plan shouldn't have affected any of your patches: I would have implemented it

Re: [PATCH] depcomp: recognize tabs as whitespace in the dashmstdout mode

2012-02-08 Thread Peter Rosin
Stefano Lattarini skrev 2012-02-08 15:07: > On 02/08/2012 02:58 PM, Jim Meyering wrote: >> Peter Rosin wrote: >>> This thread has stalled. To sum things up and get things going again, >>> the following is what I'd like to do. First commit the three patches >>> (that are replies to this message) o

Re: [PATCH] depcomp: recognize tabs as whitespace in the dashmstdout mode

2012-02-08 Thread Stefano Lattarini
On 02/08/2012 02:58 PM, Jim Meyering wrote: > Peter Rosin wrote: >> This thread has stalled. To sum things up and get things going again, >> the following is what I'd like to do. First commit the three patches >> (that are replies to this message) on the msvc branch. Then merge msvc >> into mast

[FYI] {master} depcomp tests: avoid spurious failures with 'dashXmstdout' depmode

2012-02-08 Thread Stefano Lattarini
* tests/gen-testsuite-part: The 'dashXmstdout' depmode cannot be truly forced on gcc (like we were trying to do, causing spurious failures); so don't do that. This change shouldn't actually reduce coverage anyway, since, as the comments in 'lib/depcomp' say, the 'dashXmstdout' depmode is just like

Re: [PATCH] depcomp: recognize tabs as whitespace in the dashmstdout mode

2012-02-08 Thread Jim Meyering
Peter Rosin wrote: > This thread has stalled. To sum things up and get things going again, > the following is what I'd like to do. First commit the three patches > (that are replies to this message) on the msvc branch. Then merge msvc > into master and into branch-1.11. > > 2/3 and 3/3 are alrea

[PATCH 3/3] depcomp: try to prevent whitespace regressions

2012-02-08 Thread Peter Rosin
Suggested by Stefano Lattarini. * lib/depcomp: Add $tab and $nl variables and use them throughout. --- lib/depcomp | 42 -- 1 files changed, 20 insertions(+), 22 deletions(-) diff --git a/lib/depcomp b/lib/depcomp index 606d09c..2c30282 100755 --- a/lib/

[PATCH 2/3] depcomp: recognize tabs as whitespace in the dashmstdout mode

2012-02-08 Thread Peter Rosin
Commit Release-1-7-2b-2-gf03ceab "Cope with DOS filenames in dependencies." inadvertedly converted tabs into spaces. * lib/depcomp (dashmstdout): Add a tab character to all sets matching whitespace. --- lib/depcomp |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/

[PATCH 1/3] depcomp: quote 'like this', not `like this'

2012-02-08 Thread Peter Rosin
Cherry-picked from recent changes from master. * lib/depcomp: Quote 'like this', not `like this'. --- lib/depcomp | 40 1 files changed, 20 insertions(+), 20 deletions(-) diff --git a/lib/depcomp b/lib/depcomp index bd0ac08..ff4e08f 100755 --- a/lib/dep

Re: [PATCH] depcomp: recognize tabs as whitespace in the dashmstdout mode

2012-02-08 Thread Peter Rosin
Hi! This thread has stalled. To sum things up and get things going again, the following is what I'd like to do. First commit the three patches (that are replies to this message) on the msvc branch. Then merge msvc into master and into branch-1.11. 2/3 and 3/3 are already ACKed by Stefano and s

Re: [PATCH] tests: check the depmodes 'msvisualcpp' and 'msvcmsys'

2012-02-08 Thread Peter Rosin
Stefano Lattarini skrev 2012-02-08 12:42: > On 02/08/2012 11:03 AM, Peter Rosin wrote: >> * tests/defs (cygpath): New requirement, checking that cygpath >> is working. >> (mingw): New requirement, checking that the build system is >> MSYS (in its normal MinGW mode). >> * tests/gen-testsuite-part (d

Re: [PATCH] tests: check the depmodes 'msvisualcpp' and 'msvcmsys'

2012-02-08 Thread Stefano Lattarini
On 02/08/2012 11:03 AM, Peter Rosin wrote: > * tests/defs (cygpath): New requirement, checking that cygpath > is working. > (mingw): New requirement, checking that the build system is > MSYS (in its normal MinGW mode). > * tests/gen-testsuite-part (depmodes): Add entries for depmodes > 'msvisualcpp

[PATCH] tests: check the depmodes 'msvisualcpp' and 'msvcmsys'

2012-02-08 Thread Peter Rosin
* tests/defs (cygpath): New requirement, checking that cygpath is working. (mingw): New requirement, checking that the build system is MSYS (in its normal MinGW mode). * tests/gen-testsuite-part (depmodes): Add entries for depmodes 'msvisualcpp' and 'msvcmsys'. --- tests/defs | 10

Re: [PATCH] {master} tests: better way to compare lists in Makefile rules

2012-02-08 Thread Stefano Lattarini
On 02/06/2012 07:29 PM, Stefano Lattarini wrote: > With this commit, we introduce a new helper shell script for use > in the testsuite, which is meant to allow the test cases to easily > check whether two whitespace-separated lists are equal; this ability > is particularly useful to check for equal

Re: bug#10434: FAIL: depmod.tap 50 - tru64 [long VPATH] make & remake

2012-02-08 Thread Stefano Lattarini
tags 10434 + patch close 10434 thanks On 02/08/2012 12:29 AM, Peter Rosin wrote: > Stefano Lattarini skrev 2012-02-08 00:01: >> Hi Peter, thanks for the invaluable feedback. > > Thanks for the appreciation, but "invaluable" is perhaps a bit over > the top... > Not for what concerns this patch IMH