This is not a real regression in portability, since most maintainer
check rules already assumed GNU grep, and were anyway only meant to
run on the developers' systems.
This change will allow us to take advantage, in future changes, of
more GNU make features, thus simplifying or optimizing some of
We can do so now that our maintainer checks require GNU make
unconditionally.
* syntax-check.mk (ams, xtests): Redefine as "immediate variables",
using the GNU make $(shell ...) builtin.
(maintainer-check-list-of-tests): Take advantage of GNU make "-C"
option. Don't use $(AM_MAKEFLAGS), we should
A small refactoring in our syntax-check to avoid code duplication
and to ensure more uniform checking. This change introduces some
new failures in syntax-check rules (both real and spurious), that
will be fixed in follow-up changes and code reorganizations.
* Makefile.am (ams): New variable, hold
I will push this series to master in a couple of days if there is
no objection.
Regards,
Stefano
Stefano Lattarini (4):
maintcheck: refactor rules checking '*.am' files
build: require GNU make to run the maintainer checks
maintcheck: take advantage of some GNU make features
maintcheck:
* lib/Makefile.am (install-data-hook): Correctly quote $(DESTDIR)
occurrences.
* Makefile.am (install-exec-hook, uninstall-hook): Likewise.
(autodiffs): Prefer '$(am__cd)' to plain 'cd', where warranted.
* doc/Makefile.am ($(srcdir)/amhello-1.0.tar.gz): Likewise. Also,
prefer using AC_SUBST'd $(ab
commit 4fbec2fffe9d98470b3c5d1d03a94e32660366b0
Merge: 73b1e44 0436a1e
Author: Stefano Lattarini
AuthorDate: Sat Jan 28 14:09:56 2012 +0100
Commit: Stefano Lattarini
CommitDate: Sat Jan 28 14:09:56 2012 +0100
Merge branch 'maint' into branch-1.11
* maint:
tests: avoid spur
