Re: [FYI 0/2] {test-protocols} tap: improve granularity for tests on problematic TAP messages

2011-08-17 Thread Stefano Lattarini
On Wednesday 17 August 2011, Stefano Lattarini wrote: > * tests/tap-message-0.test: Break up into ... > * tests/tap-msg0-result.test, tests/tap-msg0-directive.test, > tests/tap-msg0-planskip.test, tests/tap-msg0-misc.test, > tests/tap-msg0-bailout.test: ... these new tests, and extend > a little. >

[FYI 0/2] {test-protocols} tap: improve granularity for tests on problematic TAP messages

2011-08-17 Thread Stefano Lattarini
* tests/tap-message-0.test: Break up into ... * tests/tap-msg0-result.test, tests/tap-msg0-directive.test, tests/tap-msg0-planskip.test, tests/tap-msg0-misc.test, tests/tap-msg0-bailout.test: ... these new tests, and extend a little. * tests/Makefile.am (tap_with_common_setup_tests): Update. --- C

[FYI 1/2] {test-protocols} tap: correctly handle string "0" in TAP messages

2011-08-17 Thread Stefano Lattarini
* lib/tap-driver.pl (is_null_string): New function, can be used to determine whether a given string variable is empty or undefined. Useful to avoid pitfalls like: if ($message) { print "$message\n"; } which wouldn't print anything if $message is the literal "0". (handle_tap_test, handle_tap_plan,

[FYI 0/2] {test-protocols} Correctly handle the string "0" in TAP messages.

2011-08-17 Thread Stefano Lattarini
Perl makes basically no distinction between the string "0" and the number 0: $ perl -e '$x = 0; $y = "0"; print "Ouch\n" if $x == $y && $x eq $y && !$y;' Ouch In particular, this means that the string "0" is considered as a false value when used as a boolean. This "feature" was causing some prob

[FYI] {test-protocols} tap: add a dummy TAP driver script implemented in shell + awk

2011-08-17 Thread Stefano Lattarini
The user can also now decide which implementation of the TAP driver to use in the testsuite by defining the `$am_tap_implementation' variable to either "perl" or "shell". Future enhancements will allow the testsuite to automatically run the test scripts on TAP support with both the TAP driver impl

[FYI] {test-protocols} parallel-tests: fix help screen for test driver scripts

2011-08-17 Thread Stefano Lattarini
* lib/tap-driver.pl ($USAGE): The `--trs-file' option is mandatory too. * lib/tap-driver.sh (print_usage): Likewise. * lib/test-driver (print_usage): Likewise. ($scriptversion): Update. --- ChangeLog |9 + lib/tap-driver.pl |2 +- lib/tap-driver.sh |2 +- lib/test-drive

[FYI] {test-protocols} tap: a minor simplification in the perl TAP driver

2011-08-17 Thread Stefano Lattarini
* lib/tap-driver.pl: The `--disable-hard-errors' option is a no-op, so just ignore it and its argument. --- ChangeLog |6 ++ lib/tap-driver.pl |3 +-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 3fefbd3..571218b 100644 --- a/Change

[FYI] {test-protocols} testsuite: refactor tests on TAP support in view of future changes

2011-08-17 Thread Stefano Lattarini
* tests/defs (fetch_tap_driver): New subroutine; it fetches the automake-provided TAP driver from the `lib/' directory into the current directory, and edits its shebang line so that it will be run with the perl interpreter determined at configure time. * tests/tap-setup.sh: Use it. * tests/tap-comm

Re: [FYI] {test-protocols} coverage: missing tap plan and non-zero exit status

2011-08-17 Thread Stefano Lattarini
On Sunday 14 August 2011, Stefano Lattarini wrote: > * tests/tap-missing-plan-and-bad-exit.test: New test. > * tests/Makefile.am (tap_with_common_setup_tests): Update. > --- > ChangeLog|6 > tests/Makefile.am|1 + > tests/tap-mis

[FYI] {testsuite-work} test defs: fix typo in comments

2011-08-17 Thread Stefano Lattarini
* tests/defs (get_shell_script): Fix typo in the function description. --- ChangeLog |6 ++ tests/defs |2 +- 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/ChangeLog b/ChangeLog index 3477d61..eeb8374 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2011-08-17