Re: [FYI 1/4] {tap-testsuite-work} test defs: small cleanups and tweakings

2011-08-08 Thread Stefano Lattarini
On Monday 08 August 2011, Stefano Lattarini wrote: > * tests/defs: Where possible, prefer `framework_failure_' or > `fatal_' to `Exit 99'. Try to catch more possible hard errors > and setup failures. Do not hide expected error messages. Avoid > a couple of forks when copying files from `$(top_sr

[FYI 4/4] {tap-testsuite-work} testsuite: more uses of the `seq_' function

2011-08-08 Thread Stefano Lattarini
* tests/parallel-tests-exit-statuses.test: Use the `seq_' function from `tests/defs', instead of duplicating its semantics by hand. * tests/testsuite-summary-count.test: Likewise. --- ChangeLog |7 +++ tests/parallel-tests-exit-statuses.test |8 +--- t

[FYI 3/4] {tap-testsuite-work} testsuite: drop redundant environment sanitization

2011-08-08 Thread Stefano Lattarini
* tests/Makefile.am (TESTS_ENVIRONMENT): Don't remove `planned' from the environment. * tests/defs-static.in: Don't complain if `planned' is set in the environment. * tests/self-check-env-sanitize.test: Update. --- ChangeLog |9 + tests/Makefile.am

[FYI 2/4] {tap-testsuite-work} test defs: fix bug in plain version of `skip_all_'

2011-08-08 Thread Stefano Lattarini
* tests/plain-functions.sh (skip_all_): Call `skip_', not `skip'. --- ChangeLog|5 + tests/plain-functions.sh |2 +- 2 files changed, 6 insertions(+), 1 deletions(-) diff --git a/ChangeLog b/ChangeLog index 3d2824a..6def035 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,

[FYI 1/4] {tap-testsuite-work} test defs: small cleanups and tweakings

2011-08-08 Thread Stefano Lattarini
* tests/defs: Where possible, prefer `framework_failure_' or `fatal_' to `Exit 99'. Try to catch more possible hard errors and setup failures. Do not hide expected error messages. Avoid a couple of forks when copying files from `$(top_srcdir)/lib'. ($signal): Remove, no more needed. --- ChangeL

[FYI 0/4] {tap-testsuite-work} Some more testsuite patches

2011-08-08 Thread Stefano Lattarini
Stefano Lattarini (4): test defs: small cleanups and tweakings test defs: fix bug in plain version of `skip_all_' testsuite: drop redundant environment sanitization testsuite: more uses of the `seq_' function ChangeLog | 30 ++ t

[FYI] {tap-testsuite-work}testsuite: improve interface for giving early TAP plan

2011-08-08 Thread Stefano Lattarini
Since commit `v1.11-976-g4740f56', an early TAP plan can also be specified after input lines have already been seen, as long as no one of them is a TAP result line. We can now take advantage of this in our own testsuite, allowing the TAP-based scripts to specify their earlier plan after having inc

[FYI] {tap-testsuite-work} test defs: fix bug in TAP version of `skip_all_'

2011-08-08 Thread Stefano Lattarini
* tests/tap-functions (skip_all_): Set `$have_tap_plan_' to "yes" when called, so that the exit trap won't write another TAP plan. --- ChangeLog |6 ++ tests/tap-functions.sh |1 + 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/ChangeLog b/ChangeLog index 5

[FYI] {tap-testsuite-protocols} test defs: fix skip directives to work also with TAP-based tests

2011-08-08 Thread Stefano Lattarini
* test/defs: Use `skip_all_', not `skip_', to issue a skip of the whole calling test script. --- ChangeLog |6 tests/defs | 86 ++-- 2 files changed, 49 insertions(+), 43 deletions(-) diff --git a/ChangeLog b/ChangeLog index 4d2f

[FYI] {maint} test defs: more environment cleanup

2011-08-08 Thread Stefano Lattarini
* tests/defs.in: Also unset variables AM_COLOR_TESTS and AM_TESTS_ENVIRONMENT. --- ChangeLog |6 ++ tests/defs.in |3 ++- 2 files changed, 8 insertions(+), 1 deletions(-) I've applied the attached patch to maint, merged to all relevant branches, and updated. Once merged into test

[FYI] {test-protocols} test harness: more minor VPATH-rewrite issues

2011-08-08 Thread Stefano Lattarini
* tests/am/check.am (am__set_TESTS_bases, $(TEST_SUITE_LOGS), am--redo-logs, recheck, recheck-html): Cosmetic fixlets to minimize the risk of unwanted VPATH rewrites. (check-TESTS): Likewise, and normalize trailing whitespace since we are at it. Bugs exposed by test cases `check6-p.test' and `che

Re: [FYI] {test-protocols} test harness: "make -n check" works correctly with Solaris make

2011-08-08 Thread Stefano Lattarini
On Monday 08 August 2011, Stefano Lattarini wrote: > To avoid some recipes being executed with "make -n", we used the > trick of issuing recursive make calls not directly with $(MAKE), > but with a simple indirection instead: > ... > am__stealth_MAKE = $(MAKE) > ... > target: > ... $(

[FYI] {test-protocols} test harness: "make -n check" works correctly with Solaris make

2011-08-08 Thread Stefano Lattarini
To avoid some recipes being executed with "make -n", we used the trick of issuing recursive make calls not directly with $(MAKE), but with a simple indirection instead: ... am__stealth_MAKE = $(MAKE) ... target: ... $(am__stealth_MAKE) ... ... This hack worked with GNU make, but, un

[FYI] various merges

2011-08-08 Thread Stefano Lattarini
Merge branch 'maint' into branch-1.11 * maint: tests: fix spurious failure with Solaris make -*-*-*- Merge branch 'maint' into master * maint: tests: fix spurious failure with Solaris make -*-*-*- Merge branch 'master' into testsuite-work * master: tests: fix spurious failu

[FYI] {maint} tests: fix spurious failure with Solaris make

2011-08-08 Thread Stefano Lattarini
This patch fixes a spurious testsuite failure on Solaris. Applied to a temporary bug-fixing branch off of `v1.11-375-g474aad0', merged to maint, and pushed. Regards, Stefano From d9e4f1ec7d87ed96bb663c883ee3dd96e56affa9 Mon Sep 17 00:00:00 2001 Message-Id: From: Stefano Lattarini Date: Mon, 8

[FYI] {test-protocols} test harness: fixlet in workaround for VPATH rewrite issue

2011-08-08 Thread Stefano Lattarini
On Monday 08 August 2011, Stefano Lattarini wrote: > * lib/am/check.am (am__TEST_BASES): Removed, it's role taken > over by ... > (am__set_TESTS_bases): ... these new variable. > ($(TEST_SUITE_LOG): Use it, to avoid VPATH rewrite issues. > * automake.in (handle_tests): Update the code for the clean