Re: [PATCH v4 3/3] parallel-tests: allow each test to have multiple results

2011-06-19 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Fri, Jun 17, 2011 at 09:33:13AM CEST: > On Friday 17 June 2011, Ralf Wildenhues wrote: > > > Actually, why not s/testcase/test/g globally in all your text. > > > Because I'm trying to make a distinction between test scripts and > test cases. With the new interface, a

Re: [PATCH 1/2] tests: make test runner a script, not a shell function

2011-06-19 Thread Jim Meyering
Stefano Lattarini wrote: > Subject: [PATCH 2/2] tests: avoid extra forks in the testsuite > > * tests/shell-or-perl: Prefer the `read' builtin over `grep' to > look at the shebang line of test scripts. Since `read' is a > special builtin, it might abort the whole program upon failures, > so add ex

Re: [PATCH 1/2] tests: make test runner a script, not a shell function

2011-06-19 Thread Jim Meyering
Thank you! That patch looks fine modulo two typos. I'm folding in these corrections and have adjusted the grammar in the commit log (included below). diff --git a/tests/shell-or-perl b/tests/shell-or-perl index ff92009..08604eb 100644 --- a/tests/shell-or-perl +++ b/tests/shell-or-perl @@ -1,7 +1,

Re: [PATCH] check: don't use multi-line

2011-06-19 Thread Stefano Lattarini
On Sunday 19 June 2011, Bert Wesarg wrote: > > Hi Bert, and thanks again for your patch. > > Hi, > > > I have some minor observations and objections below (please do not take > > them as a belittling of your work; they are either constructive criticism, > > or requests for cosmetic changes mandat

RE: [PATCH] check: don't use multi-line

2011-06-19 Thread Bert Wesarg
> Hi Bert, and thanks again for your patch. Hi, > I have some minor observations and objections below (please do not take them > as a belittling of your work; they are either constructive criticism, or > requests for cosmetic changes mandated by the GNU coding standards). > I hope you have time

Re: [PATCH v4 1/3] parallel-tests: add auxiliary script 'pt-driver', refactor

2011-06-19 Thread Stefano Lattarini
On Friday 17 June 2011, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Thu, Jun 16, 2011 at 10:00:31AM CEST: > > This refactoring should cause no API of functionality change, > > and is meant only to simplify the future implementation of TAP > > and SubUnit testsuite drivers. More precisely