Re: Patch reviews

Hello guys, On Tue, Jun 07, 2011 at 09:25:33AM +0200, Peter Rosin wrote: > Now that Ralf is doing something else for a while, Thanks for the roses. After moving twice within 5 weeks (and generally having far too little time), things should gradually improve as soon as I have a landline internet

Re: [PATCH] {maint} Docs: better documentation for silent make rules.

Reference: Ping on this? I've rebased the patch against latest maint, done some rewordings, and reworked the example (now it's broken into two examples) to be both less complex and more informative (IMHO). I know the pa

[PATCH 6/6] py-compile: '--' and non-option arguments terminate the option list

* lib/py-compile: Any non-option argument, or the special `--' argument, now explicitly terminates the list of options. * tests/py-compile-option-terminate.test: New test. * tests/Makefile.am (TESTS): Update. * NEWS: Update. --- ChangeLog |9 ++ NEWS

[PATCH 5/6] py-compile: complain on unrecognized options

* lib/py-compile: Complain on unrecognized options. Don't be too lax in matching `--help' and `--version' options. * tests/py-compile-usage.test: Extend accordingly. * NEWS: Update. --- ChangeLog |8 NEWS|2 +- lib/py-compile

[PATCH 4/6] py-compile: normalize error and help messages

* lib/py-compile: Now error messages do not begin with a capital letter, nor end with a period, as per GNU standards. Prepend the error messages with the name of the script, not with its path. When an invalid usage is recognized, always display the customary message "Try `py-compile --help' ..." o

[PATCH 2/6] py-compile: the '--destdir' option now accepts a blank argument

* lib/py-compile (Option parsing): Do not count an empty argument to `--destdir' or `--basedir' as a missing argument. * lib/python.am: Simplify accordingly, passing the `--destdir' option to py-compile unconditionally, even if `$(DESTDIR)' is empty. * NEWS: Update. --- ChangeLog| 10 +++

[PATCH 0/6] Some python patches

Hello automakers. In the first patch of this series I'll present the promised patch ensuring that the py-compile script is run with $(SHELL) in the automake-generated Makefiles. While writing that patch, I've noticed (and plucked) a couple of low-hanging fruits allowing small reductions in code d

[PATCH 3/6] python tests: add "unit tests" on py-compile

* tests/py-compile-basic.test: New test. * tests/py-compile-basic2.test: New test. * tests/py-compile-basedir.test: Likewise. * tests/py-compile-destdir.test: Likewise. * tests/py-compile-env.test: Likewise. * tests/py-compile-usage.test: Likewise. * tests/Makefile.am (TESTS): Update. Tested with

[PATCH 1/6] python: run the 'py-compile' script with $(SHELL)

* lib/python.am (install-%DIR%PYTHON): Run each instance of py-compile using $(SHELL). Since we are at it, break overly long lines. (am__py_compile): New variable, to reduce code duplication. --- ChangeLog|8 lib/am/python.am | 15 +-- 2 files changed, 17 insert