Re: [PATCH] {master} coverage: add tests on remake rules in more complex situations

On Saturday 09 April 2011, Bruno Haible wrote: > Hi Stefano, > > > > --author? > > > > > Right, I didn't tought about that. We should put Bruno as author here > > IMHO. > > I think you did more than 50% of the code and testing on this patch. Therefore > it's only fair if you are mentioned at pri

Re: bug#8234: check_JAVA built during make

On Saturday 09 April 2011, Stefano Lattarini wrote: > > Here is what I've squashed in: > > -*-*- > > diff --git a/ChangeLog b/ChangeLog > index 6649603..1bf9ab3 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,4 +1,4 @@ > -2011-04-06 Stefano Lattarini > +2011-04-09 Stefano Lattarini >

Re: [PATCH] {master} coverage: add tests on remake rules in more complex situations

Hi Stefano, > > --author? > > > Right, I didn't tought about that. We should put Bruno as author here > IMHO. I think you did more than 50% of the code and testing on this patch. Therefore it's only fair if you are mentioned at principal author. Bruno -- In memoriam Georg Elser

Re: bug#8234: check_JAVA built during make

On Saturday 09 April 2011, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Wed, Apr 06, 2011 at 06:52:24PM CEST: > > OK for maint? I'll push in 72 hours if there is no objection. > > This is OK with a NEWS entry and the nit below addressed. > > Thanks! > Ralf > > > Subject: [PATCH] java:

[FYI] {master} typofix in 'tests/defs'

* tests/defs: Fix typo (`itslef' instead of `itself') in comments. --- ChangeLog |6 ++ tests/defs |2 +- 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/ChangeLog b/ChangeLog index 3de7584..d4fe8e9 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2011-04-09 Ste

Re: [PATCH] {master} coverage: add tests on remake rules in more complex situations

On Saturday 09 April 2011, Ralf Wildenhues wrote: > Hello Stefano, Bruno, > > nice collaboration work there, thank you! > > I have a few nits, mostly really trivial. Feel free to push after > addressing them. > I agree with almost all of your nits (and I've edited the patch accordingly, see the

Re: bug#8234: check_JAVA built during make

* Stefano Lattarini wrote on Wed, Apr 06, 2011 at 06:52:24PM CEST: > OK for maint? I'll push in 72 hours if there is no objection. This is OK with a NEWS entry and the nit below addressed. Thanks! Ralf > Subject: [PATCH] java: check_JAVA does not cause compilation by "make all" > anymore > Fi

Re: [PATCH] {master} coverage: add tests on remake rules in more complex situations

Hello Stefano, Bruno, nice collaboration work there, thank you! I have a few nits, mostly really trivial. Feel free to push after addressing them. --author? * Stefano Lattarini wrote on Fri, Apr 08, 2011 at 12:54:27PM CEST: > Subject: [PATCH] coverage: add tests on remake rules in more complex

Re: [PATCH] {master} coverage: more on java support: EXTRA_ and noinst_ prefixes

On Saturday 09 April 2011, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Sat, Apr 09, 2011 at 01:57:50PM CEST: > > --- a/tests/java-extra.test > > +++ b/tests/java-extra.test > > @@ -26,6 +26,7 @@ set -e > >cat >> configure.in << 'END' > >AC_CHECK_PROG([HAS_JAVAC], [javac], [:

Re: [PATCH] {master} coverage: more on java support: EXTRA_ and noinst_ prefixes

* Stefano Lattarini wrote on Sat, Apr 09, 2011 at 01:57:50PM CEST: > --- a/tests/java-extra.test > +++ b/tests/java-extra.test > @@ -26,6 +26,7 @@ set -e >cat >> configure.in << 'END' >AC_CHECK_PROG([HAS_JAVAC], [javac], [:], [exit]) >($HAS_JAVAC 77); $HAS_JAVAC 77 > +AM_CONDITI

Re: [PATCH] {master} tests: remove useless sleep from tests on remake rules

On Saturday 09 April 2011, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Sun, Apr 03, 2011 at 11:05:54AM CEST: > > On Sunday 03 April 2011, Ralf Wildenhues wrote: > > > * Stefano Lattarini wrote on Sun, Apr 03, 2011 at 10:23:57AM CEST: > > > > The sleeps were there to make generated autotoo

Re: [PATCH] {master} coverage: more on java support: EXTRA_ and noinst_ prefixes

On Saturday 09 April 2011, Ralf Wildenhues wrote: > Hi Stefano, > > * Stefano Lattarini wrote on Fri, Apr 08, 2011 at 10:59:55AM CEST: > > * tests/java-extra.test: New test, checking support for the > > prefix `EXTRA_' with the JAVA primary. > > * tests/java-noinst.test: New test, checking support

Re: Fix makedepend depmode to cope with VPATH builds

On Saturday 09 April 2011, Ralf Wildenhues wrote: > > But independently of bracket expressions, Posix also specifies that ^ > and $ are not special when they are not first or last characters in a > regex, respectively. This is what makes object file names of the form > foo^bar.o and foo$bar.o acce

Re: [PATCH] {master} tests: remove useless sleep from tests on remake rules

* Stefano Lattarini wrote on Sun, Apr 03, 2011 at 11:05:54AM CEST: > On Sunday 03 April 2011, Ralf Wildenhues wrote: > > * Stefano Lattarini wrote on Sun, Apr 03, 2011 at 10:23:57AM CEST: > > > The sleeps were there to make generated autotools files strictly > > > newer than their sources; however,

Re: [PATCH] {master} coverage: more on java support: EXTRA_ and noinst_ prefixes

Hi Stefano, * Stefano Lattarini wrote on Fri, Apr 08, 2011 at 10:59:55AM CEST: > * tests/java-extra.test: New test, checking support for the > prefix `EXTRA_' with the JAVA primary. > * tests/java-noinst.test: New test, checking support for the > prefix `noinst_' with the JAVA primary. > * tests/M

Re: Fix makedepend depmode to cope with VPATH builds

* Stefano Lattarini wrote on Sat, Apr 09, 2011 at 12:29:43PM CEST: > On Saturday 09 April 2011, Ralf Wildenhues wrote: > > I guess then I don't understand your observation then. Your observation > > tells me that object file names of the form foo^bar.o and foo$baz.o are > > not problematic. > > >

Re: Fix makedepend depmode to cope with VPATH builds

On Saturday 09 April 2011, Ralf Wildenhues wrote: > Hi Stefano, > > * Stefano Lattarini wrote on Sat, Apr 09, 2011 at 11:38:47AM CEST: > > On Friday 08 April 2011, Ralf Wildenhues wrote: > > > * Stefano Lattarini wrote on Fri, Apr 08, 2011 at 01:05:53PM CEST: > > > > On Wednesday 06 April 2011, Ra

Re: Fix makedepend depmode to cope with VPATH builds

Hi Stefano, * Stefano Lattarini wrote on Sat, Apr 09, 2011 at 11:38:47AM CEST: > On Friday 08 April 2011, Ralf Wildenhues wrote: > > * Stefano Lattarini wrote on Fri, Apr 08, 2011 at 01:05:53PM CEST: > > > On Wednesday 06 April 2011, Ralf Wildenhues wrote: > > > > + # makedepend may prepend the

Re: Fix makedepend depmode to cope with VPATH builds

On Friday 08 April 2011, Ralf Wildenhues wrote: > Hi Stefano, > > * Stefano Lattarini wrote on Fri, Apr 08, 2011 at 01:05:53PM CEST: > > Hello Ralf, sorry for the delay. > > I don't think you need to apologize for any delays on your behalf, > for at least a few months. ;-) > > > On Wednesday 06