We don't want YACC and LEX defined as make variables, otherwise
the values determined at configure time will override those from
the environment, even in the make-spawned testcases. For example,
before this change, with the following usage:
$ ./configure YACC=yacc
$ export YACC='bison -y'
$
On Saturday 29 January 2011, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Sat, Jan 29, 2011 at 06:37:04PM CET:
> > OK for a temporary branch 'lflags-test-fixes' (stemming out of commit
> > v1.11-136-gfee7d0d "Fix minor testsuite issues, update docs, for Yacc/Lex
> > changes"), to be merged
* Stefano Lattarini wrote on Sat, Jan 29, 2011 at 06:37:04PM CET:
> OK for a temporary branch 'lflags-test-fixes' (stemming out of commit
> v1.11-136-gfee7d0d "Fix minor testsuite issues, update docs, for Yacc/Lex
> changes"), to be merged into maint and yacc-work?
OK, thanks,
Ralf
> Subject: [PA
Hello automakers.
The tests `lflags.test' and `lflags2.test' fail if an environment variable
LEX is defined, because they call `make -e', thus letting the value of that
variable override the value we forced at configure time. This bug is the
the same already discovered in yflags*.test (and fixed
* Stefano Lattarini wrote on Sat, Jan 29, 2011 at 02:48:12PM CET:
> On Saturday 29 January 2011, Ralf Wildenhues wrote:
> > (automake will not produce a rule for some target if you put a
> > rule for that target in the Makefile.am, even if your rule does
> > not contain commands;
> >
> JFTR: I neve
On Saturday 29 January 2011, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Sat, Jan 29, 2011 at 02:20:00PM CET:
> > On Saturday 29 January 2011, Ralf Wildenhues wrote:
> > > I agree with everything except ...
> > >
> > > > BUILT_SOURCES = parse1.h p2-parse2.h
> > > > +main3.@OBJEXT@: pars
* Stefano Lattarini wrote on Sat, Jan 29, 2011 at 02:20:00PM CET:
> On Saturday 29 January 2011, Ralf Wildenhues wrote:
> > I agree with everything except ...
> >
> > > BUILT_SOURCES = parse1.h p2-parse2.h
> > > +main3.@OBJEXT@: parse3.h
> >
> > ... this line shouldn't be there, other than to wo
On Saturday 29 January 2011, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Sat, Jan 29, 2011 at 01:48:16PM CET:
> > On Saturday 29 January 2011, Ralf Wildenhues wrote:
> > > FYI, I think the test has some overlap with one of the make -n tests
> > > that ensures the deleted header recovery d
* Stefano Lattarini wrote on Sat, Jan 29, 2011 at 01:48:16PM CET:
> On Saturday 29 January 2011, Ralf Wildenhues wrote:
> > FYI, I think the test has some overlap with one of the make -n tests
> > that ensures the deleted header recovery doesn't build files in dry
> > run mode.
> >
> Not exactly; i
On Saturday 29 January 2011, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Fri, Jan 28, 2011 at 05:01:11PM CET:
> > OK for the 'yacc-work' branch? I will push in 72 hours if
> > there's no objection.
>
> OK with nits addressed.
>
> FYI, I think the test has some overlap with one of the m
* Stefano Lattarini wrote on Sat, Jan 29, 2011 at 01:16:59PM CET:
> defs.in: Give better diagnostic messages when a test must
> be skipped to the unavailability of yacc or lex program. Also,
> improve syncing between code for requiring yacc and lex.
OK, thanks,
Ralf
defs.in: Give better diagnostic messages when a test must
be skipped to the unavailability of yacc or lex program. Also,
improve syncing between code for requiring yacc and lex.
---
ChangeLog |8
tests/defs.in | 14 +-
2 files changed, 13 insertions(+), 9 deletions(
* Stefano Lattarini wrote on Fri, Jan 28, 2011 at 05:01:11PM CET:
> OK for the 'yacc-work' branch? I will push in 72 hours if
> there's no objection.
OK with nits addressed.
FYI, I think the test has some overlap with one of the make -n tests
that ensures the deleted header recovery doesn't buil
On Saturday 29 January 2011, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Sat, Jan 29, 2011 at 12:19:27PM CET:
> > On Saturday 29 January 2011, Ralf Wildenhues wrote:
> > > You need to withstand copy and paste. This comment is copied and pasted
> > > from a few lines above. It is erroneo
FYI, I added .symlinks entries for the PDF manuals that the online
copies of {automake,libtool}.pdf link to, so that it should now be
possible to jump from one manual to the other in a decent PDF reader.
This was prompted by a report against Autoconf.
Cheers,
Ralf
* Stefano Lattarini wrote on Sat, Jan 29, 2011 at 12:19:27PM CET:
> On Saturday 29 January 2011, Ralf Wildenhues wrote:
> > You need to withstand copy and paste. This comment is copied and pasted
> > from a few lines above. It is erroneous (search for 'yacc') and immoral
> > (towards a reader of
On Saturday 29 January 2011, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Fri, Jan 28, 2011 at 11:19:12PM CET:
> > This will allow the testcases requiring a 'lex' program to run also
> > with vendor/legacy lex implementations, not only with 'flex'.
>
> > * configure.ac: Look for a lex pro
On Saturday 29 January 2011, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Fri, Jan 28, 2011 at 01:51:40PM CET:
> > On Thursday 27 January 2011, Ralf Wildenhues wrote:
> > > Does 'make -n' create files (for any target)?
> > >
> > No, and I've updated the `yaccdry.test' testcase to also chec
* Stefano Lattarini wrote on Fri, Jan 28, 2011 at 11:19:12PM CET:
> This will allow the testcases requiring a 'lex' program to run also
> with vendor/legacy lex implementations, not only with 'flex'.
> * configure.ac: Look for a lex program, using AC_CHECK_PROGS.
> * tests/defs.in: New required en
* Stefano Lattarini wrote on Sat, Jan 29, 2011 at 10:01:40AM CET:
[ snip long explanation ]
> * Hence I wrote the present patch. Two important things to note about
>it:
> - It's not a *bugfix*, just an optimization (in terms of testsuite
> speed, size, and simplicity).
> - The
On Saturday 29 January 2011, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Fri, Jan 28, 2011 at 05:06:51PM CET:
> > Finally a testsuite patch that offers a simplification rather
> > than a complication (at least IMHO). The ChangeLog entry below
> > should explain the details.
> >
> > OK f
21 matches
Mail list logo
