Re: tests: work around Tru64 sh -e issues for instspc*.test.

2011-01-18 Thread Stefano Lattarini
On Tuesday 18 January 2011, Ralf Wildenhues wrote: > This patch fixes all but 9 of the 76 or so instspc*.test failures on > Tru64. It is for the tests-init branch, or a tests-init-fixes on top of > v1.11-395-ge118126 I guess. I'll wait a couple of days before pushing. > The patch is ok with me (b

Re: [PATCH] {maint} tests: new subroutines for test skipping/failing

2011-01-18 Thread Stefano Lattarini
On Tuesday 18 January 2011, Jim Meyering wrote: > Ralf Wildenhues wrote: > > ... > > > >> +# This is useful when using automake's parallel tests mode, to print > >> +# the reason for skip/failure to console, rather than to the .log files. > >> +: ${stderr_fileno_=2} > >> + > >> +warn_() { echo "$@"

Re: [PATCH] {maint} tests: new subroutines for test skipping/failing

2011-01-18 Thread Stefano Lattarini
On Tuesday 18 January 2011, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Mon, Jan 17, 2011 at 10:55:55PM CET: > > On Monday 17 January 2011, Ralf Wildenhues wrote: > > > * Stefano Lattarini wrote on Sun, Jan 16, 2011 at 03:56:07PM CET: > > > > + Use the `skip_' function to skip tests, wit

Re: [PATCH] {maint} tests: new subroutines for test skipping/failing

2011-01-18 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Tue, Jan 18, 2011 at 11:21:42PM CET: > On Tuesday 18 January 2011, Ralf Wildenhues wrote: > > 1) AM_TESTS_SETUP TESTS_SETUP > > > > or > > 2) AM_TEST_SETUP TEST_SETUP > > > Honestly, I find (1) more intuitive, and I'd prefer it even without the > TESTS_ENVIRONMENT pr

Re: [PATCH] {maint} tests: new subroutines for test skipping/failing

2011-01-18 Thread Stefano Lattarini
On Tuesday 18 January 2011, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Mon, Jan 17, 2011 at 10:55:55PM CET: > > > $(AM_TESTS_SETUP) $(TESTS_SETUP) > > One thing I'm a bit unsure about: > 1) AM_TESTS_SETUP TESTS_SETUP > > or > 2) AM_TEST_SETUP TEST_SETUP > > ? I would have preferred

tests: work around Tru64 sh -e issues for instspc*.test.

2011-01-18 Thread Ralf Wildenhues
This patch fixes all but 9 of the 76 or so instspc*.test failures on Tru64. It is for the tests-init branch, or a tests-init-fixes on top of v1.11-395-ge118126 I guess. I'll wait a couple of days before pushing. I haven't analyzed the failure sufficiently to be able to write a patch for autoconf

tests: avoid failure on w32 file systems.

2011-01-18 Thread Ralf Wildenhues
Obvious omission I didn't think of. This is for maint, I'll push tomorrow. Cheers, Ralf tests: avoid failure on w32 file systems. * tests/parallel-tests-unreadable-log.test: SKIP if file cannot be turned unreadable. diff --git a/tests/parallel-tests-unreadable-log.test b/tests

Re: [PATCH] {maint} tests: new subroutines for test skipping/failing

2011-01-18 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Mon, Jan 17, 2011 at 10:55:55PM CET: > On Monday 17 January 2011, Ralf Wildenhues wrote: > > * Stefano Lattarini wrote on Sun, Jan 16, 2011 at 03:56:07PM CET: > > > + Use the `skip_' function to skip tests, with a meaningful message if > > > + possible. Where conveni

Re: [PATCH] {maint} tests: new subroutines for test skipping/failing

2011-01-18 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Mon, Jan 17, 2011 at 10:55:55PM CET: > > $(AM_TESTS_SETUP) $(TESTS_SETUP) One thing I'm a bit unsure about: 1) AM_TESTS_SETUP TESTS_SETUP or 2) AM_TEST_SETUP TEST_SETUP ? I would have preferred TEST_ENVIRONMENT, but that one is far too late to change. (1) is cons

Re: [PATCH] {maint} tests: new subroutines for test skipping/failing

2011-01-18 Thread Jim Meyering
Ralf Wildenhues wrote: ... > Why not document framework_failure_? > >>For tests that use the `parallel-tests' Automake option, set the shell >>variable `parallel_tests' to "yes" before including ./defs. Also, >>use for them a name that ends in `-p.test' and does not clash with any > >>

Re: autobuild logs

2011-01-18 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Sat, Jan 15, 2011 at 09:00:22AM CET: > I've put up a set of logs at http://autobuild.josefsson.org/automake/ > again. Quite a few new failures, so I think some maintenance work is > warranted. FWIW, I started another set of builds sometime on Sunday, and have also uploa

Re: local perl $_ variable is not portable

2011-01-18 Thread Stefano Lattarini
On Tuesday 18 January 2011, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Mon, Jan 17, 2011 at 10:47:04PM CET: > > On Monday 17 January 2011, Ralf Wildenhues wrote: > > > * Stefano Lattarini wrote on Mon, Jan 17, 2011 at 01:39:29AM CET: > > > > BTW, I'd also add to the ChangeLog entry the "