Re: [PATCH v2 0/9] Explicit warning levels must always take precedence over those implied by the strictness

2011-01-15 Thread Stefano Lattarini
On Saturday 15 January 2011, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Sat, Jan 15, 2011 at 03:37:17PM CET: > > > > > > I've now pushed this patch series (with all the due amendments) > > to a new public branch

Re: bug#7819: automake does not really automatically distribute all the files it's advertised to.

2011-01-15 Thread Stefano Lattarini
Reference: On Monday 10 January 2011, Ralf Wildenhues wrote: > Hi Stefano, > > * Stefano Lattarini wrote on Mon, Jan 10, 2011 at 08:50:13PM CET: > > Files which are automatically distributed, if found: > > ABOUT-GNU README

Re: [PATCH 3/5] Tests defs: some cleanup and minor fixes.

2011-01-15 Thread Stefano Lattarini
I've pushed the patch now. Regards, Stefano

Re: [PATCH 2/5] Tests defs: new subroutine `skip' for test skipping.

2011-01-15 Thread Jim Meyering
Ralf Wildenhues wrote: ... > Jim, gnulib/tests/init.sh is GPLv3+ right now. We would like to use > code added/modified in commit v0.0-3988-g0ae8d63. Do you mind if we > copy that into Automake's testsuite setup, currently GPLv2+? AFAICS > you're the sole author of that and prior changes around t

Re: [PATCH 2/5] Tests defs: new subroutine `skip' for test skipping.

2011-01-15 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sat, Jan 15, 2011 at 04:34:18PM CET: > Agreed. I'll repropose the patch as a three-step patch series > (maybe not right away). BTW, at this point it might also be > based off of maint, right? To make integration of new tests > easier, and so. Sure, makes sense. Ch

Re: Avoid VPATH-related distcheck failures with non-GNU make

2011-01-15 Thread Stefano Lattarini
[ Adding automake to CC: ] On Saturday 15 January 2011, Ralf Wildenhues wrote: > OK, so all the added '$MAKE distcheck' "for safety" at the end of the > tests caused roughly a thousand new test failures across the board, it > seems, drowning other signals. Most of these failures apparently have >

Re: [PATCH 2/5] Tests defs: new subroutine `skip' for test skipping.

2011-01-15 Thread Stefano Lattarini
On Saturday 15 January 2011, Ralf Wildenhues wrote: > [ Jim, I have a question below ] > > * Stefano Lattarini wrote on Sat, Jan 15, 2011 at 03:16:51PM CET: > > On Saturday 15 January 2011, Ralf Wildenhues wrote: > > > * Stefano Lattarini wrote on Mon, Nov 15, 2010 at 06:23:21PM CET: > > > > Tests

Re: bug#7833: automake uses two different values for DejaGNU srcdir

2011-01-15 Thread Peter Breitenlohner
On Fri, 14 Jan 2011, Ralf Wildenhues wrote: Through testing I found out again that DejaGNU does not cope with white space in absolute directory names anyway, regardless of srcdir being relative or absolute. That obviates my first point. Remains only the fairly minor src+build-tree relocatabili

Re: [PATCH 3/5] Tests defs: some cleanup and minor fixes.

2011-01-15 Thread Stefano Lattarini
On Saturday 15 January 2011, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Mon, Nov 15, 2010 at 06:24:52PM CET: > > * tests/defs: Exit with status 99 (hard error) rather than > > 1 (failure) on unexpected/internal errors, or when a signal > > is caught by the client script. > > Some minor c

Re: [PATCH 2/5] Tests defs: new subroutine `skip' for test skipping.

2011-01-15 Thread Ralf Wildenhues
[ Jim, I have a question below ] * Stefano Lattarini wrote on Sat, Jan 15, 2011 at 03:16:51PM CET: > On Saturday 15 January 2011, Ralf Wildenhues wrote: > > * Stefano Lattarini wrote on Mon, Nov 15, 2010 at 06:23:21PM CET: > > > Tests defs: new subroutine `skip' for test skipping. > > > > I don't

Re: [PATCH 1/5] Tests defs: don't let useless variables leak in test scripts.

2011-01-15 Thread Stefano Lattarini
On Saturday 15 January 2011, Ralf Wildenhues wrote: > Hi Stefano, and apologies for the long delay, > > there were three patches in this series that haven't been reviewed yet: > > * Stefano Lattarini wrote on Mon, Nov 15, 2010 at 06:21:16PM CET: > > * tests/defs ($priv_check_temp, $overwrite_stat

Re: [PATCH v2 0/9] Explicit warning levels must always take precedence over those implied by the strictness

2011-01-15 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sat, Jan 15, 2011 at 03:37:17PM CET: > > > I've now pushed this patch series (with all the due amendments) > to a new public branch 'warns-win-over-strictness' based off of > master (not latest

Re: [PATCH v2 0/9] Explicit warning levels must always take precedence over those implied by the strictness

2011-01-15 Thread Stefano Lattarini
Reference: I've now pushed this patch series (with all the due amendments) to a new public branch 'warns-win-over-strictness' based off of master (not latest master, but near enough). I've not merged it to master yet, BTW

Re: [PATCH 2/5] Tests defs: new subroutine `skip' for test skipping.

2011-01-15 Thread Stefano Lattarini
On Saturday 15 January 2011, Ralf Wildenhues wrote: > Hi Stefano, > > * Stefano Lattarini wrote on Mon, Nov 15, 2010 at 06:23:21PM CET: > > Tests defs: new subroutine `skip' for test skipping. > > I don't like having this patch alone. If we switch to functions, then > we should so wholesale, and

Re: [PATCH] Update docs w.r.t. warning and strictness options.

2011-01-15 Thread Stefano Lattarini
On Saturday 15 January 2011, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Sat, Jan 15, 2011 at 02:23:56PM CET: > > On Saturday 15 January 2011, Ralf Wildenhues wrote: > > > * Stefano Lattarini wrote on Sat, Jan 15, 2011 at 12:41:16PM CET: > > > > , which in > > > > +turn take precedence o

docs: ensure example are separated with empty lines in the input (was: [PATCH] Update docs w.r.t. warning and strictness options.)

2011-01-15 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Sat, Jan 15, 2011 at 02:49:33PM CET: > * Stefano Lattarini wrote on Sat, Jan 15, 2011 at 02:23:56PM CET: > > On Saturday 15 January 2011, Ralf Wildenhues wrote: > > > Empty lines before @example and after @end example, and before > > > @noindent (the last two should be co

Re: [PATCH] Update docs w.r.t. warning and strictness options.

2011-01-15 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sat, Jan 15, 2011 at 02:23:56PM CET: > On Saturday 15 January 2011, Ralf Wildenhues wrote: > > * Stefano Lattarini wrote on Sat, Jan 15, 2011 at 12:41:16PM CET: > > > And here finally is the promised documentation patch, which should > > > conclude the patch series (thi

Re: Fix remake rule-induced test failures with HP-UX make.

2011-01-15 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sat, Jan 15, 2011 at 01:51:54PM CET: > On Saturday 15 January 2011, Ralf Wildenhues wrote: > > Quoting parts of: > > http://autobuild.josefsson.org/automake/log-201101150749395803000.txt [...] > > How about the patch below to not let this cause spurious testsuite > > fa

Re: [PATCH] Update docs w.r.t. warning and strictness options.

2011-01-15 Thread Stefano Lattarini
On Saturday 15 January 2011, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Sat, Jan 15, 2011 at 12:41:16PM CET: > > And here finally is the promised documentation patch, which should > > conclude the patch series (this time for good, I hope!). > > > > Thanks, and sorry for the delay, > >

Re: Fix remake rule-induced test failures with HP-UX make.

2011-01-15 Thread Ralf Wildenhues
[ adding autoconf-patches ] * Ralf Wildenhues wrote on Sat, Jan 15, 2011 at 11:31:55AM CET: > Quoting parts of: > http://autobuild.josefsson.org/automake/log-201101150749395803000.txt > I'm not quite sure why HP-UX make seems to trigger rebuild rules for > prerequisites that have the exact time s

Re: Fix remake rule-induced test failures with HP-UX make.

2011-01-15 Thread Stefano Lattarini
On Saturday 15 January 2011, Ralf Wildenhues wrote: > Quoting parts of: > http://autobuild.josefsson.org/automake/log-201101150749395803000.txt > > | FAIL: colon6.test (exit: 1) > | === > | > | > /tmp/am/build-hppa2.0w-hp-hpux11.23/tests:/tmp/local/hppa2.0w-hp-hpux11.23/b

Re: testsuite issues on MinGW/MSYS

2011-01-15 Thread Stefano Lattarini
On Saturday 15 January 2011, Ralf Wildenhues wrote: > Like this? > > Thanks, > Ralf > > 2011-01-15 Ralf Wildenhues > Stefano Lattarini > > tests: explain MSYS setup failure issue, improve test. > * tests/defs: Add comment and failure message, improve fail > logic

Re: testsuite issues on MinGW/MSYS

2011-01-15 Thread Stefano Lattarini
On Saturday 15 January 2011, Ralf Wildenhues wrote: > Like this? > > Thanks, > Ralf > > 2011-01-15 Ralf Wildenhues > Stefano Lattarini > > tests: explain MSYS setup failure issue, improve test. > * tests/defs: Add comment and failure message, improve fail > logic

Re: Fix libobj2.test failure with non-GNU make: define $(AR).

2011-01-15 Thread Stefano Lattarini
On Saturday 15 January 2011, Ralf Wildenhues wrote: > automake currently defines $(AR) only if it sees a _LIBRARIES primary. > That may be an issue or not (and the wrong value for cross setups that > it defines is definitely an issue), but not important for this test > IMVHO, > I agree with this (_

Re: [PATCH] Update docs w.r.t. warning and strictness options.

2011-01-15 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sat, Jan 15, 2011 at 12:41:16PM CET: > And here finally is the promised documentation patch, which should > conclude the patch series (this time for good, I hope!). > > Thanks, and sorry for the delay, No problem. Let's see if we can get through it quickly. I think

Re: tests: always update generated tests silently

2011-01-15 Thread Stefano Lattarini
On Saturday 15 January 2011, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Sat, Jan 15, 2011 at 12:26:24PM CET: > > As I wrote (or copied? I can't remember) in my pending documentation > > patch on silent rules support: > > > > @cindex default verbosity for silent-rules > > Note that sil

Re: testsuite issues on MinGW/MSYS

2011-01-15 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sat, Jan 15, 2011 at 12:07:45PM CET: > On Saturday 15 January 2011, Ralf Wildenhues wrote: > > I'm seeing a couple of weird issues on MinGW/MSYS. > > First of all, several spurious failures of this kind: > > > > ./defs: line 33: /bin/sed: Resource temporarily unavailab

[PATCH] Update docs w.r.t. warning and strictness options.

2011-01-15 Thread Stefano Lattarini
And here finally is the promised documentation patch, which should conclude the patch series (this time for good, I hope!). Thanks, and sorry for the delay, Stefano From 2d902e81c6b2fbb939c8b6a3d1c744dfbf03655c Mon Sep 17 00:00:00 2001 From: Stefano Lattarini Date: Fri, 14 Jan 2011 15:18:36 +0

Re: tests: always update generated tests silently

2011-01-15 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sat, Jan 15, 2011 at 12:26:24PM CET: > As I wrote (or copied? I can't remember) in my pending documentation > patch on silent rules support: > > @cindex default verbosity for silent-rules > Note that silent rules are @emph{disabled} by default; the user must > enabl

Re: tests: always update generated tests silently

2011-01-15 Thread Stefano Lattarini
ESENDTOOSOON, sorry. On Saturday 15 January 2011, Ralf Wildenhues wrote: > Or should we go the next step and use AM_SILENT_RULES([yes])? A possible mediation would be to enable silent by default only in builds done from a cloned git repository. I've done something similar already (caveat: for to

Re: tests: always update generated tests silently

2011-01-15 Thread Stefano Lattarini
Hello Ralf. On Saturday 15 January 2011, Ralf Wildenhues wrote: > Reading the log files, I notice that I forgot to use > --enable-silent-rules throughout, so that all the test generation is > done verbosely and a bit annoying when reading the log files. Now, even > if I won't forget again, our us

Re: testsuite issues on MinGW/MSYS

2011-01-15 Thread Stefano Lattarini
On Saturday 15 January 2011, Ralf Wildenhues wrote: > I'm seeing a couple of weird issues on MinGW/MSYS. > First of all, several spurious failures of this kind: > > ./defs: line 33: /bin/sed: Resource temporarily unavailable > > The line in question is: > me=`echo "$argv0" | sed -e 's,.*[\\/],,

Fix libobj2.test failure with non-GNU make: define $(AR).

2011-01-15 Thread Ralf Wildenhues
automake currently defines $(AR) only if it sees a _LIBRARIES primary. That may be an issue or not (and the wrong value for cross setups that it defines is definitely an issue), but not important for this test IMVHO, so how about this patch to avoid a spurious test failure as in http://autobuild.jo

Fix remake rule-induced test failures with HP-UX make.

2011-01-15 Thread Ralf Wildenhues
Quoting parts of: http://autobuild.josefsson.org/automake/log-201101150749395803000.txt | FAIL: colon6.test (exit: 1) | === | | /tmp/am/build-hppa2.0w-hp-hpux11.23/tests:/tmp/local/hppa2.0w-hp-hpux11.23/bin:/tmp/bin:/opt/aCC/bin:/opt/ansic/bin:/bin:/usr/bin:/sbin:/usr/sbi

Re: [PATCH] tests: fix comment typo

2011-01-15 Thread Ralf Wildenhues
Hi Jim, * Jim Meyering wrote on Sat, Jan 15, 2011 at 10:49:07AM CET: > It looks like I never sent this patch: Thanks. I added a ChangeLog entry, bumped copyright years, and pushed to maint. Cheers, Ralf > From 2a898e3a7bc80dac3506f8ef325a95ef375971ef Mon Sep 17 00:00:00 2001 > From: Jim Meyeri

[PATCH] tests: fix comment typo

2011-01-15 Thread Jim Meyering
Hi guys, It looks like I never sent this patch: >From 2a898e3a7bc80dac3506f8ef325a95ef375971ef Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Thu, 14 Oct 2010 16:39:22 +0200 Subject: [PATCH] tests: fix comment typo * tests/substref.test: Fix grammar in a comment. --- tests/substref.test |

Avoid VPATH-related distcheck failures with non-GNU make

2011-01-15 Thread Ralf Wildenhues
OK, so all the added '$MAKE distcheck' "for safety" at the end of the tests caused roughly a thousand new test failures across the board, it seems, drowning other signals. Most of these failures apparently have two reasons: 1) Cleanup failed to remove some directory because of stale NFS handles,

tests: always update generated tests silently

2011-01-15 Thread Ralf Wildenhues
Reading the log files, I notice that I forgot to use --enable-silent-rules throughout, so that all the test generation is done verbosely and a bit annoying when reading the log files. Now, even if I won't forget again, our users likely will. Would you mind just generating them completely silently

Re: [PATCH 2/5] Tests defs: new subroutine `skip' for test skipping.

2011-01-15 Thread Ralf Wildenhues
Hi Stefano, * Stefano Lattarini wrote on Mon, Nov 15, 2010 at 06:23:21PM CET: > Tests defs: new subroutine `skip' for test skipping. I don't like having this patch alone. If we switch to functions, then we should so wholesale, and at once, and fully. Also, there is precedent in {coreutils,gnuli

Re: [PATCH 1/5] Tests defs: don't let useless variables leak in test scripts.

2011-01-15 Thread Ralf Wildenhues
Hi Stefano, and apologies for the long delay, there were three patches in this series that haven't been reviewed yet: * Stefano Lattarini wrote on Mon, Nov 15, 2010 at 06:21:16PM CET: > * tests/defs ($priv_check_temp, $overwrite_status, $ro_dir_temp, > $create_status, $r2h, $libtool_found, $gette

Re: [PATCH 3/5] Tests defs: some cleanup and minor fixes.

2011-01-15 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Mon, Nov 15, 2010 at 06:24:52PM CET: > * tests/defs: Exit with status 99 (hard error) rather than > 1 (failure) on unexpected/internal errors, or when a signal > is caught by the client script. > Some minor changes in spacing and formatting. > ($extra_includes): Variabl

testsuite issues on MinGW/MSYS

2011-01-15 Thread Ralf Wildenhues
I'm seeing a couple of weird issues on MinGW/MSYS. First of all, several spurious failures of this kind: ./defs: line 33: /bin/sed: Resource temporarily unavailable The line in question is: me=`echo "$argv0" | sed -e 's,.*[\\/],,;s/\.test$//'` This is on a loaded system, but I don't remember h

Hide warnings from wait

2011-01-15 Thread Ralf Wildenhues
On Cygwin, depcomp2.test failed due to this in stderr: ./configure: line 3393: wait: pid 3856 is not a child of this shell Let's hide it, it only confuses the user. (Posix documents that the shell does not wait for PIDs reused by unrelated processes.) I'm merging this patch from the resurrected

autobuild logs

2011-01-15 Thread Ralf Wildenhues
I've put up a set of logs at http://autobuild.josefsson.org/automake/ again. Quite a few new failures, so I think some maintenance work is warranted. Cheers, Ralf