Re: [PATCH 4/9] Warnings win over strictness in AM_INIT_AUTOMAKE.

Hi Stefano, * Stefano Lattarini wrote on Tue, Jan 04, 2011 at 06:38:04PM CET: > This is derived from [PATCH 07/10] of the older series. > It requires a review. Thank you for rewriting the patch. See below for comments. > Warnings win over strictness in AM_INIT_AUTOMAKE. > > This change ensures

[PATCH 9/9] More checks on warnings/strictness precedence.

And finally, this is [PATCH 12/10] of the older series, which has already been reviewed and ACK'd "with nits addressed" (so that a new review shouldn't be required). The amended patch is attached, for completeness. Regards, Stefano From dadebf78442e002ed12952e91f40a9464c0385c3 Mon Sep 17 00:00

[PATCH 8/9] Update NEWS about the warnings-over-strictness precedence.

This is [PATCH 11/10] of the older series, which has already been reviewed and ACK'd "with nits addressed", so a new review shouldn't be required. Anyway, the amended patch is attached, for completeness. Regards, Stefano From 2f6a606fea2c06de56fd208f18ff8c72838465ff Mon Sep 17 00:00:00 2001 F

[PATCH 7/9] Warnings win over strictness in AUTOMAKE_OPTIONS.

This is derived from [PATCH 10/10] of the older series. It requires a review. Thanks, Stefano -*-*- Warnings win over strictness in AUTOMAKE_OPTIONS. This change ensures that, for what concerns the options specified in AUTOMAKE_OPTIONS, explicitly-defined warnings always take precedence ove

[PATCH 6/9] Change signature of 'Automake::Options::_process_option_list()'.

This is derived from [PATCH 09/10] of the older series. It requires a review. Thanks, Stefano -*-*- Change signature of 'Automake::Options::_process_option_list()'. This only modifies internal details in the automake implementation, bearing no externally visible effect, but preparing the way

[PATCH 5/9] Add more tests about AUTOMAKE_OPTIONS.

This is [PATCH 08/10] of the older series, with the various suggestions incorporated. It has been already given an ACK, so a new review shouldn't be required. The amended patch is attached anywawy, for completeness. Regards, Stefano From 3f5fcec6c76763102356dd2516452d519bac0cb7 Mon Sep 17 00:0

[PATCH 4/9] Warnings win over strictness in AM_INIT_AUTOMAKE.

This is derived from [PATCH 07/10] of the older series. It requires a review. Thanks, Stefano -*-*- Warnings win over strictness in AM_INIT_AUTOMAKE. This change ensures that, for what concerns the options specified in AM_INIT_AUTOMAKE, explicitly-defined warnings always take precedence ove

[PATCH 3/9] Warnings win over strictness on command line.

This patch has already been reviewed and ACK'd "with nits addressed", so a new review shouldn't be required. Anyway, the amended patch is attached, for completeness. Regards, Stefano From da2c92fe261e9ea6132f24ba0fddf32a0119e12e Mon Sep 17 00:00:00 2001 From: Stefano Lattarini Date: Mon, 20 De

[PATCH 2/9] New test on silent-rules mode and portability warnings.

This patch has already been reviewed and ACK'd (with the suggested renaming "silent-rules-nowarn.test" => "silent-nowarn.test"), so a new review shouldn't be required. Anyway, the amended patch is attached, for completeness. Regards, Stefano From 894bf2947894df080352f3231f8b87527e9cd508 Mon Se

[PATCH 1/9] Add new tests on strictness and warnings precedence and overriding.

[Sorry for the delay] This patch has already been reviewed and ACK'd "with nits addressed", so a new review shouldn't be required. Anyway, the amended patch is attached, for completeness. Regards, Stefano From db06f9f159c307fdb469cdf44b3ff2f95f2ef0f2 Mon Sep 17 00:00:00 2001 From: Stefano Lat

[PATCH v2 0/9] Explicit warning levels must always take precedence over those implied by the strictness

Hello automakers. This is the second respin of this patch series [1][2], following the remarks and suggestions offered here by Ralf Wildenhues: [1] Here is a link to the first version of the series:

Re: [PATCH] {master} Tests: normalize use of the 'errexit' shell flag.

On Monday 03 January 2011, Ralf Wildenhues wrote: > Hi Stefano, > > * Stefano Lattarini wrote on Mon, Jan 03, 2011 at 03:04:05PM CET: > > * tests/maken3.test (check_targets): Remove redundant call to > > 'set -e'. > > * tests/maken4.test: Likewise. > > * tests/ansi5.test: Call 'set -e' just after

Re: [PATCH 04/10] Refactoring: new $automake_remake_options global variable.

On Monday 03 January 2011, Ralf Wildenhues wrote: > > [BIG CUT] > ... > So no, without an argument why the refactoring is necessary in order to > fix the bug (rather than just understand it), I'm sorry but I have to > reject it, on the grounds that it causes a net code quality regression. > W