Re: maintainer checks

2010-11-20 Thread Stefano Lattarini
On Saturday 20 November 2010, Ralf Wildenhues wrote: > For what it's worth, file:line notation is not ideal because it is > maintenance-intensive for files which change regularly. > Just to be clear: my script support *both* the "file:line" notation and the "file" noation. The support for "file:r

Re: maintainer checks

2010-11-20 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sat, Nov 20, 2010 at 04:33:18PM CET: > On Saturday 20 November 2010, Ralf Wildenhues wrote: > > * Stefano Lattarini wrote on Tue, Nov 16, 2010 at 12:15:12AM CET: > > > > > > > > > > Gnulib has

maintainer checks (was: Re: [PATCH] {maint} Improve and extend tests on de-ansification support.)

2010-11-20 Thread Stefano Lattarini
On Saturday 20 November 2010, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Tue, Nov 16, 2010 at 12:15:12AM CET: > > On Monday 15 November 2010, Ralf Wildenhues wrote: > > > > > > Well then we should adjust maintainer-check to not complain. Either > > > way, maintainer-check results shoul

Re: [PATCH 4/5] Tests defs: avoid some useless subshells.

2010-11-20 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sat, Nov 20, 2010 at 02:14:57PM CET: > On Saturday 20 November 2010, Ralf Wildenhues wrote: > > * Stefano Lattarini wrote on Mon, Nov 15, 2010 at 06:26:05PM CET: > > ># Generic case: the tool must support --version. > > >echo "$me: running $tool --versio

Re: [PATCH 0/5] More patches for the tests-init branch

2010-11-20 Thread Stefano Lattarini
On Saturday 20 November 2010, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Mon, Nov 15, 2010 at 06:18:15PM CET: > > Tests defs: don't let useless variables leak in test scripts. > > Tests defs: new subroutine `skip' for test skipping. > > Tests defs: some cleanup and minor fixes. >

Re: [PATCH 5/5] Tests required tools: also try `-v' option for GNU compilers.

2010-11-20 Thread Stefano Lattarini
On Saturday 20 November 2010, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Mon, Nov 15, 2010 at 06:27:43PM CET: > > * tests/defs.in: In the loop on "$required" tools, for gcc > > and g++, also run "gcc -v" (resp. "g++ -v"), to get more > > information, and for consistency with gcj. > > Di

Re: [PATCH 4/5] Tests defs: avoid some useless subshells.

2010-11-20 Thread Stefano Lattarini
On Saturday 20 November 2010, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Mon, Nov 15, 2010 at 06:26:05PM CET: > > * tests/defs: In the loop on "$required" tools: avoid subshells > > where not neded. > > OK except for the last hunk: > > > --- a/tests/defs > > +++ b/tests/defs > > > @@

Re: [PATCH 0/5] More patches for the tests-init branch

2010-11-20 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Mon, Nov 15, 2010 at 06:18:15PM CET: > Tests defs: don't let useless variables leak in test scripts. > Tests defs: new subroutine `skip' for test skipping. > Tests defs: some cleanup and minor fixes. > No "ticking clock" for this patches at the moment; the clock

Re: [PATCH 5/5] Tests required tools: also try `-v' option for GNU compilers.

2010-11-20 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Mon, Nov 15, 2010 at 06:27:43PM CET: > * tests/defs.in: In the loop on "$required" tools, for gcc > and g++, also run "gcc -v" (resp. "g++ -v"), to get more > information, and for consistency with gcj. Did this help you for anything in any way? Patch is OK. Thanks, R

Re: [PATCH 4/5] Tests defs: avoid some useless subshells.

2010-11-20 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Mon, Nov 15, 2010 at 06:26:05PM CET: > * tests/defs: In the loop on "$required" tools: avoid subshells > where not neded. OK except for the last hunk: > --- a/tests/defs > +++ b/tests/defs > @@ -297,12 +297,12 @@ do > *) ># Generic case: the tool must s

Re: [RFC] Docs: document silent make rules in a new chapter

2010-11-20 Thread Stefano Lattarini
On Saturday 20 November 2010, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Thu, Nov 18, 2010 at 09:22:48PM CET: > > On Thursday 18 November 2010, Nick Bowler wrote: > > > On 2010-11-18 20:31 +0100, Stefano Lattarini wrote: > > > > +...@vindex @code{AM_V_GEN} > > > > +...@c FIXME: wouldn't

Re: [PATCH 0/2] {master} Remove long-deprecated `--output-dir' automake option.

2010-11-20 Thread Stefano Lattarini
On Saturday 20 November 2010, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Thu, Nov 18, 2010 at 06:29:57PM CET: > > On Thursday 18 November 2010, Stefano Lattarini wrote: > > > The `--output-dir' option of automake has been deprecated since versions > > > 1.6.1 and 1.7, but then never remo

Re: [PATCH] {master} release-stats: account for generated `instspc-*.test' tests.

2010-11-20 Thread Stefano Lattarini
I pushed this: -*-*-*- release-stats: account for more generated tests. * Makefile.am (release-stats): Be sure to take into account all the generated tests, by grepping the test scripts to decide which ones of them are automatically generated. --- ChangeLog |7 +++ Makefile.am |2

Re: [PATCH] {master} release-stats: account for generated `instspc-*.test' tests.

2010-11-20 Thread Stefano Lattarini
On Saturday 20 November 2010, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Fri, Nov 19, 2010 at 09:18:33PM CET: > > I've realized that my patch on instspc.test split & refactoring has > > broken the "release-stats" target, since now there are other generated > > tests besides the `*-p.test

Re: [PATCH] {maint} Improve and extend tests on de-ansification support.

2010-11-20 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Tue, Nov 16, 2010 at 12:15:12AM CET: > On Monday 15 November 2010, Ralf Wildenhues wrote: > > > > Well then we should adjust maintainer-check to not complain. Either > > way, maintainer-check results should not deteriorate. > I'm not keen on meddling with the current

libtool --help: honor $AUTOCONF, $AUTOMAKE

2010-11-20 Thread Ralf Wildenhues
I came across an interesting bug: the perl coverage output for a full run of the Automake test suite was showing a single invocation of the installed automake program, rather than the uninstalled $builddir/tests/automake-1.11a which should have been run. Some tracking revealed that this happene

Re: [RFC] Docs: document silent make rules in a new chapter

2010-11-20 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Thu, Nov 18, 2010 at 09:22:48PM CET: > On Thursday 18 November 2010, Nick Bowler wrote: > > On 2010-11-18 20:31 +0100, Stefano Lattarini wrote: > > > +...@vindex @code{AM_V_GEN} > > > +...@c FIXME: wouldn't $(AM_V_SILENT) be clearer? Should we deprecate > > > +...@c $(