Re: [PATCH v2] Overhauled and modularized tests in `instspc.test'.

2010-11-03 Thread Stefano Lattarini
On Wednesday 03 November 2010, Ralf Wildenhues wrote: > Hi Stefano, > > * Stefano Lattarini wrote on Wed, Nov 03, 2010 at 03:10:30PM CET: > > On Friday 24 September 2010, Stefano Lattarini wrote: > > > Now that I've run all those tests (whose results are posted in this > > > thread), ok to push t

Re: [PATCH v2] Overhauled and modularized tests in `instspc.test'.

2010-11-03 Thread Ralf Wildenhues
Hi Stefano, * Stefano Lattarini wrote on Wed, Nov 03, 2010 at 03:10:30PM CET: > On Friday 24 September 2010, Stefano Lattarini wrote: > > Now that I've run all those tests (whose results are posted in this > > thread), ok to push to master? > > > Pinging the patch again, following this: >

Re: tests updates

2010-11-03 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Wed, Nov 03, 2010 at 02:27:47PM CET: > On Monday 01 November 2010, Ralf Wildenhues wrote: > > I'm so totally behind on patches and not getting better, that the > > strategy of ignoring testsuite work will not help either. So how about > > the following. IIRC you sugge

Re: [PATCH] New tests on obsoleted usages of automake/autoconf macros.

2010-11-03 Thread Stefano Lattarini
Pinging this patch again, following this: I've also re-based the patch off of latest maint, extended some checks a little bit, fixed a typo in comments, and fixed some very minor and theoretic portability problems (use of

Re: More problems with `make -n' in automake-generated rules.

2010-11-03 Thread Stefano Lattarini
Hello Ralf. Again, just a couple of nits w.r.t. the test cases... On Monday 01 November 2010, Ralf Wildenhues wrote: > * Ralf Wildenhues wrote on Mon, Nov 01, 2010 at 10:18:55PM CET: > > 3) The rules to update Makefile, but also those to update and > > Makefile.in, are broken in some circumstance

Re: More problems with `make -n' in automake-generated rules.

2010-11-03 Thread Stefano Lattarini
Hi Ralf. Thanks for these fixes, I really think that "make -n" should really be dry-run if possible. On Monday 01 November 2010, Ralf Wildenhues wrote: > I noticed more issues with automake-generated rules and `make -n': > > 1) The solutions documented in the `Multiple Outputs' node are not safe

Re: [PATCH] aclocal: handle ACLOCAL_PATH environment variable

2010-11-03 Thread Stefano Lattarini
On Wednesday 03 November 2010, Paolo Bonzini wrote: > On 11/03/2010 04:24 PM, Stefano Lattarini wrote: > >> + # Add any directory listed in the `ACLOCAL_PATH' environment > >> + # variable. > >> + if (defined $ENV{"ACLOCAL_PATH"}) > >> +{ > >> + foreach my $dir (split /:/, $ENV{"ACLOCAL

Re: [PATCH] aclocal: handle ACLOCAL_PATH environment variable

2010-11-03 Thread Paolo Bonzini
On 11/03/2010 04:24 PM, Stefano Lattarini wrote: + # Add any directory listed in the `ACLOCAL_PATH' environment + # variable. + if (defined $ENV{"ACLOCAL_PATH"}) +{ + foreach my $dir (split /:/, $ENV{"ACLOCAL_PATH"}) Shouldn't we use `...@path_separator@' here instead of `:', for bet

Re: [PATCH] aclocal: handle ACLOCAL_PATH environment variable

2010-11-03 Thread Stefano Lattarini
On Tuesday 02 November 2010, Paolo Bonzini wrote: > Hi all, this patch provides a fourth scheme of adding directories to > the search path. It is a simple colon-separated list of directories > (without globbing). > > It is useful when you're using a global installation of Automake but > you want

Re: [PATCH v2] Overhauled and modularized tests in `instspc.test'.

2010-11-03 Thread Stefano Lattarini
On Friday 24 September 2010, Stefano Lattarini wrote: > Now that I've run all those tests (whose results are posted in this > thread), ok to push to master? > Pinging the patch again, following this: Note that this patch

Re: tests updates

2010-11-03 Thread Stefano Lattarini
On Monday 01 November 2010, Ralf Wildenhues wrote: > Hi Stefano, Hi Ralf, and thanks for bringing this up again. > I'm so totally behind on patches and not getting better, that the > strategy of ignoring testsuite work will not help either. So how about > the following. IIRC you suggested a bran

[PATCH] aclocal: handle ACLOCAL_PATH environment variable

2010-11-03 Thread Paolo Bonzini
Hi all, this patch provides a fourth scheme of adding directories to the search path. It is a simple colon-separated list of directories (without globbing). It is useful when you're using a global installation of Automake but you want to add directories from your account as well to the search pat