Re: [PATCH] {maint} Tests: fix requirement of m4 files

On Sunday 26 September 2010, Stefano Lattarini wrote: > On Sunday 26 September 2010, Ralf Wildenhues wrote: > > * Stefano Lattarini wrote on Sun, Sep 26, 2010 at 12:46:56PM CEST: > > > On Sunday 26 September 2010, Ralf Wildenhues wrote: > > > > * Stefano Lattarini wrote on Fri, Sep 24, 2010 at 01:0

Re: [SIMPLE PATCH] {maint} Add test for `AM_WITH_DMALLOC' macro.

On Sunday 26 September 2010, Stefano Lattarini wrote: > On Sunday 26 September 2010, Ralf Wildenhues wrote: > > * Stefano Lattarini wrote on Sun, Sep 26, 2010 at 09:51:11PM CEST: > > > On Sunday 26 September 2010, Ralf Wildenhues wrote: > > > > * Stefano Lattarini wrote on Tue, Sep 21, 2010 at 12:5

Re: [SIMPLE PATCH] {maint} Add test for `AM_WITH_DMALLOC' macro.

On Sunday 26 September 2010, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Sun, Sep 26, 2010 at 09:51:11PM CEST: > > On Sunday 26 September 2010, Ralf Wildenhues wrote: > > > * Stefano Lattarini wrote on Tue, Sep 21, 2010 at 12:57:10PM CEST: > > > > +dnl Let's show some good practices ;-)

Re: [SIMPLE PATCH] {maint} Add test for `AM_WITH_DMALLOC' macro.

* Stefano Lattarini wrote on Sun, Sep 26, 2010 at 09:51:11PM CEST: > On Sunday 26 September 2010, Ralf Wildenhues wrote: > > * Stefano Lattarini wrote on Tue, Sep 21, 2010 at 12:57:10PM CEST: > > > +dnl Let's show some good practices ;-) > > > +AC_SUBST([AM_LDFLAGS], [$LDFLAGS]) > > > > This is no

[PATCH 2/3] Refactoring: less AC_SUBST'd stuff in automake.in.

* lib/Automake/Config.in ($PACKAGE_URL): New AC_SUBST'd variable. (@EXPORT): Update. * lib/Automake/Makefile.am (Config.pm): Update substitution rule. * automake.in (usage): Use `$PACKAGE_BUGREPORT' and `$PACKAGE_URL' rather than `...@package_bugreport@' and `...@package_url@' * aclocal.in (usage):

[PATCH 1/3] Refactoring: new module `Automake::Language'.

* lib/Automake/Language.pm: New module, extracted from script `automake.in'. * lib/Automake/Makefile.am (dist_perllib_DATA): Updated. * automake.in: Remove code moved into new `Automake::Language' module, and related changes. --- ChangeLog|7 +++ automake.in | 89

[PATCH 0/3] Refactoring: move automake code in a new module `Automake::Main'

Hello automakers. This patch series moves almost all the code of automake from the `automake.in' script into the new module `Automake::Main'. This should improve unit-testability right away, and simplify a prospective refactoring of Automake codebase in the long run. OK to apply the patches to a

Re: [SIMPLE PATCH] {maint} Add test for `AM_WITH_DMALLOC' macro.

On Sunday 26 September 2010, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Tue, Sep 21, 2010 at 12:57:10PM CEST: > > The macro `AM_WITH_DMALLOC' is not checked by the testsuite. > > The attached pach should provide at least a minimal coverage. > > OK for maint? > > OK with nits addressed.

Re: [SIMPLE PATCH] {maint} Add test for `AM_WITH_DMALLOC' macro.

* Stefano Lattarini wrote on Tue, Sep 21, 2010 at 12:57:10PM CEST: > The macro `AM_WITH_DMALLOC' is not checked by the testsuite. > The attached pach should provide at least a minimal coverage. > OK for maint? OK with nits addressed. Thanks. > Subject: [PATCH] Add test for `AM_WITH_DMALLOC' macr

Re: [PATCH v3] Work around a bug in Solaris make's file-inclusion mechanism.

On Sunday 26 September 2010, Ralf Wildenhues wrote: > Hello Stefano, > > * Stefano Lattarini wrote on Thu, Sep 23, 2010 at 12:18:07AM CEST: > > Subject: [PATCH] Work around a bug in file-inclusion mechanism of > > Solaris make. > > > > * automake.in (handle_single_transform): In the name of the >

Re: [PATCH v3] Work around a bug in Solaris make's file-inclusion mechanism.

Hello Stefano, * Stefano Lattarini wrote on Thu, Sep 23, 2010 at 12:18:07AM CEST: > Subject: [PATCH] Work around a bug in file-inclusion mechanism of Solaris > make. > > * automake.in (handle_single_transform): In the name of the > dependency file: collapse multiple slash characters into a singl

Re: [SIMPLE PATCH] {maint} Extend tests on `--help' and `--version' options.

Attached is what I pushed. I also merged to master and branch-1.11. Regards, Stefano From a82bc0d5cfea18fc96476c23a4fb2d458af09c89 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini Date: Sat, 25 Sep 2010 17:07:27 +0200 Subject: [PATCH] Extend tests on `--help' and `--version' options. * tests

Re: [PATCH] {maint} Tests: fix requirement of m4 files

On Sunday 26 September 2010, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Sun, Sep 26, 2010 at 12:46:56PM CEST: > > On Sunday 26 September 2010, Ralf Wildenhues wrote: > > > * Stefano Lattarini wrote on Fri, Sep 24, 2010 at 01:00:02AM CEST: > > > > While testing my recent patches, I found

Re: [PATCH v3 2/?] Work around a bug in Solaris make's file-inclusion mechanism.

On Sunday 26 September 2010, Ralf Wildenhues wrote: > Hi Stefano, > > * Stefano Lattarini wrote on Sun, Sep 26, 2010 at 11:58:09AM CEST: > > On Sunday 26 September 2010, Ralf Wildenhues wrote: > > > * Stefano Lattarini wrote on Fri, Sep 24, 2010 at 04:38:29PM CEST: > > > > Then we could proceed t

Re: [PATCH] {maint} Tests: fix requirement of m4 files

* Stefano Lattarini wrote on Sun, Sep 26, 2010 at 12:46:56PM CEST: > On Sunday 26 September 2010, Ralf Wildenhues wrote: > > * Stefano Lattarini wrote on Fri, Sep 24, 2010 at 01:00:02AM CEST: > > > While testing my recent patches, I found a nasty weakness in the > > > testsuite (a real weakness thi

Re: [SIMPLE PATCH] {maint} Extend tests on `--help' and `--version' options.

* Stefano Lattarini wrote on Sun, Sep 26, 2010 at 11:39:38AM CEST: > On Sunday 26 September 2010, Ralf Wildenhues wrote: > > > > Well the patch surely makes it clear why $curdir was a badly chosen > > name: it is not clear at which time this directory was "current". > There's a pending patch (for

Re: [PATCH v3 2/?] Work around a bug in Solaris make's file-inclusion mechanism.

Hi Stefano, * Stefano Lattarini wrote on Sun, Sep 26, 2010 at 11:58:09AM CEST: > On Sunday 26 September 2010, Ralf Wildenhues wrote: > > * Stefano Lattarini wrote on Fri, Sep 24, 2010 at 04:38:29PM CEST: > > > Then we could proceed to refactoring, and split it up in several > > > separate modules

Re: [PATCH] {maint} Tests: fix requirement of m4 files

On Sunday 26 September 2010, Ralf Wildenhues wrote: > Hello Stefano, > > * Stefano Lattarini wrote on Fri, Sep 24, 2010 at 01:00:02AM CEST: > > While testing my recent patches, I found a nasty weakness in the > > testsuite (a real weakness this time, not a theoretical one ;-). > > I'm sorry, but

Re: [FYI] patch pushed

On Sunday 26 September 2010, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Sat, Sep 25, 2010 at 03:23:50PM CEST: > > To reduce the already too long patch queue a bit, I've reversed > > the controversial change "cvs add" => "git add", and pushed. > > Thanks! > > (not that it would make my

Re: [PATCH v3 2/?] Work around a bug in Solaris make's file-inclusion mechanism.

On Sunday 26 September 2010, Ralf Wildenhues wrote: > Hello Stefano, > > * Stefano Lattarini wrote on Fri, Sep 24, 2010 at 04:38:29PM CEST: > > On Wednesday 15 September 2010, Ralf Wildenhues wrote: > > > I don't think we want subobj11c.test. What we want instead, > > > and I agree with your earl

Re: [SIMPLE PATCH] {maint} Extend tests on `--help' and `--version' options.

On Sunday 26 September 2010, Ralf Wildenhues wrote: > Hi Stefano, > > * Stefano Lattarini wrote on Sat, Sep 25, 2010 at 05:35:31PM CEST: > > OK for maint? > > Well the patch surely makes it clear why $curdir was a badly chosen > name: it is not clear at which time this directory was "current". Th

Re: [FYI] patch pushed

* Stefano Lattarini wrote on Sat, Sep 25, 2010 at 03:23:50PM CEST: > To reduce the already too long patch queue a bit, I've reversed > the controversial change "cvs add" => "git add", and pushed. Thanks! (not that it would make my queue shorter, as I try to read every patch anyway, but I see that