Re: [SIMPLE PATCH] {maint} Extend tests on `--help' and `--version' options.

2010-09-25 Thread Ralf Wildenhues
* Ralf Wildenhues wrote on Sun, Sep 26, 2010 at 08:40:48AM CEST: > * Stefano Lattarini wrote on Sat, Sep 25, 2010 at 05:35:31PM CEST: > > -$ACLOCAL --version > > -$ACLOCAL --help > > -$AUTOMAKE --version > > -$AUTOMAKE --help > > +"$curdir/aclocal-$APIVERSION" --version > > +"$curdir/aclocal-$APIVE

Re: [PATCH v3 2/?] Work around a bug in Solaris make's file-inclusion mechanism.

2010-09-25 Thread Ralf Wildenhues
Hello Stefano, * Stefano Lattarini wrote on Fri, Sep 24, 2010 at 04:38:29PM CEST: > On Wednesday 15 September 2010, Ralf Wildenhues wrote: > > I don't think we want subobj11c.test. What we want instead, and I > > agree with your earlier sentiments on this, is unit testing for the > > normalize_fi

Re: [SIMPLE PATCH] {maint} Extend tests on `--help' and `--version' options.

2010-09-25 Thread Ralf Wildenhues
Hi Stefano, * Stefano Lattarini wrote on Sat, Sep 25, 2010 at 05:35:31PM CEST: > OK for maint? Well the patch surely makes it clear why $curdir was a badly chosen name: it is not clear at which time this directory was "current". I have nits below. > Extend tests on `--help' and `--version' opti

Re: [PATCH] {maint} Tests: fix requirement of m4 files

2010-09-25 Thread Ralf Wildenhues
Hello Stefano, * Stefano Lattarini wrote on Fri, Sep 24, 2010 at 01:00:02AM CEST: > While testing my recent patches, I found a nasty weakness in the > testsuite (a real weakness this time, not a theoretical one ;-). I'm sorry, but I have to disagree with you on this one. When you install Automa

Re: [SIMPLE PATCH] {maint} Testsuite: Use `$PATH_SEPARATOR', not `:', when extending PATH.

2010-09-25 Thread Ralf Wildenhues
Hi Stefano, * Stefano Lattarini wrote on Sat, Sep 25, 2010 at 09:35:20PM CEST: > OK for maint? This will also let me get rid of some "FIXME"s in > various pending patches. OK, thanks! Cheers, Ralf > Testsuite: Use `$PATH_SEPARATOR', not `:', when extending PATH. > > * tests/compile2.test: Do

[SIMPLE PATCH] {maint} Testsuite: Use `$PATH_SEPARATOR', not `:', when extending PATH.

2010-09-25 Thread Stefano Lattarini
OK for maint? This will also let me get rid of some "FIXME"s in various pending patches. Regards, Stefano -*-*-*- Testsuite: Use `$PATH_SEPARATOR', not `:', when extending PATH. * tests/compile2.test: Do no uselessly (implicitly) repeat the computation of PATH_SEPARATOR again. * tests/instma

[SIMPLE PATCH] {maint} Extend tests on `--help' and `--version' options.

2010-09-25 Thread Stefano Lattarini
OK for maint? Regards, Stefano -*-*-*- Extend tests on `--help' and `--version' options. * tests/help.test: Create a new empty directory and chdir into it, rather than removing already present files. Run the aclocal and automake wrapper scripts directly, instead of relying on $AUTOMAKE and

[FYI] Testsuite: new vars `$PATH_SEPARATOR' and `$APIVERSION'.

2010-09-25 Thread Stefano Lattarini
I pushed the following patch to maint as obvious. The changes it introduces will be required by future patches. Regards, Stefano -*-*- Testsuite: new vars `$PATH_SEPARATOR' and `$APIVERSION'. * tests/defs.in ($APIVERSION): New AC_SUBST'd variable. ($ACLOCAL, $AUTOMAKE): Use it. ($PATH_SEPAR

Re: [SIMPLE PATCH] {maint} Manual: index refer to target "git-dist", not "cvs-dist".

2010-09-25 Thread Stefano Lattarini
Pushed. Regards, Stefano

[FYI] patch pushed (was: [PATCH] "Manual: be more agnostic w.r.t. version control system used.)

2010-09-25 Thread Stefano Lattarini
Hi Ralf. To reduce the already too long patch queue a bit, I've reversed the controversial change "cvs add" => "git add", and pushed. Regards, Stefano