Re: [PATCH] {branch "msvc"} Fix typo in test ar-lib.test.

2010-09-02 Thread Peter Rosin
Hi Stefano! Den 2010-09-03 02:48 skrev Stefano Lattarini: > OK to push the attached patch to msvc as trivial? No, because it isn't a typo... :-) Wrappee denotes the thing that is wrapped. Cheers, Peter

[PATCH] {branch "msvc"} Fix typo in test ar-lib.test.

2010-09-02 Thread Stefano Lattarini
OK to push the attached patch to msvc as trivial? Regards, Stefano From d105644a7216dd765d189a1c22a533e64c7b9468 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini Date: Fri, 3 Sep 2010 02:45:02 +0200 Subject: [PATCH] Fix typo in test ar-lib.test. * tests/ar-lib.test: Fix typo: "wrappee" -> "w

Re: [PATCH] Testsuite: use $SHELL to run tests which are shell scripts.

2010-09-02 Thread Stefano Lattarini
On Thursday 02 September 2010, Stefano Lattarini wrote: > > The patch has obvious advantages though. How to best ameliorate > > the disadvantages? > > Hmm... maybe by making `tests/defs' re-execute the current test > with $CONFIG_SHELL unless a proper environment variable (let's say > `AM_TESTSUI

[PATCH 4/4] {branch "tests-init"} Tests defs: $srcdir and $top_srcdir renaming.

2010-09-02 Thread Stefano Lattarini
* tests/defs.in ($srcdir): Remove, define $testsrcdir directly. ($top_srcdir): Renamed to ... ($top_testsrcdir): ... to this, for consistency. * tests/aclocal.test: All uses changed. * tests/auxdir.test: Likewise. * tests/compile.test: Likewise. * tests/compile2.test: Likewise. * tests/mkinst3.test

[PATCH 3/4] {branch "tests-init"} Tests defs: remove variable $testaclocaldir.

2010-09-02 Thread Stefano Lattarini
* tests/defs.in ($testaclocaldir): Removed. * tests/aclocal.test: Use `$top_srcdir/m4', not `$testaclocaldir'. --- ChangeLog |4 tests/aclocal.test |2 +- tests/defs.in |2 -- 3 files changed, 5 insertions(+), 3 deletions(-) From c59962b21c880e7f70d222565e1fea489ed20

Re: [PATCH 2/4] {branch "tests-init"} Tests defs: new variable $top_srcdir.

2010-09-02 Thread Stefano Lattarini
* tests/defs.in ($top_srcdir): Define unconditionally to @abs_top_src...@. Use it throughout. * tests/ar-lib.test: Use `$top_srcdir' instead of `$testsrcdir/..'. * tests/auxdir.test: Likewise. * tests/compile.test: Likewise. * tests/compile2.test: Likewise. * tests/compile3.test: Likewise. * tests

[PATCH 1/4] {branch "tests-init"} Tests defs: $srcdir is unconditionally substituted.

2010-09-02 Thread Stefano Lattarini
* tests/defs.in ($srcdir): Define unconditionally to @abs_src...@. Remove code $srcdir normalization, which is now useless. --- ChangeLog |4 tests/defs.in | 14 +- 2 files changed, 5 insertions(+), 13 deletions(-) From c0b54eea25d97cc462337ca078fbd4f26238fb54 Mon Sep 17

[PATCH 0/4] {branch "tests-init"} Tests defs: renamings, tweakings and extensions in some global variables

2010-09-02 Thread Stefano Lattarini
Stefano Lattarini (4): Tests defs: $srcdir is unconditionally substituted. Tests defs: new variable $top_srcdir. Tests defs: remove variable $testaclocaldir. Tests defs: $srcdir and $top_srcdir renaming. ChangeLog | 36 tests/Makefile.am

Re: [PATCH] Testsuite: use $SHELL to run tests which are shell scripts.

2010-09-02 Thread Stefano Lattarini
On Thursday 02 September 2010, Ralf Wildenhues wrote: > Well, the only qualm I have with this is that it will in the long > run make it less likely that we are portable to /bin/sh too. Not > a problem per se, but being able to do > cd tests > ./foo.test(or $srcdir/foo.test) > > to quickly

Re: [RFC+PATCHES] Refactoring `tests/defs.in'.

2010-09-02 Thread Stefano Lattarini
On Thursday 02 September 2010, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Thu, Sep 02, 2010 at 08:59:44PM CEST: > > Do you have any particualr suggestion on how to create a new > > remote branch the right way? Is 'git push orig tests-init' > > enough? > > I think so. I usually use --d

Re: [PATCH] Testsuite: use $SHELL to run tests which are shell scripts.

2010-09-02 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Wed, Sep 01, 2010 at 10:23:48PM CEST: > Before this patch, to force the consistent use of (say) ksh as the shell, > I had to resort to something like: > $ CONFIG_SHELL=/bin/ksh /bin/ksh ./configure CONFIG_SHELL=/bin/ksh > $ make > $ make (re)check TEST_LOG_COMPILE

Re: [RFC+PATCHES] Refactoring `tests/defs.in'.

2010-09-02 Thread Stefano Lattarini
On Wednesday 01 September 2010, Stefano Lattarini wrote: > -case $required in > - libtool ) test $libtool_found = yes || Exit 77 ;; > - gettext ) test $gettext_found = yes || Exit 77 ;; > +case " $required " in > + *\ libtool\ | *\ libtoolize\ * ) test $libtool_found = yes ||

Re: Make ar-lib support backslashed files in archives.

2010-09-02 Thread Peter Rosin
Den 2010-09-02 20:37 skrev Ralf Wildenhues: > * Stefano Lattarini wrote on Thu, Sep 02, 2010 at 06:44:34PM CEST: >> On Thursday 02 September 2010, Peter Rosin wrote: >>> $AR -NOLOGO -LIST "$archive" | sed -e 's/\\//g' | while read >>> member; do >>> $AR -NOLOGO -EXTRACT:"$member" "$a

Re: [RFC+PATCHES] Refactoring `tests/defs.in'.

2010-09-02 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Thu, Sep 02, 2010 at 08:59:44PM CEST: > Do you have any particualr suggestion on how to create a new remote > branch the right way? Is 'git push orig tests-init' enough? I think so. I usually use --dry-run first to see what would happen. IIRC you may still have to ex

Re: [RFC+PATCHES] Refactoring `tests/defs.in'.

2010-09-02 Thread Stefano Lattarini
On Thursday 02 September 2010, Ralf Wildenhues wrote: > Hi Stefano, > > * Stefano Lattarini wrote on Wed, Sep 01, 2010 at 11:35:47PM CEST: > > I think it's about time to start the refactoring of > > `tests/defs.in' we spoke about many times in the past. > > > > I'd like to do this in small steps,

Re: Make ar-lib support backslashed files in archives.

2010-09-02 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Thu, Sep 02, 2010 at 06:44:34PM CEST: > On Thursday 02 September 2010, Peter Rosin wrote: > > $AR -NOLOGO -LIST "$archive" | sed -e 's/\\//g' | while read > > member; do > > $AR -NOLOGO -EXTRACT:"$member" "$archive" || exit $? > > done > Given that So

Re: [RFC+PATCHES] Refactoring `tests/defs.in'.

2010-09-02 Thread Ralf Wildenhues
Hi Stefano, * Stefano Lattarini wrote on Wed, Sep 01, 2010 at 11:35:47PM CEST: > I think it's about time to start the refactoring of `tests/defs.in' > we spoke about many times in the past. > > I'd like to do this in small steps, posting one or two patches at the > time and waiting to have them

Re: Make ar-lib support backslashed files in archives. (was [PATCH 0/7] Support for toolchains that are not $host-native.)

2010-09-02 Thread Stefano Lattarini
On Thursday 02 September 2010, Peter Rosin wrote: > It is actually a bug in ar-lib. When you issue > .../ar-lib lib x foo.lib > it runs this loop: > > $AR -NOLOGO -LIST "$archive" | while read member > do > $AR -NOLOGO -EXTRACT:"$member" "$archive" || exit $? > done > > (w

Make ar-lib support backslashed files in archives. (was [PATCH 0/7] Support for toolchains that are not $host-native.)

2010-09-02 Thread Peter Rosin
Hi! [Automakers, this is from the libtool-patches list...] Den 2010-09-02 15:06 skrev Peter Rosin: > 112: Test 24 33 34 45 47 99 100 are "new" failures with low max_cmd_len > and I think the reason is that the file name conversion adds escapes for > the backslashes. I.e. .libs/a1.obj -> .libs\\a1