Re: [BIKESHEDDING PATCH] Generated tests are now just a thin layer around other tests.

2010-05-23 Thread Stefano Lattarini
Here it is my attempt to a patch. Regards, Stefano From 9f43423626ad1c68ee0ba8451fe809f70be3f223 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini Date: Sun, 23 May 2010 17:44:36 +0200 Subject: [PATCH] Fix distcheck failure with distributed generated parallel tests. * tests/Makefile.am ($(para

Re: [BIKESHEDDING PATCH] Generated tests are now just a thin layer around other tests.

2010-05-23 Thread Stefano Lattarini
At Sunday 23 May 2010, Ralf Wildenhues wrote: > > Good catch. Note that my patch on the sepration of instspc.test > > has this same problem too. > > OK, good to know. I haven't looked at the instspc patches yet. Then I'll amend it after this problem will have been solved. > > However, I think

Re: [BIKESHEDDING PATCH] Generated tests are now just a thin layer around other tests.

2010-05-23 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sun, May 23, 2010 at 03:01:20PM CEST: > At Sunday 23 May 2010, Ralf Wildenhues wrote: > > Got lucky and intuition saved me from regressing branch-1.11 with > > this one. I'm applying the fix below on top of this patch and > > merging to master. The nontrivial point

Re: [PATCH] Fix Autoconf version required by Automake's configure.

2010-05-23 Thread Stefano Lattarini
> Well, that AC_PREREQ is already there effectively, only it's hidden > in m4/init.m4 in the AM_INIT_AUTOMAKE macro. Oh. I've just learned something new, thanks. I must say I'd still prefer to have an explicit AC_PREREQ call in configure.ac; anyway, this is mostly a moot issue, since if a devel

Re: [PATCH] Extend tests on `nostdinc' automake option.

2010-05-23 Thread Stefano Lattarini
At Sunday 23 May 2010, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Mon, Apr 26, 2010 at 09:41:06PM CEST: > > Subject: [PATCH] Extend test on `nostdinc' automake option. > > > > * tests/nostdinc.test: Enable `errexit' shell flag. Related and > > unrelated minor changes. Make the greppin

Re: [PATCH] Extend tests on `nostdinc' automake option.

2010-05-23 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Mon, Apr 26, 2010 at 09:41:06PM CEST: > Subject: [PATCH] Extend test on `nostdinc' automake option. > > * tests/nostdinc.test: Enable `errexit' shell flag. Related and > unrelated minor changes. Make the grepping of the generated > Makefile.in slighty stricter. Gene

Re: git-version-gen not EBCDIC compatible

2010-05-23 Thread Ralf Wildenhues
* Eric Blake wrote on Mon, Apr 26, 2010 at 05:44:35PM CEST: > Thanks for the report. I'll push this patch shortly for > git-version-gen, but there are other culprits (MODULES.html.sh, > gnupload, m4/get{delim,line}.m4, m4/javacomp.m4, posix-modules) that are > still ascii-specific. Thanks for the

Re: [PATCH] Fix Autoconf version required by Automake's configure.

2010-05-23 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sun, May 23, 2010 at 03:11:28PM CEST: > At Sunday 23 May 2010, Ralf Wildenhues wrote: > > > By the way, adding an AC_PREREQ call in Automake's own > > > configure.ac would be nice IMHO; I didn't do that because I don't > > > know what is the minimal autoconf version tr

Re: [PATCH] Fix Autoconf version required by Automake's configure.

2010-05-23 Thread Stefano Lattarini
At Sunday 23 May 2010, Ralf Wildenhues wrote: > [ http://lists.gnu.org/archive/html/automake-patches/2010-04/msg00121.html ] > > > By the way, adding an AC_PREREQ call in Automake's own > > configure.ac would be nice IMHO; I didn't do that because I don't > > know what is the minimal autoconf ver

Re: [BIKESHEDDING PATCH] Generated tests are now just a thin layer around other tests.

2010-05-23 Thread Stefano Lattarini
At Sunday 23 May 2010, Ralf Wildenhues wrote: > Got lucky and intuition saved me from regressing branch-1.11 with > this one. I'm applying the fix below on top of this patch and > merging to master. The nontrivial point to note is that in the > wrapper script, srcdir needs to be expanded at t

Re: [PATCH] Add tests about support of wildcards in EXTRA_DIST

2010-05-23 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sun, May 23, 2010 at 02:41:24PM CEST: > At Sunday 23 May 2010, Ralf Wildenhues wrote: > > > > > Unfortunately that turned out to be too optimistic. I'm pushing > > this followup to maint. Tes

Re: [PATCH] Fix Autoconf version required by Automake's configure.

2010-05-23 Thread Ralf Wildenhues
[ http://lists.gnu.org/archive/html/automake-patches/2010-04/msg00121.html ] * Stefano Lattarini wrote on Fri, Apr 30, 2010 at 05:21:03PM CEST: > At Friday 30 April 2010, Eric Blake wrote: > > On 04/30/2010 08:56 AM, Stefano Lattarini wrote: > > > Apparently, Automake configure script tells that a

Re: [PATCH] Add tests about support of wildcards in EXTRA_DIST

2010-05-23 Thread Stefano Lattarini
At Sunday 23 May 2010, Ralf Wildenhues wrote: > Long ago: > > Unfortunately that turned out to be too optimistic. I'm pushing > this followup to maint. Tested on NetBSD 5.99.29 and the pmake > package of Debian. >

Re: [BIKESHEDDING PATCH] Generated tests are now just a thin layer around other tests.

2010-05-23 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sun, Mar 07, 2010 at 05:15:24PM CET: > Generated tests are now just a thin layer around other tests. > > * tests/Makefile.am: Rewrite the rule to generate the `*-p.test' > test scripts so that any of them simply includes the corresponding > `*.test' script (after setti

Relax silent8.test for NetBSD make.

2010-05-23 Thread Ralf Wildenhues
Another spurious testsuite failure with NetBSD make. Committed to master. Cheers, Ralf Relax silent8.test for NetBSD make. * tests/silent8.test: Accept ./foo.info in output as well. diff --git a/tests/silent8.test b/tests/silent8.test index 2546775..6833840 100755 --- a/tests/silent

Fix unportable sed script in maintainer-check test.

2010-05-23 Thread Ralf Wildenhues
For maint. Cheers, Ralf Fix unportable sed script in maintainer-check test. * Makefile.am (sc_tests_Exit_not_exit): Rewrite sed script to not contain semicolon after 'b' or brace commands, for NetBSD. diff --git a/Makefile.am b/Makefile.am index c487874..bbcc882 100644 --- a/Mak

Re: [PATCH] Add tests about support of wildcards in EXTRA_DIST

2010-05-23 Thread Ralf Wildenhues
Long ago: * Ralf Wildenhues wrote on Sat, Feb 20, 2010 at 05:42:30PM CET: > * Stefano Lattarini wrote on Sat, Feb 20, 2010 at 04:49:37PM CET: > > I've written a small patch adding some tests. Note that they are mostly > >

Re: [PATCH] Fixed uncorrectly ordered ChangeLog entries.

2010-05-23 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Sun, May 23, 2010 at 02:08:20PM CEST: > At Sunday 23 May 2010, Ralf Wildenhues wrote: > > Well, that's once again difference between the author date of the > > patch and the commit date. The patches were committed on > > 2010-04-25, and GCS generally recommend using

Re: [PATCH] Avoid possible false negatives in dejagnu7.test.

2010-05-23 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Thu, May 06, 2010 at 12:47:02PM CEST: > Enable the shell `errexit' flag in `tests/dejagnu7.test', so that > previously unchecked failures now cause the whole test to fail. > Also, avoid unportable use of fgrep option `-e'. > From 9b487b1e65ca5d0e3361c484fe624a729c9245

Re: [PATCH] Fix conflnk3.test to work with Solaris/Heirloom Sh.

2010-05-23 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Thu, May 06, 2010 at 07:53:41PM CEST: > From d294e89fcdbfc7b5abf92ee9031647460eec490d Mon Sep 17 00:00:00 2001 > From: Stefano Lattarini > Date: Thu, 6 May 2010 18:12:25 +0200 > Subject: [PATCH] Fix conflnk3.test to work with Solaris/Heirloom Sh. > > * tests/conflnk3.

Re: [PATCH] Fixed uncorrectly ordered ChangeLog entries.

2010-05-23 Thread Stefano Lattarini
At Sunday 23 May 2010, Ralf Wildenhues wrote: > > Well, that's once again difference between the author date of the > patch and the commit date. The patches were committed on > 2010-04-25, and GCS generally recommend using the commit date. > I prefer that to keep the order in the ChangeLog as

Re: [PATCH] Fixed uncorrectly ordered ChangeLog entries.

2010-05-23 Thread Ralf Wildenhues
* Stefano Lattarini wrote on Tue, May 11, 2010 at 12:16:39PM CEST: > Oops. There was a typo in the git commit message :-( > An amended patch is attached. > From 3025ae248e87ff6fa6c6bf9d64d6ee4f17246744 Mon Sep 17 00:00:00 2001 > From: Stefano Lattarini > Date: Sun, 9 May 2010 15:06:25 +0200 > Su

Re: [PATCH] Typofix in ChangeLog entry (2010-04-11, Stefano Lattarini)

2010-05-23 Thread Ralf Wildenhues
Hi Stefano, apologies for letting the patch backlog grow so large. I guess I better tick off patches dealt with, that may make tracking things easier. * Stefano Lattarini wrote on Sat, May 08, 2010 at 03:23:30AM CEST: > Do not leave an empty line between change's summary and details of > change