Re: [PATCH 8/9] Tests on extensibility of silent-rules made stricter.

* Stefano Lattarini wrote on Mon, Apr 26, 2010 at 12:15:33AM CEST: > --- a/tests/silent6.test > +++ b/tests/silent6.test > @@ -99,5 +99,3 @@ $AUTOMAKE > grep 'AM_V_GEN' Makefile.in > $AUTOMAKE --force -Wno-all -Wportability > grep 'AM_V_GEN' Makefile.in > - > -: Please don't remove trailing ':

[PATCH 9/9] Tiny fix in silent8.test (display output of `make' command).

* tests/silent8.test: Make sure that the captured output of `make' command is always displayed. From f9d0ba1d8606dd147c9860fe305d0f0545f5292d Mon Sep 17 00:00:00 2001 From: Stefano Lattarini Date: Sun, 25 Apr 2010 23:05:18 +0200 Subject: [PATCH 9/9] Tiny fix in silent8.test (display output of `mak

[PATCH 8/9] Tests on extensibility of silent-rules made stricter.

* tests/silent6.test: Made stricter w.r.t. the grepping of the output produced by `make'. Updated copyright years. * tests/silent7.test: Likewise. From 582b23876885e456ece989d26c5d947234f3023a Mon Sep 17 00:00:00 2001 From: Stefano Lattarini Date: Sun, 25 Apr 2010 22:57:22 +0200 Subject: [PATCH 8

[PATCH 7/9] Tests on silent-mode for C/Libtool made stricter.

* tests/silent.test: Made stricter w.r.t. the grepping of the output produced by `make'. * tests/silent2.test: Likewise. * tests/silent4.test: Likewise. * tests/silent9.test: Likewise. * tests/silent3.test: Likewise, and add a final `make distclean' command to keep it better in sync with tests/sile

Subject: [PATCH 6/9] Improved test silent5.test.

* tests/silent5.test: Remove by hand all generated C files after non-verbose builds, to ensure the following builds are clean. Try to clean and rebuild with the same verbosity and without removing generated sources in between, to check that this does not trigger a different set of rules. Make grep

[PATCH 5/9] New tests for Automake silent-mode with Fortran.

* tests/silentf77.test: New test. * tests/silentf90.test: Likewise. * tests/Makefile.am (TESTS): Updated accordingly. From fd9b7fbfc6daa4a29f8feb6c3bc7ab9f6761e571 Mon Sep 17 00:00:00 2001 From: Stefano Lattarini Date: Sun, 25 Apr 2010 22:20:57 +0200 Subject: [PATCH 5/9] New tests for Automake sil

[PATCH 4/9] New test silentcxx.test (Automake/C++ silent-mode).

* tests/silentcxx.test: New test. * tests/Makefile.am (TESTS): Updated accordingly. From 0d1ddd484c6b08e3136e7f60e6dc6acab5f5d9de Mon Sep 17 00:00:00 2001 From: Stefano Lattarini Date: Sun, 25 Apr 2010 22:20:57 +0200 Subject: [PATCH 4/9] New test silentcxx.test (Automake/C++ silent-mode). * tests

[PATCH 3/9] New test silentyacc.test (Automake/Yacc silent-mode).

* tests/silentyacc.test: New test. * tests/Makefile.am (TESTS): Updated accordingly. From e81a3868d34056b320ea346d119c0bcd3ee4716f Mon Sep 17 00:00:00 2001 From: Stefano Lattarini Date: Sun, 25 Apr 2010 22:20:57 +0200 Subject: [PATCH 3/9] New test silentyacc.test (Automake/Yacc silent-mode). * te

[PATCH 2/9] New test silentlex.test (Automake/Lex silent-mode).

* tests/silentlex.test: New test. * tests/Makefile.am (TESTS): Updated accordingly. From 1feeaf711427c19ec784fd4fbe5eab6442e55b9c Mon Sep 17 00:00:00 2001 From: Stefano Lattarini Date: Sun, 25 Apr 2010 22:20:57 +0200 Subject: [PATCH 2/9] New test silentlex.test (Automake/Lex silent-mode). * tes

[PATCH 1/9] Relax silent-rules tests to cater for verbose makes.

* tests/silent4.test: When testing silent builds, don't fail if make's output simply contains the `mv' substring, but only if it contains the `mv ' substring (note the trailing space). * tests/silent5.test: Likewise. * tests/silent9.test: Likewise. * tests/silent.test: Likewise, plus updated copyri

[PATCH 0/9] Extend and improve tests on Automake's silent-mode

Hello automakers. Here I (re)propose a series of patches to improve and extend the tests on Automake's silent-mode. This series is an extension/improvement over my previous patch series "[PATCH 0/5] Modularize testing of automake silent-mode for languages != C". For a reference see:

Re: [PATCH 0/5] Modularize testing of automake silent-mode for languages != C

The patches in this series have been amended/rewritten/extended/fixed in various ways. I'll soon repropose the series in a new thread: "[PATCH 0/9] Extend and improve tests on Automake's silent-mode" Regards, Stefano

Re: Warning and error message formatting cleanups.

* Ralf Wildenhues wrote on Sun, Apr 25, 2010 at 07:11:14PM CEST: > This is for master only, I didn't care to backport this work. > I will push things out once the testsuite run has finished. Done with this squashed in. diff --git a/ChangeLog b/ChangeLog index ffe4715..71b0d9b 100644 --- a/ChangeL

Warning and error message formatting cleanups.

Some more trivial cleanup for GNU Coding Standards requirements in message formatting, and blunders like trailing newlines in messages. I'm not actually sure what to do when messages consist of two sentences. For now I kept the period at the end of the first and the capitalization of the second.

Fix more duplicate message prefixes.

I missed a couple of duplicate message prefixes in the 2010-04-11 changes to master. Fixing thusly. Cheers, Ralf Fix more duplicate message prefixes. * lib/Automake/XFile.pm (seek): Do not prepend $me. ($me): Remove now-unused package-global. * aclocal.in (check_acinclude):

testsuite: ensure verbose printing of captured output.

for f in tests/*test do sed = $f | sed -n 'N s/\n/:/ /2> *stderr/{ N N s/[^\n]*\n// s/\n/:/ /cat stderr/!p }' | sed "s|^|$f:|" done found another couple of missed verbose printing of captured output, on

Fix leftover call to removed function macros_dump.

This fixes a theoretical bug introduced with incomplete renaming in a 2003-05-25 patch. I do not know how to trigger the failure path except by actually introducing the bug in automake.in (tested by replacing the 'if' condition with one that evaluates to true). For maint. Cheers, Ralf Fix l

Fix typo in manual.

For maint. Cheers, Ralf Fix typo in manual. * doc/automake.texi (Simple Tests using parallel-tests): Add missing closing parenthesis. diff --git a/doc/automake.texi b/doc/automake.texi index ae5e364..939ea00 100644 --- a/doc/automake.texi +++ b/doc/automake.texi @@ -8716,7 +8716

Fix placing of ellipses in English text.

a greeting from the language police. ;-) Pushing to master. Cheers, Ralf Fix placing of ellipses in English text and synopses. * Makefile.am: Be sure to add a space before `...' in natural language text. * automake.in (scan_autoconf_traces): Likewise. * lib/Automake/Rul

Re: [PATCH 5/5] Improved test silent5.test.

* Stefano Lattarini wrote on Sun, Apr 25, 2010 at 05:36:49PM CEST: > At Sunday 25 April 2010, Ralf Wildenhues wrote: > > * Stefano Lattarini wrote on Sun, Apr 25, 2010 at 05:13:11PM CEST: > > > At Sunday 25 April 2010, Ralf Wildenhues wrote: > > and you didn't seem to > > think before that it woul

Re: [PATCH] Make badopt.test stricter (by enabling `set -e').

* Stefano Lattarini wrote on Sun, Apr 25, 2010 at 02:42:04PM CEST: > At Sunday 25 April 2010, Ralf Wildenhues wrote: > > For what it's worth, since git this issue should be fairly moot. > > You can keep branches for a long time, and merge them into your > > devel-branch-du-jour for testing them. Y

Re: [PATCH 5/5] Improved test silent5.test.

At Sunday 25 April 2010, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Sun, Apr 25, 2010 at 05:13:11PM CEST: > > At Sunday 25 April 2010, Ralf Wildenhues wrote: > > > Indeed. Grepping for '^mv ' and ' mv ' should work though. > > > > Or better again, we could strip off the `Entering/Leav

Re: [PATCH 5/5] Improved test silent5.test.

* Stefano Lattarini wrote on Sun, Apr 25, 2010 at 05:13:11PM CEST: > At Sunday 25 April 2010, Ralf Wildenhues wrote: > > Indeed. Grepping for '^mv ' and ' mv ' should work though. > Or better again, we could strip off the `Entering/Leaving directory' > lines outputted by GNU make. WDYT? Other m

Re: [PATCH 5/5] Improved test silent5.test.

At Sunday 25 April 2010, Ralf Wildenhues wrote: > > > > grep mv stdout && Exit 1 > > > > On the contrary, this seems too much strict, since it would fail > > (with GNU make at least) if the automake source tree is placed in > > a directory whose name contains the `mv' substring. > > Indeed. Gr

[PATCH] New tests: Heirlooom make and Lex/Yacc rules.

This stems from a discussion on bug-automake: Apparently, when yacc `*.y' and/or lex `*.l' files are used in a foo_SOURCES primary, the generated Makefile.in does not prevent Heirloom make from using its builtin ".l => .o" an

Re: [PATCH 5/5] Improved test silent5.test.

* Stefano Lattarini wrote on Sun, Apr 25, 2010 at 04:28:43PM CEST: > At Sunday 25 April 2010, Ralf Wildenhues wrote: > > > --- a/tests/silent5.test > > > +++ b/tests/silent5.test > > > > > > @@ -116,7 +119,7 @@ do > > >$MAKE >stdout || { cat stdout; Exit 1; } > > >cat stdout > > >grep '

Re: [PATCH 5/5] Improved test silent5.test.

At Sunday 25 April 2010, Ralf Wildenhues wrote: > > > --- a/tests/silent5.test > > +++ b/tests/silent5.test > > > > @@ -116,7 +119,7 @@ do > >$MAKE >stdout || { cat stdout; Exit 1; } > >cat stdout > >grep ' -c' stdout && Exit 1 > > - grep ' -o ' stdout && Exit 1 > > + grep ' -o' std

Re: [PATCH] Make badopt.test stricter (by enabling `set -e').

At Sunday 25 April 2010, Stefano Lattarini wrote: > > > > Yes, that would be better, because it would lower the per-patch > > effort. Thanks. > > OK, I'll use bigger lumps when it makes sense. > That said, I think this patch should be applied as-is, since it fixes a potential false negative i

Re: [PATCH] Make badopt.test stricter (by enabling `set -e').

At Sunday 25 April 2010, Ralf Wildenhues wrote: > Hello Stefano, > > > However, I could at least clump the changes in bigger lumps (say > > a dozen of files modified togheter), if you still think this > > would be more convenient. WDYT? > > Yes, that would be better, because it would lower the

Re: [PATCH] Minor improvements in comments of silent3.test

* Stefano Lattarini wrote on Thu, Apr 22, 2010 at 10:51:49PM CEST: > Subject: [PATCH] Minor improvements in comments of silent3.test. > > * tests/silent3.test: Tell to keep it in sync with `silent9.test' > too. Thanks!

Re: [PATCH 5/5] Improved test silent5.test.

Hi Stefano, * Stefano Lattarini wrote on Thu, Apr 22, 2010 at 10:31:24PM CEST: > Subject: [PATCH 5/5] Improved test silent5.test. > > * tests/silent5.test: Removed by hand all generated C files after > non-verbose builds, to ensure the following builds are clean. > A couple of greps of make's out

Re: [QUESTION] cscope.test

Hi Stefano, * Stefano Lattarini wrote on Fri, Apr 23, 2010 at 07:23:03PM CEST: > Myabe this is a stupid question, but I've not been not able to figure > out what's the role of the following trailing lines in `cscope.test': > > $MAKE || Exit 77 This line was added in a1d5239b5e to cope with abs

Re: [PATCH] Make badopt.test stricter (by enabling `set -e').

Hello Stefano, * Stefano Lattarini wrote on Wed, Apr 21, 2010 at 01:59:51PM CEST: > In fact, I'm inclined to keep the patches enabling `set -e' separated > for three reasons: > > 1. To make the analysis of these patches simpler (as they are very > short); this should tendentially lead to more