Re: config.rpath missing

2006-05-23 Thread Ralf Wildenhues
[ This is http://lists.gnu.org/archive/html/automake-patches/2006-05/msg00081.html ] Hello bug-gettext readers, * Stepan Kasal wrote on Tue, May 23, 2006 at 01:09:09PM CEST: > I have installed current CVS version of Autoconf, and have run > Automake's "make check". The following tests failed,

Re: Creating subdirs of distdir

2006-05-23 Thread Ralf Wildenhues
* quoting myself: > * Stepan Kasal wrote on Tue, May 23, 2006 at 10:43:50PM CEST: > > - or if the author of Makefile.am usees $(srcdir) or $(top_srcdir) > > (well educated maintainers don't) > > This is wrong. Well-educated maintainers do this in some situations: > when the file in question is

Re: Creating subdirs of distdir

2006-05-23 Thread Ralf Wildenhues
Hi Stepan, * Stepan Kasal wrote on Tue, May 23, 2006 at 10:43:50PM CEST: > On Tue, May 23, 2006 at 09:31:18PM +0200, Ralf Wildenhues wrote: > > > I think we can kill the per-file forks before the mkdir_p, too. > > You mean the $(srcdir) and $(top_srcdir) stripping. But it takes > place only in

Re: Creating subdirs of distdir

2006-05-23 Thread Stepan Kasal
Hello Ralf, thank you for your review and improvements. A few quick comments: On Tue, May 23, 2006 at 09:31:18PM +0200, Ralf Wildenhues wrote: > [...] nobody uses `|' in a file name. I think it's pretty safe > to assume this. [...] Sure it is. The current code already assumed that: case .

Re: Creating subdirs of distdir

2006-05-23 Thread Ralf Wildenhues
Hi Stepan, * Stepan Kasal wrote on Tue, May 23, 2006 at 03:29:01PM CEST: > On Sun, May 14, 2006 at 07:32:57PM +0200, Ralf Wildenhues wrote: > > Hmm. You could "sort -u" the list of directories to create at "make > > dist" time. > > nice idea. Attached please find a patch which implements it. T

Re: Creating subdirs of distdir

2006-05-23 Thread Stepan Kasal
Hello, On Sun, May 14, 2006 at 07:32:57PM +0200, Ralf Wildenhues wrote: > Hmm. You could "sort -u" the list of directories to create at "make > dist" time. nice idea. Attached please find a patch which implements it. The patch eliminates the following dir=`echo "$$file" | sed -e 's,/[^

config.rpath missing

2006-05-23 Thread Stepan Kasal
Hello, I have installed current CVS version of Autoconf, and have run Automake's "make check". The following tests failed, because automake wasn't able to --add-missing config.rpath: gettext.test gettext2.test subcond.test When I installed config.rpath to automake/lib, all three test passed