Re: wiringX-git PKGBUILD Review Request (#2)

2024-01-07 Thread Doug Newgard
> If there is > ever an actual "Release" of wiringX, then we can remove the pkgver() function > entirely. That's not how -git PKGBUILDs work. It builds from HEAD and should always build from HEAD. You really need to fix the pkgver function. Looking at the upstream CMakeLists.txt, I would version

Re: wiringX-git PKGBUILD Review Request (#2)

2024-01-07 Thread David C. Rankin
On 1/5/24 21:01, Aaron Liu wrote: Hmm, I know nothing on the library side of things, but as Arch conventions dictate: 1. All package titles should be lowercase, so wiringx-git, perhaps?. 2. You should probably do a provides=(libwiringx.so wiringx) so the soname is searchable and conflicts are

Re: wiringX-git PKGBUILD Review Request

2024-01-07 Thread David C. Rankin
On 1/6/24 11:36, Doug Newgard wrote: mv "$pkgdir/usr/local/"* "$pkgdir/usr" rm -r "$pkgdir/usr/local" Can you not set a prefix? This step should not normally necessary. Yes it can, I was reading the cmake documentation wrong: build() { cd "${srcdir}/$_gitname/build" cmake -DCMA

Re: wiringX-git PKGBUILD Review Request

2024-01-07 Thread David C. Rankin
On 1/6/24 11:36, Doug Newgard wrote: url="httpx://wiringx.org/" Typo fat-fingers pkgver() { cd "${srcdir}/$_gitname" echo $(git rev-list --count HEAD).$(git rev-parse --short HEAD) } This will cause problems if there is ever a release. See https://wiki.archlinux.org/title/VCS_pack